Generated: 2025-08-07T03:49:43.146593
Recommendation: Immediate action required - resolve all critical issues before proceeding with release
Priority: P1 | Severity: Critical
Need type annotation for "fixes_applied" (hint: "fixes_applied: list[
Estimated Effort: High (4-8 hours)
Priority: P1 | Severity: Critical
Need type annotation for "results" (hint: "results: list[
Estimated Effort: High (4-8 hours)
Priority: P1 | Severity: Critical
Need type annotation for "fixes_applied" (hint: "fixes_applied: list[
Estimated Effort: High (4-8 hours)
Priority: P1 | Severity: Critical
Need type annotation for "fixes_applied" (hint: "fixes_applied: list[
Estimated Effort: High (4-8 hours)
Priority: P1 | Severity: Critical
possibly-used-before-assignment: Possibly using variable 'dev_state' before assignment
Estimated Effort: High (4-8 hours)
Priority: P1 | Severity: Critical
import-error: Unable to import 'argument_validator'
Estimated Effort: High (4-8 hours)
Priority: P1 | Severity: Critical
import-error: Unable to import 'ansible.module_utils.storage_lsr.argument_validator'
Estimated Effort: High (4-8 hours)
Priority: P1 | Severity: Critical
no-name-in-module: No name 'storage_lsr' in module 'ansible.module_utils'
Estimated Effort: High (4-8 hours)
Priority: P1 | Severity: Critical
import-error: Unable to import 'ansible.module_utils.storage_lsr.size'
Estimated Effort: High (4-8 hours)
Priority: P1 | Severity: Critical
no-name-in-module: No name 'storage_lsr' in module 'ansible.module_utils'
Estimated Effort: High (4-8 hours)
Priority: P1 | Severity: Critical
import-error: Unable to import 'ansible.module_utils.storage_lsr.size'
Estimated Effort: High (4-8 hours)
Priority: P1 | Severity: Critical
no-name-in-module: No name 'storage_lsr' in module 'ansible.module_utils'
Estimated Effort: High (4-8 hours)
Priority: P1 | Severity: Critical
possibly-used-before-assignment: Possibly using variable 'dev_state' before assignment
Estimated Effort: High (4-8 hours)
Priority: P1 | Severity: Critical
import-error: Unable to import 'argument_validator'
Estimated Effort: High (4-8 hours)
Priority: P1 | Severity: Critical
import-error: Unable to import 'ansible.module_utils.storage_lsr.argument_validator'
Estimated Effort: High (4-8 hours)
Priority: P1 | Severity: Critical
no-name-in-module: No name 'storage_lsr' in module 'ansible.module_utils'
Estimated Effort: High (4-8 hours)
Priority: P1 | Severity: Critical
import-error: Unable to import 'ansible.module_utils.storage_lsr.size'
Estimated Effort: High (4-8 hours)
Priority: P1 | Severity: Critical
no-name-in-module: No name 'storage_lsr' in module 'ansible.module_utils'
Estimated Effort: High (4-8 hours)
Priority: P1 | Severity: Critical
import-error: Unable to import 'ansible.module_utils.storage_lsr.size'
Estimated Effort: High (4-8 hours)
Priority: P1 | Severity: Critical
no-name-in-module: No name 'storage_lsr' in module 'ansible.module_utils'
Estimated Effort: High (4-8 hours)
Priority: P2 | Severity: High
Found 1 modified files and 4 untracked files. All changes must be committed before creating release 0.9.1.
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-raised: Raising too general exception: Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-variable: Unused variable '_unused_'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-variable: Unused variable '_ignored_'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except AttributeError as exc' and 'raise MyError("Macvlan mode '%s' is not recognized" % mode) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'raise MyError('created connection failed to normalize: %s' % e) from e'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-variable: Unused variable 'cc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'raise MyError('configuration error: %s' % e) from e'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unnecessary-pass: Unnecessary pass statement
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'raise MyError('failure loading libnm library: %s' % e) from e'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
fixme: FIXME: Maybe this restriction can be removed. Need to make sure that
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
fixme: FIXME: Maybe just accept all values, even if they are not
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
fixme: FIXME: Seems to be a duplicate check since "wait" will be removed from
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
redefined-builtin: Redefining built-in 'range'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except AttributeError as exc' and 'raise ValidationError(name, 'invalid content is not a dictionary') from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except KeyError as exc' and 'raise ValidationError(name, "invalid key '%s'" % setting) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _validate of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'raise ValidationError(e.name, e.error_message) from e'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _validate of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'raise ValidationError(e.name, e.error_message) from e'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except Exception as exc' and 'raise ValidationError(name, "value '%s' is not a valid IP%s address" % (value, Util.addr_family_to_v(self.family))) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except MyError as exc' and 'raise ValidationError(name, "value '%s' is not a valid MAC address%s" % (value, enum_ex)) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except Exception as exc' and 'raise ValidationError(name, "value '%s' is not a valid IP%s address with prefix length" % (value, Util.addr_family_to_v(self.family))) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-argument: Unused argument 'value'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-argument: Unused argument 'value'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-argument: Unused argument 'value'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except MyError as exc' and 'raise ValidationError.from_connection(idx, "profile references a parent '%s' which has 'interface_name' missing" % connection['parent']) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except MyError as exc' and 'raise ValidationError.from_connection(idx, "profile references a controller '%s' which has 'interface_name' missing" % connection['controller']) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-variable: Unused variable 'unused'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
pointless-statement: Statement seems to have no effect
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
pointless-statement: Statement seems to have no effect
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
pointless-statement: Statement seems to have no effect
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
deprecated-method: Using deprecated method warn()
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
deprecated-method: Using deprecated method warn()
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
fixme: FIXME: encoding issues regarding python unicode string
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except Exception as exc' and 'raise MyError("not a valid MAC address: '%s'" % mac_str) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except Exception as exc' and 'raise MyError("invalid address '%s'" % address) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
redefined-outer-name: Redefining name 'sorted_data' from outer scope (line 166)
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
fixme: XXX add support for LVM RAID raid0 level
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
fixme: XXX: blivet has to store cipher, key_size, luks_version for existing before we
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
fixme: XXX If we have no key we will always re-encrypt.
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
fixme: TODO: see if we can create this device w/ the specified name
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
fixme: XXX fail if any disk isn't resolved?
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
fixme: TODO: see if we can create this device w/ the specified name
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
fixme: XXX: scheduling ActionRemoveMember is currently broken, we need to execute
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
fixme: XXX workaround for https://github.com/storaged-project/blivet/pull/1040
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
import-self: Module import itself
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
import-self: Module import itself
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
import-self: Module import itself
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _name of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _name of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _name of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except RaidError as exc' and 'raise BlivetAnsibleError('%s is not a valid RAID level' % raid_level) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'raise BlivetAnsibleError("cannot create RAID '%s': %s" % (raid_name, str(e))) from e'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _packages of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _key_file of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _key_file of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except ValueError as exc' and 'raise BlivetAnsibleError("invalid percentage '%s' size specified for volume '%s'" % (self._volume['size'], self._volume['name'])) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _device of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except Exception as exc' and 'raise BlivetAnsibleError("invalid size specification for volume '%s': '%s'" % (self._volume['name'], self._volume['size'])) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unnecessary-pass: Unnecessary pass statement
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'raise BlivetAnsibleError("failed to unmount '%s' to allow offline resize: %s" % (self._device.name, str(e))) from e'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _resize_support of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _resize_support of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'raise BlivetAnsibleError("volume '%s' cannot be resized from %s to %s: %s" % (self._device.name, self._device.size, size, str(e))) from e'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _disks of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _disks of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _disks of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _device of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except Exception as exc' and 'raise BlivetAnsibleError("failed set up volume '%s'" % self._volume['name']) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except Exception as exc' and 'raise BlivetAnsibleError("partition allocation failed for volume '%s'" % self._volume['name']) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _device of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _device of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except ValueError as exc' and 'raise BlivetAnsibleError("invalid percentage '%s' size specified for thin volume '%s'" % (self._volume['size'], self._volume['name'])) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _device of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _device of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except BlivetAnsibleError as exc' and 'raise BlivetAnsibleError("specified 'vdo_pool_size' for volume '%s' exceeds available space in pool '%s' (%s)" % (pool_size, parent_device.name, parent_device.free_space)) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'raise BlivetAnsibleError("failed to set up VDO pool '%s': %s" % (self._volume['name'], str(e))) from e'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _device of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'raise BlivetAnsibleError("failed to detach cache from volume '%s': %s" % (self._device.name, str(e))) from e'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _device of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _device of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _thinpools of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _thinpools of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _thinpools of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _device of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _device of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _device of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _device of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'raise BlivetAnsibleError("failed to set up volume '%s': %s" % (self._volume['name'], str(e))) from e'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'raise BlivetAnsibleError("failed to allocate partitions for mdraid '%s': %s" % (self._volume['name'], str(e))) from e'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _device of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _device of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _device of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _device of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _device of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'raise BlivetAnsibleError("failed to set up volume '%s': %s" % (self._volume['name'], str(e))) from e'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _pool of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
abstract-method: Method '_get_format' is abstract in class 'BlivetBase' but is not overridden in child class 'BlivetPool'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _packages of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unnecessary-pass: Unnecessary pass statement
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except Exception as exc' and 'raise BlivetAnsibleError("failed to allocate partitions for pool '%s'" % self._pool['name']) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
abstract-method: Method '_get_format' is abstract in class 'BlivetBase' but is not overridden in child class 'BlivetPartitionPool'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except ValueError as exc' and 'raise BlivetAnsibleError("invalid percentage '%s' size specified in pool '%s'" % (spec, pool_device.name)) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except Exception as exc' and 'raise BlivetAnsibleError("invalid size specification '%s' in pool '%s'" % (spec, pool_device.name)) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'raise BlivetAnsibleError("failed to set up thin pool '%s': %s" % (self._pool['name'], str(e))) from e'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'raise BlivetAnsibleError("failed to add disk '%s' to pool '%s': %s" % (disk.name, self._pool['name'], str(e))) from e'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'raise BlivetAnsibleError("failed to remove member '%s' from pool '%s': %s" % (pv.name, self._pool['name'], str(e))) from e'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'raise BlivetAnsibleError("failed to set up pool '%s': %s" % (self._pool['name'], str(e))) from e'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
attribute-defined-outside-init: Attribute '_thinpools' defined outside __init__
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
attribute-defined-outside-init: Attribute '_thinpools' defined outside __init__
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
attribute-defined-outside-init: Attribute '_thinpools' defined outside __init__
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _clevis of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _clevis of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _clevis of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'raise BlivetAnsibleError("failed to add disk '%s' to pool '%s': %s" % (disk.name, self._pool['name'], str(e))) from e'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'raise BlivetAnsibleError("failed to set up pool '%s': %s" % (self._pool['name'], str(e))) from e'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _volume of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _volume of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _volume of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _blivet_volumes of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _volume of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _volume of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _volume of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _get_volumes of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _blivet_volumes of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
redefined-builtin: Redefining built-in 'input'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
redefined-builtin: Redefining built-in 'input'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
global-statement: Using the global statement
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
global-statement: Using the global statement
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
global-statement: Using the global statement
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
global-variable-undefined: Global variable 'diskvolume_mkfs_option_map' undefined at the module level
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
global-statement: Using the global statement
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
global-statement: Using the global statement
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
global-variable-undefined: Global variable 'uses_kmod_kvdo' undefined at the module level
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except ValueError as exc' and 'raise TypeError("'%s' has to be an integer" % value) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except ValueError as exc' and 'raise TypeError("'%s' has to be a float" % value) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _validate_list of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _validate_str of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _validate_bool of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _validate_int of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _validate_float of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-argument: Unused argument 'error_log'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-argument: Unused argument 'updated_params'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
f-string-without-interpolation: Using an f-string that does not have any interpolated variables
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
f-string-without-interpolation: Using an f-string that does not have any interpolated variables
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
f-string-without-interpolation: Using an f-string that does not have any interpolated variables
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
f-string-without-interpolation: Using an f-string that does not have any interpolated variables
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-import: Unused import os
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-import: Unused import glob
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-import: Unused import shutil
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-import: Unused List imported from typing
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
f-string-without-interpolation: Using an f-string that does not have any interpolated variables
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
f-string-without-interpolation: Using an f-string that does not have any interpolated variables
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
f-string-without-interpolation: Using an f-string that does not have any interpolated variables
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
f-string-without-interpolation: Using an f-string that does not have any interpolated variables
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-import: Unused import os
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-import: Unused import yaml
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-import: Unused import glob
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-import: Unused List imported from typing
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-import: Unused import os
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-import: Unused import sys
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-variable: Unused variable 'i'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
f-string-without-interpolation: Using an f-string that does not have any interpolated variables
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
f-string-without-interpolation: Using an f-string that does not have any interpolated variables
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
f-string-without-interpolation: Using an f-string that does not have any interpolated variables
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
f-string-without-interpolation: Using an f-string that does not have any interpolated variables
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
f-string-without-interpolation: Using an f-string that does not have any interpolated variables
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-import: Unused import os
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-variable: Unused variable 'feature_name'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-import: Unused import os
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-import: Unused import sys
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
f-string-without-interpolation: Using an f-string that does not have any interpolated variables
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
f-string-without-interpolation: Using an f-string that does not have any interpolated variables
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-variable: Unused variable 'feature_name'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
bare-except: No exception type(s) specified
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
subprocess-run-check: 'subprocess.run' used without explicitly defining the value for 'check'.
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
subprocess-run-check: 'subprocess.run' used without explicitly defining the value for 'check'.
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
f-string-without-interpolation: Using an f-string that does not have any interpolated variables
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-raised: Raising too general exception: Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-variable: Unused variable '_unused_'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-variable: Unused variable '_ignored_'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except AttributeError as exc' and 'raise MyError("Macvlan mode '%s' is not recognized" % mode) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'raise MyError('created connection failed to normalize: %s' % e) from e'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-variable: Unused variable 'cc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'raise MyError('configuration error: %s' % e) from e'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unnecessary-pass: Unnecessary pass statement
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'raise MyError('failure loading libnm library: %s' % e) from e'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
fixme: FIXME: Maybe this restriction can be removed. Need to make sure that
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
fixme: FIXME: Maybe just accept all values, even if they are not
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
fixme: FIXME: Seems to be a duplicate check since "wait" will be removed from
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
redefined-builtin: Redefining built-in 'range'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except AttributeError as exc' and 'raise ValidationError(name, 'invalid content is not a dictionary') from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except KeyError as exc' and 'raise ValidationError(name, "invalid key '%s'" % setting) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _validate of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'raise ValidationError(e.name, e.error_message) from e'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _validate of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'raise ValidationError(e.name, e.error_message) from e'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except Exception as exc' and 'raise ValidationError(name, "value '%s' is not a valid IP%s address" % (value, Util.addr_family_to_v(self.family))) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except MyError as exc' and 'raise ValidationError(name, "value '%s' is not a valid MAC address%s" % (value, enum_ex)) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except Exception as exc' and 'raise ValidationError(name, "value '%s' is not a valid IP%s address with prefix length" % (value, Util.addr_family_to_v(self.family))) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-argument: Unused argument 'value'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-argument: Unused argument 'value'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-argument: Unused argument 'value'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except MyError as exc' and 'raise ValidationError.from_connection(idx, "profile references a parent '%s' which has 'interface_name' missing" % connection['parent']) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except MyError as exc' and 'raise ValidationError.from_connection(idx, "profile references a controller '%s' which has 'interface_name' missing" % connection['controller']) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-variable: Unused variable 'unused'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
pointless-statement: Statement seems to have no effect
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
pointless-statement: Statement seems to have no effect
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
pointless-statement: Statement seems to have no effect
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
deprecated-method: Using deprecated method warn()
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
deprecated-method: Using deprecated method warn()
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
fixme: FIXME: encoding issues regarding python unicode string
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except Exception as exc' and 'raise MyError("not a valid MAC address: '%s'" % mac_str) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except Exception as exc' and 'raise MyError("invalid address '%s'" % address) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
redefined-outer-name: Redefining name 'sorted_data' from outer scope (line 166)
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
fixme: XXX add support for LVM RAID raid0 level
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
fixme: XXX: blivet has to store cipher, key_size, luks_version for existing before we
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
fixme: XXX If we have no key we will always re-encrypt.
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
fixme: TODO: see if we can create this device w/ the specified name
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
fixme: XXX fail if any disk isn't resolved?
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
fixme: TODO: see if we can create this device w/ the specified name
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
fixme: XXX: scheduling ActionRemoveMember is currently broken, we need to execute
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
fixme: XXX workaround for https://github.com/storaged-project/blivet/pull/1040
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
import-self: Module import itself
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
import-self: Module import itself
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
import-self: Module import itself
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _name of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _name of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _name of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except RaidError as exc' and 'raise BlivetAnsibleError('%s is not a valid RAID level' % raid_level) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'raise BlivetAnsibleError("cannot create RAID '%s': %s" % (raid_name, str(e))) from e'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _packages of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _key_file of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _key_file of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except ValueError as exc' and 'raise BlivetAnsibleError("invalid percentage '%s' size specified for volume '%s'" % (self._volume['size'], self._volume['name'])) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _device of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except Exception as exc' and 'raise BlivetAnsibleError("invalid size specification for volume '%s': '%s'" % (self._volume['name'], self._volume['size'])) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unnecessary-pass: Unnecessary pass statement
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'raise BlivetAnsibleError("failed to unmount '%s' to allow offline resize: %s" % (self._device.name, str(e))) from e'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _resize_support of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _resize_support of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'raise BlivetAnsibleError("volume '%s' cannot be resized from %s to %s: %s" % (self._device.name, self._device.size, size, str(e))) from e'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _disks of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _disks of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _disks of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _device of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except Exception as exc' and 'raise BlivetAnsibleError("failed set up volume '%s'" % self._volume['name']) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except Exception as exc' and 'raise BlivetAnsibleError("partition allocation failed for volume '%s'" % self._volume['name']) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _device of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _device of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except ValueError as exc' and 'raise BlivetAnsibleError("invalid percentage '%s' size specified for thin volume '%s'" % (self._volume['size'], self._volume['name'])) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _device of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _device of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except BlivetAnsibleError as exc' and 'raise BlivetAnsibleError("specified 'vdo_pool_size' for volume '%s' exceeds available space in pool '%s' (%s)" % (pool_size, parent_device.name, parent_device.free_space)) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'raise BlivetAnsibleError("failed to set up VDO pool '%s': %s" % (self._volume['name'], str(e))) from e'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _device of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'raise BlivetAnsibleError("failed to detach cache from volume '%s': %s" % (self._device.name, str(e))) from e'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _device of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _device of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _thinpools of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _thinpools of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _thinpools of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _device of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _device of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _device of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _device of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'raise BlivetAnsibleError("failed to set up volume '%s': %s" % (self._volume['name'], str(e))) from e'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'raise BlivetAnsibleError("failed to allocate partitions for mdraid '%s': %s" % (self._volume['name'], str(e))) from e'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _device of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _device of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _device of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _device of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _device of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'raise BlivetAnsibleError("failed to set up volume '%s': %s" % (self._volume['name'], str(e))) from e'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _pool of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
abstract-method: Method '_get_format' is abstract in class 'BlivetBase' but is not overridden in child class 'BlivetPool'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _packages of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unnecessary-pass: Unnecessary pass statement
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except Exception as exc' and 'raise BlivetAnsibleError("failed to allocate partitions for pool '%s'" % self._pool['name']) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
abstract-method: Method '_get_format' is abstract in class 'BlivetBase' but is not overridden in child class 'BlivetPartitionPool'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except ValueError as exc' and 'raise BlivetAnsibleError("invalid percentage '%s' size specified in pool '%s'" % (spec, pool_device.name)) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except Exception as exc' and 'raise BlivetAnsibleError("invalid size specification '%s' in pool '%s'" % (spec, pool_device.name)) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'raise BlivetAnsibleError("failed to set up thin pool '%s': %s" % (self._pool['name'], str(e))) from e'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'raise BlivetAnsibleError("failed to add disk '%s' to pool '%s': %s" % (disk.name, self._pool['name'], str(e))) from e'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'raise BlivetAnsibleError("failed to remove member '%s' from pool '%s': %s" % (pv.name, self._pool['name'], str(e))) from e'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'raise BlivetAnsibleError("failed to set up pool '%s': %s" % (self._pool['name'], str(e))) from e'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
attribute-defined-outside-init: Attribute '_thinpools' defined outside __init__
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
attribute-defined-outside-init: Attribute '_thinpools' defined outside __init__
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
attribute-defined-outside-init: Attribute '_thinpools' defined outside __init__
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _clevis of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _clevis of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _clevis of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'raise BlivetAnsibleError("failed to add disk '%s' to pool '%s': %s" % (disk.name, self._pool['name'], str(e))) from e'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'raise BlivetAnsibleError("failed to set up pool '%s': %s" % (self._pool['name'], str(e))) from e'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _volume of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _volume of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _volume of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _blivet_volumes of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _volume of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _volume of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _volume of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _get_volumes of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _blivet_volumes of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
redefined-builtin: Redefining built-in 'input'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
redefined-builtin: Redefining built-in 'input'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
global-statement: Using the global statement
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
global-statement: Using the global statement
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
global-statement: Using the global statement
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
global-variable-undefined: Global variable 'diskvolume_mkfs_option_map' undefined at the module level
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
global-statement: Using the global statement
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
global-statement: Using the global statement
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
global-variable-undefined: Global variable 'uses_kmod_kvdo' undefined at the module level
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except ValueError as exc' and 'raise TypeError("'%s' has to be an integer" % value) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
raise-missing-from: Consider explicitly re-raising using 'except ValueError as exc' and 'raise TypeError("'%s' has to be a float" % value) from exc'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _validate_list of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _validate_str of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _validate_bool of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _validate_int of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
protected-access: Access to a protected member _validate_float of a client class
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-argument: Unused argument 'error_log'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-argument: Unused argument 'updated_params'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
f-string-without-interpolation: Using an f-string that does not have any interpolated variables
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
f-string-without-interpolation: Using an f-string that does not have any interpolated variables
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
f-string-without-interpolation: Using an f-string that does not have any interpolated variables
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
f-string-without-interpolation: Using an f-string that does not have any interpolated variables
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-import: Unused import os
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-import: Unused import glob
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-import: Unused import shutil
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-import: Unused List imported from typing
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
f-string-without-interpolation: Using an f-string that does not have any interpolated variables
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
f-string-without-interpolation: Using an f-string that does not have any interpolated variables
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
f-string-without-interpolation: Using an f-string that does not have any interpolated variables
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
f-string-without-interpolation: Using an f-string that does not have any interpolated variables
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-import: Unused import os
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-import: Unused import yaml
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-import: Unused import glob
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-import: Unused List imported from typing
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-import: Unused import os
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-import: Unused import sys
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-variable: Unused variable 'i'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
f-string-without-interpolation: Using an f-string that does not have any interpolated variables
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
f-string-without-interpolation: Using an f-string that does not have any interpolated variables
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
f-string-without-interpolation: Using an f-string that does not have any interpolated variables
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
f-string-without-interpolation: Using an f-string that does not have any interpolated variables
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
f-string-without-interpolation: Using an f-string that does not have any interpolated variables
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-import: Unused import os
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-variable: Unused variable 'feature_name'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-import: Unused import os
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-import: Unused import sys
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
broad-exception-caught: Catching too general exception Exception
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
f-string-without-interpolation: Using an f-string that does not have any interpolated variables
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
f-string-without-interpolation: Using an f-string that does not have any interpolated variables
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unused-variable: Unused variable 'feature_name'
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
bare-except: No exception type(s) specified
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
subprocess-run-check: 'subprocess.run' used without explicitly defining the value for 'check'.
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
subprocess-run-check: 'subprocess.run' used without explicitly defining the value for 'check'.
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
f-string-without-interpolation: Using an f-string that does not have any interpolated variables
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
unspecified-encoding: Using open without explicitly specifying an encoding
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
Estimated Effort: Medium (2-4 hours)
Priority: P2 | Severity: High
Estimated Effort: Medium (2-4 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (110/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-lines: Too many lines in module (2903/1000)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import errno" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import functools" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import os" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import re" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import shlex" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import socket" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import subprocess" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import time" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import traceback" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import logging" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "from ansible.module_utils.basic import AnsibleModule" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "from ansible.module_utils.network_lsr import ethtool" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "from ansible.module_utils.network_lsr.myerror import MyError" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "from ansible.module_utils.network_lsr.argument_validator import ArgUtil, ArgValidator_ListConnections, ValidationError" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "from ansible.module_utils.network_lsr.utils import Util" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "from ansible.module_utils.network_lsr import nm_provider" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-few-public-methods: Too few public methods (0/2)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-return: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Method name "KeyValid" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Method name "ValueEscape" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-in: Consider merging these comparisons with 'in' by using 'c in ('\\', "'")'. Use a set instead if elements are hashable.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-in: Consider merging these comparisons with 'in' by using 'c in ('"', '\\', '$', '`')'. Use a set instead if elements are hashable.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-locals: Too many local variables (38/15)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-enumerate: Consider using enumerate instead of iterating with range and len
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
redefined-argument-from-local: Redefining argument with the local name 'idx'
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (74/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-statements: Too many statements (178/50)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
redefined-argument-from-local: Redefining argument with the local name 'file_type'
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
redefined-argument-from-local: Redefining argument with the local name 'file_type'
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
redefined-argument-from-local: Redefining argument with the local name 'file_type'
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
redefined-argument-from-local: Redefining argument with the local name 'file_type'
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-return: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-return-statements: Too many return statements (7/6)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Variable name "NM" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Variable name "GObject" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-arguments: Too many arguments (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-positional-arguments: Too many positional arguments (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-return-statements: Too many return statements (7/6)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-arguments: Too many arguments (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-positional-arguments: Too many positional arguments (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Variable name "NM" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Variable name "NM" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-locals: Too many local variables (50/15)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Variable name "NM" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (107/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-statements: Too many statements (264/50)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Variable name "NM" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
chained-comparison: Simplify chained comparison between the operands
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
useless-object-inheritance: Class 'RunEnvironment' inherits from object, can be safely removed from bases in python3
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-arguments: Too many arguments (9/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-positional-arguments: Too many positional arguments (9/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-arguments: Too many arguments (9/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-positional-arguments: Too many positional arguments (9/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
redefined-argument-from-local: Redefining argument with the local name 'idx'
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
super-with-arguments: Consider using Python 3 style super() without arguments
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
useless-object-inheritance: Class 'Cmd' inherits from object, can be safely removed from bases in python3
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-instance-attributes: Too many instance attributes (12/7)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-arguments: Too many arguments (8/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-positional-arguments: Too many positional arguments (8/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-arguments: Too many arguments (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-positional-arguments: Too many positional arguments (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-return: Unnecessary "elif" after "return", remove the leading "el" from "elif"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-nested-blocks: Too many nested blocks (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (14/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-nested-blocks: Too many nested blocks (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-public-methods: Too many public methods (28/20)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "Cmd_nm" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
import-outside-toplevel: Import outside toplevel (ansible.module_utils.network_lsr.nm.provider)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Variable name "NM" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-dict-comprehension: Consider using a dictionary comprehension
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Variable name "NM" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "Cmd_initscripts" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (13/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (13/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import traceback" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "from ansible.module_utils.basic import AnsibleModule, missing_required_lib" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"changed": False}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"desired_state": dict(type='dict', required=True)}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'dict', "required": True}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
useless-option-value: Useless option value for 'disable', 'no-self-use' was moved to an optional extension, see https://pylint.readthedocs.io/en/latest/whatsnew/2/2.14/summary.html#removed-checkers.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (129/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (106/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (104/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-lines: Too many lines in module (2791/1000)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
super-with-arguments: Consider using Python 3 style super() without arguments
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-few-public-methods: Too few public methods (1/2)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-positional-arguments: Too many positional arguments (9/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-raise: Unnecessary "elif" after "raise", remove the leading "el" from "elif"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-raise: Unnecessary "elif" after "raise", remove the leading "el" from "elif"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-return: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-return: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-raise: Unnecessary "elif" after "raise", remove the leading "el" from "elif"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-positional-arguments: Too many positional arguments (7/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-positional-arguments: Too many positional arguments (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (13/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-merging-isinstance: Consider merging these isinstance calls to isinstance(value, (Util.STRING_TYPE, int))
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-arguments: Too many arguments (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-positional-arguments: Too many positional arguments (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-dict-comprehension: Consider using a dictionary comprehension
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
redefined-argument-from-local: Redefining argument with the local name 'value'
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-arguments: Too many arguments (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-positional-arguments: Too many positional arguments (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-arguments: Too many arguments (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-positional-arguments: Too many positional arguments (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (22/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "ArgValidator_DictIP" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "ArgValidator_DictEthernet" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-dict-comprehension: Consider using a dictionary comprehension
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "ArgValidator_DictEthtool" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "ArgValidator_DictEthtoolFeatures" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "ArgValidator_DictEthtoolCoalesce" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "ArgValidator_DictEthtoolRing" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "ArgValidator_DictBond" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Variable name "AD_OPTIONS" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Variable name "ARP_OPTIONS" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Variable name "ARP_ONLY_MODE" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (17/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "ArgValidator_DictInfiniband" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "ArgValidator_DictVlan" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "ArgValidator_DictMacvlan" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "ArgValidator_Dict802_1X" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "ArgValidator_DictWireless" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-in: Consider merging these comparisons with 'in' by using 'result in (['|'], ['&'])'. Use a set instead if elements are hashable.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "ArgValidator_DictMatch" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "ArgValidator_DictConnection" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Attribute name "VALID_FIELDS" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
redefined-argument-from-local: Redefining argument with the local name 'name'
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (65/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-statements: Too many statements (120/50)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "ArgValidator_ListConnections" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-raise: Unnecessary "elif" after "raise", remove the leading "el" from "elif"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-raise: Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (50/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-statements: Too many statements (78/50)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
useless-object-inheritance: Class 'IPRouteUtils' inherits from object, can be safely removed from bases in python3
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-few-public-methods: Too few public methods (1/2)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-return: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
useless-object-inheritance: Class '_NmMainLoop' inherits from object, can be safely removed from bases in python3
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Method name "NM" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
import-outside-toplevel: Import outside toplevel (gi)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
import-outside-toplevel: Import outside toplevel (gi.repository.NM, gi.repository.GLib, gi.repository.Gio, gi.repository.GObject)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Method name "GLib" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Method name "Gio" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Method name "GObject" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Method name "Timestamp" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Method name "GMainLoop" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Method name "GMainLoop_run" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Variable name "GLib" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Method name "GMainLoop_iterate" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Method name "GMainLoop_iterate_all" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Variable name "GLib" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-in: Consider merging these comparisons with 'in' by using 'family not in (socket.AF_INET, socket.AF_INET6)'. Use a set instead if elements are hashable.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-return: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
inconsistent-return-statements: Either all return statements in a function should return an expression, or none of them should.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
inconsistent-return-statements: Either all return statements in a function should return an expression, or none of them should.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
chained-comparison: Simplify chained comparison between the operands
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-public-methods: Too many public methods (30/20)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import yaml" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (25/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-statements: Too many statements (52/50)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
useless-option-value: Useless option value for 'disable', 'no-self-use' was moved to an optional extension, see https://pylint.readthedocs.io/en/latest/whatsnew/2/2.14/summary.html#removed-checkers.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
useless-option-value: Useless option value for 'disable', 'no-self-use' was moved to an optional extension, see https://pylint.readthedocs.io/en/latest/whatsnew/2/2.14/summary.html#removed-checkers.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (115/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (118/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (131/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (102/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (110/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (112/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (106/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (122/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (132/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (101/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (112/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (121/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (113/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (145/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (139/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (112/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (105/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (128/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (120/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (122/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (112/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (112/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (108/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (103/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (130/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (117/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (124/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (112/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (102/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (105/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (121/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (141/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (102/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (132/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (128/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (106/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (150/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (145/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (129/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (143/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (150/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (107/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (114/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (107/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (107/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (113/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (107/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (112/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (126/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (101/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (123/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (150/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (141/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (105/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (109/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (134/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (126/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (114/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (145/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (129/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (143/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (150/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (114/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (105/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (105/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (101/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (140/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (102/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (102/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (106/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (101/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (115/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (108/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (123/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (105/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (110/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (126/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (119/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (113/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (103/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (115/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (110/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (103/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (112/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (106/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (111/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (102/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (113/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (102/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (101/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (105/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (102/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (111/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (106/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (117/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (120/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (134/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (104/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (126/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (119/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (104/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (126/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (119/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (105/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (149/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (103/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (105/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (107/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (101/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (103/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-lines: Too many lines in module (2560/1000)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import copy" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import logging" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import os" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import traceback" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import inspect" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
useless-object-inheritance: Class 'FakeDevices' inherits from object, can be safely removed from bases in python3
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-few-public-methods: Too few public methods (1/2)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "from ansible.module_utils.basic import AnsibleModule" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "from ansible.module_utils.storage_lsr.argument_validator import validate_parameters" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Constant name "use_partitions" doesn't conform to UPPER_CASE naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Constant name "disklabel_type" doesn't conform to UPPER_CASE naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Constant name "safe_mode" doesn't conform to UPPER_CASE naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
useless-object-inheritance: Class 'BlivetBase' inherits from object, can be safely removed from bases in python3
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-raise: Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-few-public-methods: Too few public methods (0/2)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
super-with-arguments: Consider using Python 3 style super() without arguments
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (13/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (21/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-statements: Too many statements (51/50)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
super-with-arguments: Consider using Python 3 style super() without arguments
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
super-with-arguments: Consider using Python 3 style super() without arguments
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-raise: Unnecessary "elif" after "raise", remove the leading "el" from "elif"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
super-with-arguments: Consider using Python 3 style super() without arguments
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-raise: Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"vdo_lv": True, "parents": [vdopool]}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"seg_type": self._volume['raid_level'], "pvs": pvs, "stripe_size": stripe_size, ... }' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"seg_type": self._volume['raid_level'], "pvs": pvs}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"cache_request": cache_request}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-raise: Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"fmt": self._get_format(), "name": self._volume['name'], "parents": [parent_device], ... }' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"thin_volume": True}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (13/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
super-with-arguments: Consider using Python 3 style super() without arguments
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-raise: Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-return: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
super-with-arguments: Consider using Python 3 style super() without arguments
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-raise: Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
super-with-arguments: Consider using Python 3 style super() without arguments
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-raise: Unnecessary "elif" after "raise", remove the leading "el" from "elif"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-raise: Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-return: Unnecessary "elif" after "return", remove the leading "el" from "elif"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-raise: Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-raise: Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-return: Unnecessary "elif" after "return", remove the leading "el" from "elif"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-locals: Too many local variables (24/15)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"thin_pool": True, "size": tlv_size, "parents": [pool_device]}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"name": thinlv['name']}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (20/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-statements: Too many statements (63/50)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (16/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
super-with-arguments: Consider using Python 3 style super() without arguments
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-return: Unnecessary "elif" after "return", remove the leading "el" from "elif"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
useless-object-inheritance: Class 'FSTab' inherits from object, can be safely removed from bases in python3
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"device_id": fields[0], "device_path": getattr(device, 'path', None), ... }' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"path": mount['mount_point'], "state": 'absent'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (14/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"backing_device": action.device.path, "name": action.format.map_name, ... }' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-locals: Too many local variables (20/15)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"encryption": dict(type='bool'), "encryption_cipher": dict(type='str'), ... }' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'bool'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str', "no_log": False}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'int'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str', "no_log": True}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str', "default": 'present', "choices": ['present', 'absent'], ... }' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"disks": dict(type='list', elements='str', default=list()), "raid_device_count": dict(type='int'), ... }' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'list', "elements": 'str', "default": list()}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'int'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'int'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"cached": dict(type='bool'), "cache_devices": dict(type='list', elements='str', default=list()), ... }' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'bool'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'list', "elements": 'str', "default": list()}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'bool'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'bool'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'list', "elements": 'str', "default": list()}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'bool', "default": False}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"pools": dict(type='list', elements='dict', options=dict(disks=dict(type='list', elements='str', default=list()), encryption=dict(type='bool'), encryption_cipher=dict(type='str'), encryption_key=dict(type='str', no_log=False), encryption_key_size=dict(type='int'), encryption_luks_version=dict(type='str'), encryption_password=dict(type='str', no_log=True), encryption_clevis_pin=dict(type='str'), encryption_tang_url=dict(type='str'), encryption_tang_thumbprint=dict(type='str'), grow_to_fill=dict(type='bool'), name=dict(type='str'), raid_level=dict(type='str'), raid_device_count=dict(type='int'), raid_spare_count=dict(type='int'), raid_metadata_version=dict(type='str'), raid_chunk_size=dict(type='str'), shared=dict(type='bool'), state=dict(type='str', default='present', choices=['present', 'absent']), type=dict(type='str'), volumes=dict(type='list', elements='dict', default=list(), options=pool_volume_opts))), ... }' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'list', "elements": 'dict', "options": dict(disks=dict(type='list', elements='str', default=list()), encryption=dict(type='bool'), encryption_cipher=dict(type='str'), encryption_key=dict(type='str', no_log=False), encryption_key_size=dict(type='int'), encryption_luks_version=dict(type='str'), encryption_password=dict(type='str', no_log=True), encryption_clevis_pin=dict(type='str'), encryption_tang_url=dict(type='str'), encryption_tang_thumbprint=dict(type='str'), grow_to_fill=dict(type='bool'), name=dict(type='str'), raid_level=dict(type='str'), raid_device_count=dict(type='int'), raid_spare_count=dict(type='int'), raid_metadata_version=dict(type='str'), raid_chunk_size=dict(type='str'), shared=dict(type='bool'), state=dict(type='str', default='present', choices=['present', 'absent']), type=dict(type='str'), volumes=dict(type='list', elements='dict', default=list(), options=pool_volume_opts)), ... }' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"disks": dict(type='list', elements='str', default=list()), "encryption": dict(type='bool'), ... }' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'list', "elements": 'str', "default": list()}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'bool'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str', "no_log": False}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'int'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str', "no_log": True}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'bool'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'int'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'int'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'bool'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str', "default": 'present', "choices": ['present', 'absent'], ... }' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'list', "elements": 'dict', "default": list(), "options": pool_volume_opts, ... }' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'list', "elements": 'dict', "options": volume_opts}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'bool', "required": False, "default": False}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str', "required": False, "default": None}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'bool', "required": False, "default": True}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'dict', "required": False}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'dict', "required": False}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'bool', "required": False}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'dict', "required": False, "default": {}}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'bool', "required": False, "default": False}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"changed": False, "actions": list(), "leaves": list(), "mounts": list(), ... }' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"action": action.type_desc_str, "fs_type": action.format.type if action.is_format else None, ... }' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (19/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-statements: Too many statements (89/50)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (113/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import os" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import shlex" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "from ansible.module_utils.basic import AnsibleModule" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-return: Unnecessary "elif" after "return", remove the leading "el" from "elif"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"info": None}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "from ansible.module_utils.basic import AnsibleModule" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "from ansible.module_utils.storage_lsr.size import Size" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"size": dict(type='str', required=True)}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str', "required": True}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"changed": False}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (132/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (109/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (153/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import os" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import re" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "from ansible.module_utils.basic import AnsibleModule" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "from ansible.module_utils.storage_lsr.size import Size" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"max_return": dict(type='int', required=False, default=10), "min_size": dict(type='str', required=False, default='0'), ... }' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'int', "required": False, "default": 10}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str', "required": False, "default": '0'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str', "required": False, "default": '0'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str', "required": False, "default": None}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'bool', "required": False, "default": False}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"changed": False, "disks": [], "info": []}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-dict-items: Consider iterating with .items()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-iterating-dictionary: Consider iterating the dictionary directly instead of calling .keys()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-iterating-dictionary: Consider iterating the dictionary directly instead of calling .keys()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-iterating-dictionary: Consider iterating the dictionary directly instead of calling .keys()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (104/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (112/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "from ansible.module_utils.basic import AnsibleModule" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "from ansible.module_utils import facts" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"mount": dict(type='str', required=True), "fs_type": dict(type='str', required=True), ... }' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str', "required": True}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str', "required": True}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"changed": False, "vg_name": '', "lv_name": ''}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (103/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import glob" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import os" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import re" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "from ansible.module_utils.basic import AnsibleModule" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-break: Unnecessary "else" after "break", remove the "else" and de-indent the code inside it
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"spec": dict(type='str', required=True)}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str', "required": True}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"device": None}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (146/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (101/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (109/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
useless-object-inheritance: Class 'ArgValidator' inherits from object, can be safely removed from bases in python3
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-merging-isinstance: Consider merging these isinstance calls to isinstance(value, (float, int))
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"list": ArgValidator._validate_list, "str": ArgValidator._validate_str, ... }' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (21/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-enumerate: Consider using enumerate instead of iterating with range and len
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-implicit-booleaness-not-comparison: "x == []" can be simplified to "not x", if it is strictly a sequence, as an empty list is falsey
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-enumerate: Consider using enumerate instead of iterating with range and len
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-locals: Too many local variables (18/15)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-break: Unnecessary "else" after "break", remove the "else" and de-indent the code inside it
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-nested-blocks: Too many nested blocks (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (14/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
useless-object-inheritance: Class 'Size' inherits from object, can be safely removed from bases in python3
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "VERSION_TUPLE" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "VERSION_TUPLE" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Constant name "version" doesn't conform to UPPER_CASE naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-nested-blocks: Too many nested blocks (7/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (113/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (103/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (110/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (124/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (101/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (116/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (116/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-locals: Too many local variables (24/15)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-nested-blocks: Too many nested blocks (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-nested-blocks: Too many nested blocks (7/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-locals: Too many local variables (23/15)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-nested-blocks: Too many nested blocks (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-nested-blocks: Too many nested blocks (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-order: standard import "glob" should be placed before third party import "yaml"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-order: standard import "pathlib.Path" should be placed before third party import "yaml"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-order: standard import "typing.List" should be placed before third party import "yaml"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (125/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (112/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
import-outside-toplevel: Import outside toplevel (yaml)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (123/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (121/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (102/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-return: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-order: standard import "pathlib.Path" should be placed before third party import "yaml"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-order: standard import "typing.List" should be placed before third party import "yaml"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (112/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (121/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (108/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (138/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (110/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (108/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-locals: Too many local variables (17/15)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-locals: Too many local variables (24/15)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-order: standard import "json" should be placed before third party import "yaml"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-order: standard import "os" should be placed before third party import "yaml"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-order: standard import "subprocess" should be placed before third party import "yaml"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-order: standard import "sys" should be placed before third party import "yaml"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-order: standard import "pathlib.Path" should be placed before third party import "yaml"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (104/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (106/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (103/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (112/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (120/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (122/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (120/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (116/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (116/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (106/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (111/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (112/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (115/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (119/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (120/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (113/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (113/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (117/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (114/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (138/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-return-statements: Too many return statements (7/6)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-locals: Too many local variables (16/15)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-nested-blocks: Too many nested blocks (9/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (23/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (19/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-statements: Too many statements (52/50)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-nested-blocks: Too many nested blocks (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-locals: Too many local variables (28/15)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (14/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-statements: Too many statements (74/50)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-order: standard import "json" should be placed before third party import "yaml"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-order: standard import "os" should be placed before third party import "yaml"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-order: standard import "subprocess" should be placed before third party import "yaml"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-order: standard import "sys" should be placed before third party import "yaml"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-order: standard import "pathlib.Path" should be placed before third party import "yaml"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-order: standard import "datetime.datetime" should be placed before third party import "yaml"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (108/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (102/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (134/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (126/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (115/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (148/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (120/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-return: Unnecessary "elif" after "return", remove the leading "el" from "elif"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (110/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-lines: Too many lines in module (2903/1000)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import errno" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import functools" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import os" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import re" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import shlex" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import socket" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import subprocess" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import time" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import traceback" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import logging" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "from ansible.module_utils.basic import AnsibleModule" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "from ansible.module_utils.network_lsr import ethtool" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "from ansible.module_utils.network_lsr.myerror import MyError" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "from ansible.module_utils.network_lsr.argument_validator import ArgUtil, ArgValidator_ListConnections, ValidationError" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "from ansible.module_utils.network_lsr.utils import Util" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "from ansible.module_utils.network_lsr import nm_provider" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-few-public-methods: Too few public methods (0/2)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-return: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Method name "KeyValid" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Method name "ValueEscape" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-in: Consider merging these comparisons with 'in' by using 'c in ('\\', "'")'. Use a set instead if elements are hashable.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-in: Consider merging these comparisons with 'in' by using 'c in ('"', '\\', '$', '`')'. Use a set instead if elements are hashable.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-locals: Too many local variables (38/15)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-enumerate: Consider using enumerate instead of iterating with range and len
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
redefined-argument-from-local: Redefining argument with the local name 'idx'
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (74/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-statements: Too many statements (178/50)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
redefined-argument-from-local: Redefining argument with the local name 'file_type'
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
redefined-argument-from-local: Redefining argument with the local name 'file_type'
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
redefined-argument-from-local: Redefining argument with the local name 'file_type'
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
redefined-argument-from-local: Redefining argument with the local name 'file_type'
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-return: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-return-statements: Too many return statements (7/6)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Variable name "NM" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Variable name "GObject" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-arguments: Too many arguments (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-positional-arguments: Too many positional arguments (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-return-statements: Too many return statements (7/6)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-arguments: Too many arguments (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-positional-arguments: Too many positional arguments (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Variable name "NM" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Variable name "NM" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-locals: Too many local variables (50/15)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Variable name "NM" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (107/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-statements: Too many statements (264/50)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Variable name "NM" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
chained-comparison: Simplify chained comparison between the operands
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
useless-object-inheritance: Class 'RunEnvironment' inherits from object, can be safely removed from bases in python3
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-arguments: Too many arguments (9/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-positional-arguments: Too many positional arguments (9/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-arguments: Too many arguments (9/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-positional-arguments: Too many positional arguments (9/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
redefined-argument-from-local: Redefining argument with the local name 'idx'
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
super-with-arguments: Consider using Python 3 style super() without arguments
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
useless-object-inheritance: Class 'Cmd' inherits from object, can be safely removed from bases in python3
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-instance-attributes: Too many instance attributes (12/7)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-arguments: Too many arguments (8/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-positional-arguments: Too many positional arguments (8/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-arguments: Too many arguments (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-positional-arguments: Too many positional arguments (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-return: Unnecessary "elif" after "return", remove the leading "el" from "elif"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-nested-blocks: Too many nested blocks (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (14/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-nested-blocks: Too many nested blocks (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-public-methods: Too many public methods (28/20)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "Cmd_nm" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
import-outside-toplevel: Import outside toplevel (ansible.module_utils.network_lsr.nm.provider)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Variable name "NM" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-dict-comprehension: Consider using a dictionary comprehension
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Variable name "NM" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "Cmd_initscripts" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (13/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (13/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import traceback" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "from ansible.module_utils.basic import AnsibleModule, missing_required_lib" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"changed": False}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"desired_state": dict(type='dict', required=True)}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'dict', "required": True}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
useless-option-value: Useless option value for 'disable', 'no-self-use' was moved to an optional extension, see https://pylint.readthedocs.io/en/latest/whatsnew/2/2.14/summary.html#removed-checkers.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (129/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (106/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (104/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-lines: Too many lines in module (2791/1000)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
super-with-arguments: Consider using Python 3 style super() without arguments
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-few-public-methods: Too few public methods (1/2)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-positional-arguments: Too many positional arguments (9/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-raise: Unnecessary "elif" after "raise", remove the leading "el" from "elif"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-raise: Unnecessary "elif" after "raise", remove the leading "el" from "elif"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-return: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-return: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-raise: Unnecessary "elif" after "raise", remove the leading "el" from "elif"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-positional-arguments: Too many positional arguments (7/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-positional-arguments: Too many positional arguments (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (13/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-merging-isinstance: Consider merging these isinstance calls to isinstance(value, (Util.STRING_TYPE, int))
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-arguments: Too many arguments (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-positional-arguments: Too many positional arguments (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-dict-comprehension: Consider using a dictionary comprehension
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
redefined-argument-from-local: Redefining argument with the local name 'value'
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-arguments: Too many arguments (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-positional-arguments: Too many positional arguments (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-arguments: Too many arguments (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-positional-arguments: Too many positional arguments (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (22/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "ArgValidator_DictIP" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "ArgValidator_DictEthernet" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-dict-comprehension: Consider using a dictionary comprehension
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "ArgValidator_DictEthtool" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "ArgValidator_DictEthtoolFeatures" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "ArgValidator_DictEthtoolCoalesce" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "ArgValidator_DictEthtoolRing" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "ArgValidator_DictBond" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Variable name "AD_OPTIONS" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Variable name "ARP_OPTIONS" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Variable name "ARP_ONLY_MODE" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (17/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "ArgValidator_DictInfiniband" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "ArgValidator_DictVlan" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "ArgValidator_DictMacvlan" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "ArgValidator_Dict802_1X" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "ArgValidator_DictWireless" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-in: Consider merging these comparisons with 'in' by using 'result in (['|'], ['&'])'. Use a set instead if elements are hashable.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "ArgValidator_DictMatch" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "ArgValidator_DictConnection" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Attribute name "VALID_FIELDS" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
redefined-argument-from-local: Redefining argument with the local name 'name'
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (65/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-statements: Too many statements (120/50)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "ArgValidator_ListConnections" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-raise: Unnecessary "elif" after "raise", remove the leading "el" from "elif"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-raise: Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (50/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-statements: Too many statements (78/50)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
useless-object-inheritance: Class 'IPRouteUtils' inherits from object, can be safely removed from bases in python3
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-few-public-methods: Too few public methods (1/2)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-return: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
useless-object-inheritance: Class '_NmMainLoop' inherits from object, can be safely removed from bases in python3
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Method name "NM" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
import-outside-toplevel: Import outside toplevel (gi)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
import-outside-toplevel: Import outside toplevel (gi.repository.NM, gi.repository.GLib, gi.repository.Gio, gi.repository.GObject)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Method name "GLib" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Method name "Gio" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Method name "GObject" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Method name "Timestamp" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Method name "GMainLoop" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Method name "GMainLoop_run" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Variable name "GLib" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Method name "GMainLoop_iterate" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Method name "GMainLoop_iterate_all" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Variable name "GLib" doesn't conform to snake_case naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-in: Consider merging these comparisons with 'in' by using 'family not in (socket.AF_INET, socket.AF_INET6)'. Use a set instead if elements are hashable.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-return: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
inconsistent-return-statements: Either all return statements in a function should return an expression, or none of them should.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
inconsistent-return-statements: Either all return statements in a function should return an expression, or none of them should.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
chained-comparison: Simplify chained comparison between the operands
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-public-methods: Too many public methods (30/20)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import yaml" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (25/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-statements: Too many statements (52/50)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
useless-option-value: Useless option value for 'disable', 'no-self-use' was moved to an optional extension, see https://pylint.readthedocs.io/en/latest/whatsnew/2/2.14/summary.html#removed-checkers.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
useless-option-value: Useless option value for 'disable', 'no-self-use' was moved to an optional extension, see https://pylint.readthedocs.io/en/latest/whatsnew/2/2.14/summary.html#removed-checkers.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (115/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (118/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (131/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (102/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (110/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (112/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (106/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (122/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (132/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (101/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (112/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (121/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (113/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (145/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (139/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (112/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (105/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (128/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (120/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (122/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (112/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (112/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (108/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (103/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (130/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (117/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (124/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (112/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (102/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (105/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (121/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (141/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (102/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (132/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (128/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (106/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (150/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (145/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (129/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (143/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (150/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (107/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (114/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (107/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (107/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (113/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (107/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (112/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (126/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (101/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (123/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (150/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (141/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (105/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (109/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (134/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (126/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (114/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (145/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (129/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (143/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (150/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (114/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (105/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (105/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (101/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (140/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (102/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (102/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (106/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (101/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (115/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (108/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (123/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (105/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (110/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (126/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (119/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (113/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (103/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (115/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (110/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (103/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (112/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (106/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (111/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (102/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (113/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (102/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (101/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (105/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (102/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (111/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (106/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (117/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (120/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (134/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (104/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (126/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (119/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (104/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (126/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (119/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (105/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (149/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (103/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (105/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (107/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (101/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (103/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-lines: Too many lines in module (2560/1000)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import copy" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import logging" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import os" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import traceback" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import inspect" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
useless-object-inheritance: Class 'FakeDevices' inherits from object, can be safely removed from bases in python3
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-few-public-methods: Too few public methods (1/2)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "from ansible.module_utils.basic import AnsibleModule" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "from ansible.module_utils.storage_lsr.argument_validator import validate_parameters" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Constant name "use_partitions" doesn't conform to UPPER_CASE naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Constant name "disklabel_type" doesn't conform to UPPER_CASE naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Constant name "safe_mode" doesn't conform to UPPER_CASE naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
useless-object-inheritance: Class 'BlivetBase' inherits from object, can be safely removed from bases in python3
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-raise: Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-few-public-methods: Too few public methods (0/2)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
super-with-arguments: Consider using Python 3 style super() without arguments
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (13/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (21/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-statements: Too many statements (51/50)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
super-with-arguments: Consider using Python 3 style super() without arguments
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
super-with-arguments: Consider using Python 3 style super() without arguments
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-raise: Unnecessary "elif" after "raise", remove the leading "el" from "elif"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
super-with-arguments: Consider using Python 3 style super() without arguments
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-raise: Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"vdo_lv": True, "parents": [vdopool]}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"seg_type": self._volume['raid_level'], "pvs": pvs, "stripe_size": stripe_size, ... }' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"seg_type": self._volume['raid_level'], "pvs": pvs}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"cache_request": cache_request}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-raise: Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"fmt": self._get_format(), "name": self._volume['name'], "parents": [parent_device], ... }' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"thin_volume": True}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (13/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
super-with-arguments: Consider using Python 3 style super() without arguments
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-raise: Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-return: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
super-with-arguments: Consider using Python 3 style super() without arguments
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-raise: Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
super-with-arguments: Consider using Python 3 style super() without arguments
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-raise: Unnecessary "elif" after "raise", remove the leading "el" from "elif"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-raise: Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-return: Unnecessary "elif" after "return", remove the leading "el" from "elif"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-raise: Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-raise: Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-return: Unnecessary "elif" after "return", remove the leading "el" from "elif"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-locals: Too many local variables (24/15)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"thin_pool": True, "size": tlv_size, "parents": [pool_device]}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"name": thinlv['name']}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (20/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-statements: Too many statements (63/50)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (16/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
super-with-arguments: Consider using Python 3 style super() without arguments
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-return: Unnecessary "elif" after "return", remove the leading "el" from "elif"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
useless-object-inheritance: Class 'FSTab' inherits from object, can be safely removed from bases in python3
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"device_id": fields[0], "device_path": getattr(device, 'path', None), ... }' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"path": mount['mount_point'], "state": 'absent'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (14/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"backing_device": action.device.path, "name": action.format.map_name, ... }' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-locals: Too many local variables (20/15)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"encryption": dict(type='bool'), "encryption_cipher": dict(type='str'), ... }' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'bool'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str', "no_log": False}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'int'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str', "no_log": True}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str', "default": 'present', "choices": ['present', 'absent'], ... }' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"disks": dict(type='list', elements='str', default=list()), "raid_device_count": dict(type='int'), ... }' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'list', "elements": 'str', "default": list()}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'int'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'int'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"cached": dict(type='bool'), "cache_devices": dict(type='list', elements='str', default=list()), ... }' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'bool'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'list', "elements": 'str', "default": list()}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'bool'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'bool'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'list', "elements": 'str', "default": list()}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'bool', "default": False}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"pools": dict(type='list', elements='dict', options=dict(disks=dict(type='list', elements='str', default=list()), encryption=dict(type='bool'), encryption_cipher=dict(type='str'), encryption_key=dict(type='str', no_log=False), encryption_key_size=dict(type='int'), encryption_luks_version=dict(type='str'), encryption_password=dict(type='str', no_log=True), encryption_clevis_pin=dict(type='str'), encryption_tang_url=dict(type='str'), encryption_tang_thumbprint=dict(type='str'), grow_to_fill=dict(type='bool'), name=dict(type='str'), raid_level=dict(type='str'), raid_device_count=dict(type='int'), raid_spare_count=dict(type='int'), raid_metadata_version=dict(type='str'), raid_chunk_size=dict(type='str'), shared=dict(type='bool'), state=dict(type='str', default='present', choices=['present', 'absent']), type=dict(type='str'), volumes=dict(type='list', elements='dict', default=list(), options=pool_volume_opts))), ... }' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'list', "elements": 'dict', "options": dict(disks=dict(type='list', elements='str', default=list()), encryption=dict(type='bool'), encryption_cipher=dict(type='str'), encryption_key=dict(type='str', no_log=False), encryption_key_size=dict(type='int'), encryption_luks_version=dict(type='str'), encryption_password=dict(type='str', no_log=True), encryption_clevis_pin=dict(type='str'), encryption_tang_url=dict(type='str'), encryption_tang_thumbprint=dict(type='str'), grow_to_fill=dict(type='bool'), name=dict(type='str'), raid_level=dict(type='str'), raid_device_count=dict(type='int'), raid_spare_count=dict(type='int'), raid_metadata_version=dict(type='str'), raid_chunk_size=dict(type='str'), shared=dict(type='bool'), state=dict(type='str', default='present', choices=['present', 'absent']), type=dict(type='str'), volumes=dict(type='list', elements='dict', default=list(), options=pool_volume_opts)), ... }' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"disks": dict(type='list', elements='str', default=list()), "encryption": dict(type='bool'), ... }' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'list', "elements": 'str', "default": list()}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'bool'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str', "no_log": False}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'int'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str', "no_log": True}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'bool'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'int'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'int'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'bool'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str', "default": 'present', "choices": ['present', 'absent'], ... }' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'list', "elements": 'dict', "default": list(), "options": pool_volume_opts, ... }' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'list', "elements": 'dict', "options": volume_opts}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'bool', "required": False, "default": False}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str', "required": False, "default": None}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'bool', "required": False, "default": True}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'dict', "required": False}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'dict', "required": False}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'bool', "required": False}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'dict', "required": False, "default": {}}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'bool', "required": False, "default": False}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"changed": False, "actions": list(), "leaves": list(), "mounts": list(), ... }' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"action": action.type_desc_str, "fs_type": action.format.type if action.is_format else None, ... }' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (19/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-statements: Too many statements (89/50)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (113/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import os" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import shlex" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "from ansible.module_utils.basic import AnsibleModule" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-return: Unnecessary "elif" after "return", remove the leading "el" from "elif"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"info": None}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "from ansible.module_utils.basic import AnsibleModule" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "from ansible.module_utils.storage_lsr.size import Size" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"size": dict(type='str', required=True)}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str', "required": True}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"changed": False}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (132/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (109/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (153/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import os" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import re" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "from ansible.module_utils.basic import AnsibleModule" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "from ansible.module_utils.storage_lsr.size import Size" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"max_return": dict(type='int', required=False, default=10), "min_size": dict(type='str', required=False, default='0'), ... }' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'int', "required": False, "default": 10}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str', "required": False, "default": '0'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str', "required": False, "default": '0'}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str', "required": False, "default": None}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'bool', "required": False, "default": False}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"changed": False, "disks": [], "info": []}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-dict-items: Consider iterating with .items()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-iterating-dictionary: Consider iterating the dictionary directly instead of calling .keys()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-iterating-dictionary: Consider iterating the dictionary directly instead of calling .keys()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-iterating-dictionary: Consider iterating the dictionary directly instead of calling .keys()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (104/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (112/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "from ansible.module_utils.basic import AnsibleModule" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "from ansible.module_utils import facts" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"mount": dict(type='str', required=True), "fs_type": dict(type='str', required=True), ... }' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str', "required": True}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str', "required": True}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"changed": False, "vg_name": '', "lv_name": ''}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (103/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import glob" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import os" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "import re" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-position: Import "from ansible.module_utils.basic import AnsibleModule" should be placed at the top of the module
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-break: Unnecessary "else" after "break", remove the "else" and de-indent the code inside it
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"spec": dict(type='str', required=True)}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"type": 'str', "required": True}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"device": None}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (146/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (101/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (109/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
useless-object-inheritance: Class 'ArgValidator' inherits from object, can be safely removed from bases in python3
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-merging-isinstance: Consider merging these isinstance calls to isinstance(value, (float, int))
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{"list": ArgValidator._validate_list, "str": ArgValidator._validate_str, ... }' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-dict-literal: Consider using '{}' instead of a call to 'dict'.
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (21/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-enumerate: Consider using enumerate instead of iterating with range and len
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-implicit-booleaness-not-comparison: "x == []" can be simplified to "not x", if it is strictly a sequence, as an empty list is falsey
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-enumerate: Consider using enumerate instead of iterating with range and len
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-locals: Too many local variables (18/15)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-break: Unnecessary "else" after "break", remove the "else" and de-indent the code inside it
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-nested-blocks: Too many nested blocks (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
use-list-literal: Consider using [] instead of list()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (14/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "__metaclass__" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
useless-object-inheritance: Class 'Size' inherits from object, can be safely removed from bases in python3
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
consider-using-f-string: Formatting a regular string which could be an f-string
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-module-docstring: Missing module docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "VERSION_TUPLE" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Class name "VERSION_TUPLE" doesn't conform to PascalCase naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
invalid-name: Constant name "version" doesn't conform to UPPER_CASE naming style
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-nested-blocks: Too many nested blocks (7/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (113/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (103/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (110/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (124/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (101/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (116/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (116/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-locals: Too many local variables (24/15)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-nested-blocks: Too many nested blocks (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-nested-blocks: Too many nested blocks (7/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-locals: Too many local variables (23/15)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-nested-blocks: Too many nested blocks (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-nested-blocks: Too many nested blocks (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-order: standard import "glob" should be placed before third party import "yaml"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-order: standard import "pathlib.Path" should be placed before third party import "yaml"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-order: standard import "typing.List" should be placed before third party import "yaml"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (125/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (112/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
import-outside-toplevel: Import outside toplevel (yaml)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (123/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (121/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (102/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-function-docstring: Missing function or method docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-return: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-order: standard import "pathlib.Path" should be placed before third party import "yaml"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-order: standard import "typing.List" should be placed before third party import "yaml"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (112/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (121/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (108/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (138/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (110/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (108/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-locals: Too many local variables (17/15)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-locals: Too many local variables (24/15)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-order: standard import "json" should be placed before third party import "yaml"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-order: standard import "os" should be placed before third party import "yaml"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-order: standard import "subprocess" should be placed before third party import "yaml"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-order: standard import "sys" should be placed before third party import "yaml"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-order: standard import "pathlib.Path" should be placed before third party import "yaml"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (104/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (106/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (103/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (112/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (120/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (122/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (120/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (116/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (116/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (106/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (111/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (112/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (115/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (119/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (120/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (113/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (113/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (117/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (114/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (138/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-return-statements: Too many return statements (7/6)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-locals: Too many local variables (16/15)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-nested-blocks: Too many nested blocks (9/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (23/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (19/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-statements: Too many statements (52/50)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-nested-blocks: Too many nested blocks (6/5)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-locals: Too many local variables (28/15)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-branches: Too many branches (14/12)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
too-many-statements: Too many statements (74/50)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-order: standard import "json" should be placed before third party import "yaml"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-order: standard import "os" should be placed before third party import "yaml"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-order: standard import "subprocess" should be placed before third party import "yaml"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-order: standard import "sys" should be placed before third party import "yaml"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-order: standard import "pathlib.Path" should be placed before third party import "yaml"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
wrong-import-order: standard import "datetime.datetime" should be placed before third party import "yaml"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (108/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (102/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (134/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (126/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (115/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (148/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
line-too-long: Line too long (120/100)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
trailing-whitespace: Trailing whitespace
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
missing-class-docstring: Missing class docstring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
no-else-return: Unnecessary "elif" after "return", remove the leading "el" from "elif"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==module_utils.network_lsr.argument_validator:[5:2791] ==module_utils.network_lsr.argument_validator:[5:2791] __metaclass__ = type import os import posixpath import socket import re # pylint: disable=import-error, no-name-in-module from ansible.module_utils.network_lsr.myerror import MyError # noqa:E501 from ansible.module_utils.network_lsr.utils import Util # noqa:E501 UINT32_MAX = 0xFFFFFFFF class ArgUtil: @staticmethod def connection_find_by_name(name, connections, n_connections=None): if not name: raise ValueError("missing name argument") conn = None for idx, connection in enumerate(connections): if n_connections is not None and idx >= n_connections: break if "name" not in connection or name != connection["name"]: continue if connection["persistent_state"] == "absent": conn = None elif connection["persistent_state"] == "present": conn = connection return conn @staticmethod def connection_find_controller(name, connections, n_connections=None): connection = ArgUtil.connection_find_by_name(name, connections, n_connections) if not connection: raise MyError("invalid controller/parent '%s'" % (name)) if connection["interface_name"] is None: raise MyError( "invalid controller/parent '%s' which needs an 'interface_name'" % (name) ) if not Util.ifname_valid(connection["interface_name"]): raise MyError( "invalid controller/parent '%s' with invalid 'interface_name' ('%s')" % (name, connection["interface_name"]) ) return connection["interface_name"] @staticmethod def connection_find_controller_uuid(name, connections, n_connections=None): connection = ArgUtil.connection_find_by_name(name, connections, n_connections) if not connection: raise MyError("invalid controller/parent '%s'" % (name)) return connection["nm.uuid"] @staticmethod def connection_get_non_absent_names(connections): # @idx is the index with state['absent']. This will # return the names of all explicitly mentioned profiles. # That is, the names of profiles that should not be deleted. result = set() for connection in connections: if "name" not in connection: continue if not connection["name"]: continue result.add(connection["name"]) return result class ValidationError(MyError): def __init__(self, name, message): # pylint: disable=non-parent-init-called super(ValidationError, self).__init__(name + ": " + message) self.error_message = message self.name = name @staticmethod def from_connection(idx, message): return ValidationError("connection[" + str(idx) + "]", message) class ArgValidator: MISSING = object() DEFAULT = object() def __init__(self, name=None, required=False, default_value=None): self.name = name self.required = required self._default_value = default_value def get_default_value(self): if callable(self._default_value): return self._default_value() return self._default_value def validate(self, value): """ Validate and normalize the input dictionary This validate @value or raises a ValidationError() on error. It also returns a normalized value, where the settings are converted to appropriate types and default values set. You should rely on the normalization to fill unspecified values and resolve ambiguity. You are implementing "types" of ArgValidator instances and a major point of them is to implement a suitable validation and normalization. The means for that is for subclasses to override _validate_impl() and possibly _validate_post(). Some subclasses support convenience arguments for simpler validation, like ArgValidatorStr.enum_values or ArgValidatorNum.val_min. Or ArgValidator.required which is honored by ArgValidatorDict to determine whether a mandatory key is missing. Also, ArgValidatorDict and ArgValidatorList have a nested parameter which is an ArgValidator for the elements of the dictionary and list. """ return self._validate(value, self.name) def _validate(self, value, name): """ The internal implementation for validate(). This is mostly called from internal code and by validate(). Usually you would not call this directly nor override it. Instead, you would implement either _validate_impl() or _validate_post(). """ validated = self._validate_impl(value, name) return self._validate_post(value, name, validated) def _validate_impl(self, value, name): """ Implementation of validation. Subclasses must implement this validation function. It is the main hook to implement validate(). On validation error it must raise ValidationError() or otherwise return a pre-normalized value that gets passed to _validate_post(). """ raise NotImplementedError() # pylint: disable=unused-argument,no-self-use def _validate_post(self, value, name, result): """ Post validation of the validated result. This will be called with the result from _validate_impl(). By default it does nothing, but subclasses can override this to perform additional validation. The use for this hook is to split the validation in two steps. When validating a dictionary of multiple keys, then _validate_impl() can implement the basic pre-validation and pre-normalization of the individual keys (which can be in any order). Afterwards, _validate_post() can take a more holistic view and validate interdependencies between keys and perform additional validation. For example, _validate_impl() would validate that the keys are of the correct basic type, and _validate_post() would validate that the values don't conflict and possibly normalize derived default values. """ return result class ArgValidatorStr(ArgValidator): def __init__( # pylint: disable=too-many-arguments self, name, required=False, default_value=None, enum_values=None, allow_empty=False, min_length=None, max_length=None, regex=None, ): ArgValidator.__init__(self, name, required, default_value) self.enum_values = enum_values self.allow_empty = allow_empty self.regex = regex if max_length is not None: if not isinstance(max_length, int): raise ValueError("max_length must be an integer") elif max_length < 0: raise ValueError("max_length must be a positive integer") self.max_length = max_length if min_length is not None: if not isinstance(min_length, int): raise ValueError("min_length must be an integer") elif min_length < 0: raise ValueError("min_length must be a positive integer") self.min_length = min_length def _validate_impl(self, value, name): if not isinstance(value, Util.STRING_TYPE): raise ValidationError(name, "must be a string but is '%s'" % (value)) value = str(value) if self.enum_values is not None and value not in self.enum_values: raise ValidationError( name, "is '%s' but must be one of '%s'" % (value, "' '".join(sorted(self.enum_values))), ) if self.regex is not None and not any(re.match(x, value) for x in self.regex): raise ValidationError( name, "is '%s' which does not match the regex '%s'" % (value, "' '".join(sorted(self.regex))), ) if not self.allow_empty and not value: raise ValidationError(name, "cannot be empty") if not self._validate_string_max_length(value): raise ValidationError( name, "maximum length is %s characters" % (self.max_length) ) if not self._validate_string_min_length(value): raise ValidationError( name, "minimum length is %s characters" % (self.min_length) ) return value def _validate_string_max_length(self, value): """ Ensures that the length of string `value` is less than or equal to the maximum length """ if self.max_length is not None: return len(str(value)) <= self.max_length else: return True def _validate_string_min_length(self, value): """ Ensures that the length of string `value` is more than or equal to the minimum length """ if self.min_length is not None: return len(str(value)) >= self.min_length else: return True class ArgValidatorRouteTable(ArgValidator): def __init__( self, name, required=False, default_value=None, ): ArgValidator.__init__(self, name, required, default_value) def _validate_impl(self, value, name): table = None try: if isinstance(value, bool): # bool can (probably) be converted to integer type, # but here we don't want to accept a boolean value. pass elif isinstance(value, int): table = int(value) elif isinstance(value, Util.STRING_TYPE): try: table = int(value) except Exception: table = value except Exception: pass if table is None: raise ValidationError( name, "route table must be the named or numeric tables but is {0}".format( value ), ) if isinstance(table, int): if table < 1: raise ValidationError( name, "route table value is {0} but cannot be less than 1".format(value), ) elif table > UINT32_MAX: raise ValidationError( name, "route table value is {0} but cannot be greater than {1}".format( value, UINT32_MAX ), ) if isinstance(table, Util.STRING_TYPE): if table == "": raise ValidationError(name, "route table name cannot be empty string") if not IPRouteUtils.ROUTE_TABLE_NAME_REGEX.match(table): raise ValidationError( name, "route table name contains invalid characters" ) return table class ArgValidatorNum(ArgValidator): def __init__( # pylint: disable=too-many-arguments self, name, required=False, val_min=None, val_max=None, default_value=ArgValidator.DEFAULT, numeric_type=int, ): if default_value is ArgValidator.DEFAULT: default_value = numeric_type(0) ArgValidator.__init__(self, name, required, default_value) self.val_min = val_min self.val_max = val_max self.numeric_type = numeric_type def _validate_impl(self, value, name): v = None try: if isinstance(value, bool): # bool can (probably) be converted to self.numeric_type, # but here we don't want to accept a boolean value. pass elif isinstance(value, self.numeric_type): # ArgValidatorNum should normalize the input values to be of type # self.numeric_type, except the default_value v = self.numeric_type(value) else: v2 = self.numeric_type(value) if isinstance(value, Util.STRING_TYPE) or v2 == value: v = v2 except Exception: pass if v is None: raise ValidationError( name, "must be an integer number but is '%s'" % (value) ) if self.val_min is not None and v < self.val_min: raise ValidationError( name, "value is %s but cannot be less then %s" % (value, self.val_min) ) if self.val_max is not None and v > self.val_max: raise ValidationError( name, "value is %s but cannot be greater then %s" % (value, self.val_max), ) return v class ArgValidatorRange(ArgValidator): def __init__( # pylint: disable=too-many-arguments self, name, required=False, val_min=None, val_max=None, default_value=None, ): ArgValidator.__init__(self, name, required, default_value) self.val_min = val_min self.val_max = val_max def _validate_impl(self, value, name): range = None if isinstance(value, Util.STRING_TYPE): match_group = re.match(r"^ *([0-9]+) *- *([0-9]+) *$", value) if match_group: try: range = (int(match_group.group(1)), int(match_group.group(2))) except Exception: pass else: try: range = (int(value), int(value)) except Exception: pass elif isinstance(value, bool): # bool can (probably) be converted to integer type, # but here we don't want to accept a boolean value. pass elif isinstance(value, int): range = (value, value) if range is None: raise ValidationError(name, "the range value {0} is invalid".format(value)) if range[0] > range[1]: raise ValidationError( name, "the range start cannot be greater than range end", ) if self.val_min is not None: if range[0] < self.val_min: raise ValidationError( name, "lower range value is {0} but cannot be less than {1}".format( range[0], self.val_min ), ) if self.val_max is not None: if range[1] > self.val_max: raise ValidationError( name, "upper range value is {0} but cannot be greater than {1}".format( range[1], self.val_max ), ) return range class ArgValidatorBool(ArgValidator): def __init__(self, name, required=False, default_value=False): ArgValidator.__init__(self, name, required, default_value) def _validate_impl(self, value, name): try: if isinstance(value, bool): return value if isinstance(value, Util.STRING_TYPE) or isinstance(value, int): return Util.boolean(value) except Exception: pass raise ValidationError(name, "must be an boolean but is '%s'" % (value)) class ArgValidatorDeprecated(ArgValidator): """ ArgValidatorDeprecated is only used as a marker to indicate that a setting is deprecated by another setting. The validator that contains a deprecated setting is responsible for processing this and the replacement setting needs to perform the validation. """ def __init__(self, name, deprecated_by): ArgValidator.__init__(self, name, default_value=ArgValidator.MISSING) self.deprecated_by = deprecated_by def _validate_impl(self, value, name): raise MyError( "Deprecated settings need to be validated by the replacement setting." ) class ArgValidatorDict(ArgValidator): def __init__( self, name=None, required=False, nested=None, default_value=ArgValidator.DEFAULT, all_missing_during_validate=False, ): if nested is not None: nested = dict([(v.name, v) for v in nested]) else: nested = {} if default_value is ArgValidator.DEFAULT: default_value = self.generate_default ArgValidator.__init__(self, name, required, default_value) self.nested = nested self.all_missing_during_validate = all_missing_during_validate def _validate_impl(self, value, name): result = {} seen_keys = set() if value is None: # Users might want to use jinja2 templates to set properties. As such, # it's convenient to accept None as an alias for an empty dictionary # e.g. setting like `"match": None` will be allowed by the role return {} try: items = list(value.items()) except AttributeError: raise ValidationError(name, "invalid content is not a dictionary") for setting, value in items: try: validator = self.nested[setting] except KeyError: raise ValidationError(name, "invalid key '%s'" % (setting)) if isinstance(validator, ArgValidatorDeprecated): setting = validator.deprecated_by validator = self.nested[setting] if setting in seen_keys: raise ValidationError(name, "duplicate key '%s'" % (setting)) seen_keys.add(setting) try: validated_value = validator._validate(value, name + "." + setting) except ValidationError as e: raise ValidationError(e.name, e.error_message) result[setting] = validated_value for setting, validator in self.nested.items(): if setting in seen_keys: continue if validator.required: raise ValidationError(name, "missing required key '%s'" % (setting)) if not self.all_missing_during_validate: default = validator.get_default_value() if default is not ArgValidator.MISSING: result[setting] = default return result @staticmethod def generate_default_from_nested(nested): result = {} for name, validator in nested.items(): default = validator.get_default_value() if default is not ArgValidator.MISSING: result[name] = default return result def generate_default(self): return ArgValidatorDict.generate_default_from_nested(self.nested) class ArgValidatorList(ArgValidator): def __init__( self, name, nested, default_value=None, remove_none_or_empty=False, ): ArgValidator.__init__(self, name, required=False, default_value=default_value) self.nested = nested self.remove_none_or_empty = remove_none_or_empty def _validate_impl(self, value, name): if value is None: # Users might want to use jinja2 templates to set properties. As such, # it's convenient to accept None as an alias for an empty list # e.g. setting like `"match": {"path": None}` will be allowed by the role value = [] elif isinstance(value, Util.STRING_TYPE): # we expect a list. However, for convenience allow to # specify a string, separated by space. Escaping is # not supported. If you need that, define a proper list. value = [s for s in value.split(" ") if s] result = [] for idx, v in enumerate(value): if (v is None or v == "") and self.remove_none_or_empty: continue try: vv = self.nested._validate(v, name + "[" + str(idx) + "]") except ValidationError as e: raise ValidationError(e.name, e.error_message) result.append(vv) return result class ArgValidatorIP(ArgValidatorStr): def __init__( self, name, family=None, required=False, default_value=None, plain_address=True ): ArgValidatorStr.__init__(self, name, required, default_value, None) self.family = family self.plain_address = plain_address def _validate_impl(self, value, name): v = ArgValidatorStr._validate_impl(self, value, name) try: addr, family = Util.parse_ip(v, self.family) except Exception: raise ValidationError( name, "value '%s' is not a valid IP%s address" % (value, Util.addr_family_to_v(self.family)), ) if self.plain_address: return addr return {"family": family, "address": addr} class ArgValidatorMac(ArgValidatorStr): def __init__( self, name, force_len=None, required=False, default_value=None, enum_values=None ): ArgValidatorStr.__init__(self, name, required, default_value, None) self.force_len = force_len self.enum_values_mac = enum_values def _validate_impl(self, value, name): v = ArgValidatorStr._validate_impl(self, value, name) if self.enum_values_mac is not None and value in self.enum_values_mac: return v try: addr = Util.mac_aton(v, self.force_len) except MyError: enum_ex = "" if self.enum_values_mac is not None: enum_ex = " nor one of %s" % (self.enum_values_mac) raise ValidationError( name, "value '%s' is not a valid MAC address%s" % (value, enum_ex) ) if not addr: enum_ex = "" if self.enum_values_mac is not None: enum_ex = " nor one of %s" % (self.enum_values_mac) raise ValidationError( name, "value '%s' is not a valid MAC address%s" % (value, enum_ex) ) return Util.mac_ntoa(addr) class ArgValidatorIPAddr(ArgValidatorDict): def __init__(self, name, family=None, required=False): ArgValidatorDict.__init__( self, name, required, nested=[ ArgValidatorIP( "address", family=family, required=True, plain_address=False ), ArgValidatorNum("prefix", default_value=None, val_min=0), ], default_value=None, ) self.family = family def _validate_impl(self, value, name): if isinstance(value, Util.STRING_TYPE): v = str(value) if not v: raise ValidationError(name, "cannot be empty") try: return Util.parse_address(v, self.family) except Exception: raise ValidationError( name, "value '%s' is not a valid IP%s address with prefix length" % (value, Util.addr_family_to_v(self.family)), ) v = ArgValidatorDict._validate_impl(self, value, name) return { "address": v["address"]["address"], "family": v["address"]["family"], "prefix": v["prefix"], } def _validate_post(self, value, name, result): family = result["family"] prefix = result["prefix"] if prefix is None: prefix = Util.addr_family_default_prefix(family) result["prefix"] = prefix elif not Util.addr_family_valid_prefix(family, prefix): raise ValidationError(name, "invalid prefix %s in '%s'" % (prefix, value)) return result class ArgValidatorIPRoute(ArgValidatorDict): def __init__(self, name, family=None, required=False): ArgValidatorDict.__init__( self, name, required, nested=[ ArgValidatorIP( "network", family=family, required=True, plain_address=False ), ArgValidatorNum("prefix", default_value=None, val_min=0), ArgValidatorIP( "gateway", family=family, default_value=None, plain_address=False ), ArgValidatorNum( "metric", default_value=-1, val_min=-1, val_max=UINT32_MAX ), ArgValidatorStr( "type", default_value=None, enum_values=["blackhole", "prohibit", "unreachable"], ), ArgValidatorRouteTable("table"), ArgValidatorIP( "src", family=family, default_value=None, plain_address=False ), ], default_value=None, ) self.family = family def _validate_post(self, value, name, result): network = result["network"] family = network["family"] result["network"] = network["address"] result["family"] = family gateway = result["gateway"] route_type = result["type"] if gateway is not None: if family != gateway["family"]: raise ValidationError( name, "conflicting address family between network and gateway '%s'" % (gateway["address"]), ) if route_type is not None: raise ValidationError( name, "a %s route can not have a gateway '%s'" % (route_type, gateway["address"]), ) result["gateway"] = gateway["address"] prefix = result["prefix"] if prefix is None: prefix = Util.addr_family_default_prefix(family) result["prefix"] = prefix elif not Util.addr_family_valid_prefix(family, prefix): raise ValidationError(name, "invalid prefix %s in '%s'" % (prefix, value)) src = result["src"] if src is not None: if family != src["family"]: raise ValidationError( name, "conflicting address family between network and src " "address {0}".format(src["address"]), ) result["src"] = src["address"] return result class ArgValidatorIPRoutingRule(ArgValidatorDict): def __init__(self, name, required=False): ArgValidatorDict.__init__( self, name, required, nested=[ ArgValidatorNum( "priority", default_value=None, required=True, val_min=0, val_max=UINT32_MAX, ), ArgValidatorStr( "action", default_value="to-table", enum_values=["to-table", "blackhole", "prohibit", "unreachable"], ), ArgValidatorRange("dport", val_min=1, val_max=65534), ArgValidatorStr( "family", default_value=None, enum_values=["ipv4", "ipv6"], ), ArgValidatorIPAddr("from"), ArgValidatorNum( "fwmark", default_value=None, val_min=1, val_max=UINT32_MAX ), ArgValidatorNum( "fwmask", default_value=None, val_min=1, val_max=UINT32_MAX ), ArgValidatorStr("iif", default_value=None), ArgValidatorBool("invert", default_value=False), ArgValidatorNum("ipproto", default_value=None, val_min=1, val_max=255), ArgValidatorStr("oif", default_value=None), ArgValidatorRange("sport", val_min=1, val_max=65534), ArgValidatorNum("suppress_prefixlength", default_value=None, val_min=0), ArgValidatorRouteTable("table"), ArgValidatorIPAddr("to"), ArgValidatorNum("tos", default_value=None, val_min=1, val_max=255), ArgValidatorRange("uid", val_min=0, val_max=UINT32_MAX), ], default_value=None, ) def _validate_post(self, value, name, result): family = None if result["family"]: family = Util.addr_family_norm(result["family"]) elif result["from"]: family = result["from"]["family"] elif result["to"]: family = result["to"]["family"] if not family: raise ValidationError(name, "specify the address family 'family'") if result["from"]: if result["from"]["family"] != family: raise ValidationError(name, "invalid address family in 'from'") if result["to"]: if result["to"]["family"] != family: raise ValidationError(name, "invalid address family in 'to'") result["family"] = family if result["action"] == "to-table": if result["table"] is None: raise ValidationError( name, "missing 'table' for the routing rule", ) # `from 0.0.0.0/0` means from all IPv4 addresses # `from ::/0` means from all IPv6 addresses # In NM, if `from` property is not specified in a routing rule, NM # still appends `from 0.0.0.0/0` or `from ::/0` to the rule if result["from"] is not None and result["from"]["address"] not in [ "0.0.0.0", "::", ]: if result["from"]["prefix"] == 0: raise ValidationError( name, "the prefix length for 'from' cannot be zero", ) # NM also allows to specify `to 0.0.0.0/0` or `to ::/0` in a routing # rule, but the connection profiles will only show the `from` setting # for the rule if result["to"] is not None and result["to"]["address"] not in [ "0.0.0.0", "::", ]: if result["to"]["prefix"] == 0: raise ValidationError( name, "the prefix length for 'to' cannot be zero", ) if (result["fwmask"] is None) != (result["fwmark"] is None): raise ValidationError( name, "'fwmask' and 'fwmark' must be set together", ) if result["iif"] is not None: if not Util.ifname_valid(result["iif"]): raise ValidationError( name, "the incoming interface '{0}' specified in the routing rule is " "invalid interface_name".format(result["iif"]), ) if result["oif"] is not None: if not Util.ifname_valid(result["oif"]): raise ValidationError( name, "the outgoing interface '{0}' specified in the routing rule is " "invalid interface_name".format(result["oif"]), ) if result["suppress_prefixlength"] is not None: if not Util.addr_family_valid_prefix( result["family"], result["suppress_prefixlength"] ): raise ValidationError( name, "The specified 'suppress_prefixlength' cannot be greater than " "{0}".format(Util.addr_family_prefix_length(result["family"])), ) if result["action"] != "to-table": raise ValidationError( name, "'suppress_prefixlength' is only allowed with the to-table action", ) return result class ArgValidator_DictIP(ArgValidatorDict): REGEX_DNS_OPTIONS = [ r"^attempts:([1-9]\d*|0)$", r"^debug$", r"^edns0$", r"^inet6$", r"^ip6-bytestring$", r"^ip6-dotint$", r"^ndots:([1-9]\d*|0)$", r"^no-aaaa$", r"^no-check-names$", r"^no-ip6-dotint$", r"^no-reload$", r"^no-tld-query$", r"^rotate$", r"^single-request$", r"^single-request-reopen$", r"^timeout:([1-9]\d*|0)$", r"^trust-ad$", r"^use-vc$", ] def __init__(self): ArgValidatorDict.__init__( self, name="ip", nested=[ ArgValidatorBool("dhcp4", default_value=None), ArgValidatorBool("dhcp4_send_hostname", default_value=None), ArgValidatorIP("gateway4", family=socket.AF_INET), ArgValidatorNum( "route_metric4", val_min=-1, val_max=UINT32_MAX, default_value=None ), ArgValidatorBool("auto6", default_value=None), ArgValidatorBool("ipv4_ignore_auto_dns", default_value=None), ArgValidatorBool("ipv6_ignore_auto_dns", default_value=None), ArgValidatorStr( "wait_ip", enum_values=["any", "ipv4", "ipv6", "ipv4+ipv6"], default_value="any", ), ArgValidatorBool("ipv6_disabled", default_value=None), ArgValidatorIP("gateway6", family=socket.AF_INET6), ArgValidatorNum( "route_metric6", val_min=-1, val_max=UINT32_MAX, default_value=None ), ArgValidatorList( "address", nested=ArgValidatorIPAddr("address[?]"), default_value=list, ), ArgValidatorBool("auto_gateway", default_value=None), ArgValidatorList( "route", nested=ArgValidatorIPRoute("route[?]"), default_value=list ), ArgValidatorBool("route_append_only"), ArgValidatorBool("rule_append_only"), ArgValidatorList( "dns", nested=ArgValidatorIP("dns[?]", plain_address=False), default_value=list, ), ArgValidatorList( "dns_search", nested=ArgValidatorStr("dns_search[?]"), default_value=list, ), ArgValidatorList( "dns_options", nested=ArgValidatorStr( "dns_options[?]", regex=ArgValidator_DictIP.REGEX_DNS_OPTIONS ), default_value=list, ), ArgValidatorNum( "dns_priority", val_min=-2147483648, val_max=2147483647, default_value=0, ), ArgValidatorList( "routing_rule", nested=ArgValidatorIPRoutingRule("routing_rule[?]"), default_value=list, ), ], default_value=lambda: { "dhcp4": True, "dhcp4_send_hostname": None, "gateway4": None, "route_metric4": None, "auto6": True, "ipv4_ignore_auto_dns": None, "ipv6_ignore_auto_dns": None, "wait_ip": "any", "ipv6_disabled": False, "gateway6": None, "route_metric6": None, "address": [], "auto_gateway": None, "route": [], "routing_rule": [], "route_append_only": False, "rule_append_only": False, "dns": [], "dns_search": [], "dns_options": [], "dns_priority": 0, }, ) def _validate_post(self, value, name, result): has_ipv6_addresses = any( addr for addr in result["address"] if addr["family"] == socket.AF_INET6 ) if result["ipv6_disabled"] is True: if result["auto6"] is True: raise ValidationError( name, "'auto6' and 'ipv6_disabled' are mutually exclusive" ) if has_ipv6_addresses: raise ValidationError( name, "'ipv6_disabled' and static IPv6 addresses are mutually exclusive", ) if result["gateway6"] is not None: raise ValidationError( name, "'ipv6_disabled' and 'gateway6' are mutually exclusive" ) if result["route_metric6"] is not None: raise ValidationError( name, "'ipv6_disabled' and 'route_metric6' are mutually exclusive" ) elif result["ipv6_disabled"] is None: # "ipv6_disabled" is not explicitly set, we always set it to False. # Either "auto6" is enabled or static addresses are set, then this # is clearly correct. # Even with "auto6:False" and no IPv6 addresses, we at least enable # IPv6 link local addresses. result["ipv6_disabled"] = False if result["dhcp4"] is None: result["dhcp4"] = result["dhcp4_send_hostname"] is not None or not any( addr for addr in result["address"] if addr["family"] == socket.AF_INET ) if result["auto6"] is None: result["auto6"] = not has_ipv6_addresses if result["dhcp4_send_hostname"] is not None: if not result["dhcp4"]: raise ValidationError( name, "'dhcp4_send_hostname' is only valid if 'dhcp4' is enabled" ) ipv4_gw_defined = result["gateway4"] is not None ipv6_gw_defined = result["gateway6"] is not None dhcp_enabled = result["dhcp4"] or result["auto6"] if result["auto_gateway"] and not ( ipv4_gw_defined or ipv6_gw_defined or dhcp_enabled ): raise ValidationError( name, "must define 'gateway4', 'gateway6', or use dhcp " "if 'auto_gateway' is enabled", ) return result class ArgValidator_DictEthernet(ArgValidatorDict): def __init__(self): ArgValidatorDict.__init__( self, name="ethernet", nested=[ ArgValidatorBool("autoneg", default_value=None), ArgValidatorNum( "speed", val_min=0, val_max=UINT32_MAX, default_value=0 ), ArgValidatorStr( "duplex", enum_values=["half", "full"], default_value=None ), ], default_value=ArgValidator.MISSING, ) def get_default_ethernet(self): return dict([(k, v.get_default_value()) for k, v in self.nested.items()]) def _validate_post(self, value, name, result): has_speed_or_duplex = result["speed"] != 0 or result["duplex"] is not None if result["autoneg"] is None: if has_speed_or_duplex: result["autoneg"] = False elif result["autoneg"]: if has_speed_or_duplex: raise ValidationError( name, "cannot specify '%s' with 'autoneg' enabled" % ("duplex" if result["duplex"] is not None else "speed"), ) else: if not has_speed_or_duplex: raise ValidationError( name, "need to specify 'duplex' and 'speed' with 'autoneg' enabled" ) if has_speed_or_duplex and (result["speed"] == 0 or result["duplex"] is None): raise ValidationError( name, "need to specify both 'speed' and 'duplex' with 'autoneg' disabled", ) return result class ArgValidator_DictEthtool(ArgValidatorDict): def __init__(self): ArgValidatorDict.__init__( self, name="ethtool", nested=[ ArgValidator_DictEthtoolFeatures(), ArgValidator_DictEthtoolCoalesce(), ArgValidator_DictEthtoolRing(), ], ) class ArgValidator_DictEthtoolFeatures(ArgValidatorDict): # List of features created with: # nmcli connection modify "virbr0" ethtool.feature- on |& \ # sed -e 's_[,:]_\n_g' | \ # split output in newlines # grep ^\ f | \ # select only lines starting with " f" # tr -d " ." | \ # remove spaces and fullstops # sed -e 's,feature-,ArgValidatorBool(",' \ # add Python code # -e 's/$/", default_value=None)],/' def __init__(self): ArgValidatorDict.__init__( self, name="features", nested=[ ArgValidatorBool("esp_hw_offload", default_value=None), ArgValidatorDeprecated( "esp-hw-offload", deprecated_by="esp_hw_offload" ), ArgValidatorBool("esp_tx_csum_hw_offload", default_value=None), ArgValidatorDeprecated( "esp-tx-csum-hw-offload", deprecated_by="esp_tx_csum_hw_offload", ), ArgValidatorBool("fcoe_mtu", default_value=None), ArgValidatorDeprecated("fcoe-mtu", deprecated_by="fcoe_mtu"), ArgValidatorBool("gro", default_value=None), ArgValidatorBool("gso", default_value=None), ArgValidatorBool("highdma", default_value=None), ArgValidatorBool("hw_tc_offload", default_value=None), ArgValidatorDeprecated("hw-tc-offload", deprecated_by="hw_tc_offload"), ArgValidatorBool("l2_fwd_offload", default_value=None), ArgValidatorDeprecated( "l2-fwd-offload", deprecated_by="l2_fwd_offload" ), ArgValidatorBool("loopback", default_value=None), ArgValidatorBool("lro", default_value=None), ArgValidatorBool("ntuple", default_value=None), ArgValidatorBool("rx", default_value=None), ArgValidatorBool("rxhash", default_value=None), ArgValidatorBool("rxvlan", default_value=None), ArgValidatorBool("rx_all", default_value=None), ArgValidatorDeprecated("rx-all", deprecated_by="rx_all"), ArgValidatorBool("rx_fcs", default_value=None), ArgValidatorDeprecated("rx-fcs", deprecated_by="rx_fcs"), ArgValidatorBool("rx_gro_hw", default_value=None), ArgValidatorDeprecated("rx-gro-hw", deprecated_by="rx_gro_hw"), ArgValidatorBool("rx_udp_tunnel_port_offload", default_value=None), ArgValidatorDeprecated( "rx-udp_tunnel-port-offload", deprecated_by="rx_udp_tunnel_port_offload", ), ArgValidatorBool("rx_vlan_filter", default_value=None), ArgValidatorDeprecated( "rx-vlan-filter", deprecated_by="rx_vlan_filter" ), ArgValidatorBool("rx_vlan_stag_filter", default_value=None), ArgValidatorDeprecated( "rx-vlan-stag-filter", deprecated_by="rx_vlan_stag_filter", ), ArgValidatorBool("rx_vlan_stag_hw_parse", default_value=None), ArgValidatorDeprecated( "rx-vlan-stag-hw-parse", deprecated_by="rx_vlan_stag_hw_parse", ), ArgValidatorBool("sg", default_value=None), ArgValidatorBool("tls_hw_record", default_value=None), ArgValidatorDeprecated("tls-hw-record", deprecated_by="tls_hw_record"), ArgValidatorBool("tls_hw_tx_offload", default_value=None), ArgValidatorDeprecated( "tls-hw-tx-offload", deprecated_by="tls_hw_tx_offload", ), ArgValidatorBool("tso", default_value=None), ArgValidatorBool("tx", default_value=None), ArgValidatorBool("txvlan", default_value=None), ArgValidatorBool("tx_checksum_fcoe_crc", default_value=None), ArgValidatorDeprecated( "tx-checksum-fcoe-crc", deprecated_by="tx_checksum_fcoe_crc", ), ArgValidatorBool("tx_checksum_ipv4", default_value=None), ArgValidatorDeprecated( "tx-checksum-ipv4", deprecated_by="tx_checksum_ipv4", ), ArgValidatorBool("tx_checksum_ipv6", default_value=None), ArgValidatorDeprecated( "tx-checksum-ipv6", deprecated_by="tx_checksum_ipv6", ), ArgValidatorBool("tx_checksum_ip_generic", default_value=None), ArgValidatorDeprecated( "tx-checksum-ip-generic", deprecated_by="tx_checksum_ip_generic", ), ArgValidatorBool("tx_checksum_sctp", default_value=None), ArgValidatorDeprecated( "tx-checksum-sctp", deprecated_by="tx_checksum_sctp", ), ArgValidatorBool("tx_esp_segmentation", default_value=None), ArgValidatorDeprecated( "tx-esp-segmentation", deprecated_by="tx_esp_segmentation", ), ArgValidatorBool("tx_fcoe_segmentation", default_value=None), ArgValidatorDeprecated( "tx-fcoe-segmentation", deprecated_by="tx_fcoe_segmentation", ), ArgValidatorBool("tx_gre_csum_segmentation", default_value=None), ArgValidatorDeprecated( "tx-gre-csum-segmentation", deprecated_by="tx_gre_csum_segmentation", ), ArgValidatorBool("tx_gre_segmentation", default_value=None), ArgValidatorDeprecated( "tx-gre-segmentation", deprecated_by="tx_gre_segmentation", ), ArgValidatorBool("tx_gso_partial", default_value=None), ArgValidatorDeprecated( "tx-gso-partial", deprecated_by="tx_gso_partial" ), ArgValidatorBool("tx_gso_robust", default_value=None), ArgValidatorDeprecated("tx-gso-robust", deprecated_by="tx_gso_robust"), ArgValidatorBool("tx_ipxip4_segmentation", default_value=None), ArgValidatorDeprecated( "tx-ipxip4-segmentation", deprecated_by="tx_ipxip4_segmentation", ), ArgValidatorBool("tx_ipxip6_segmentation", default_value=None), ArgValidatorDeprecated( "tx-ipxip6-segmentation", deprecated_by="tx_ipxip6_segmentation", ), ArgValidatorBool("tx_nocache_copy", default_value=None), ArgValidatorDeprecated( "tx-nocache-copy", deprecated_by="tx_nocache_copy", ), ArgValidatorBool("tx_scatter_gather", default_value=None), ArgValidatorDeprecated( "tx-scatter-gather", deprecated_by="tx_scatter_gather", ), ArgValidatorBool("tx_scatter_gather_fraglist", default_value=None), ArgValidatorDeprecated( "tx-scatter-gather-fraglist", deprecated_by="tx_scatter_gather_fraglist", ), ArgValidatorBool("tx_sctp_segmentation", default_value=None), ArgValidatorDeprecated( "tx-sctp-segmentation", deprecated_by="tx_sctp_segmentation", ), ArgValidatorBool("tx_tcp6_segmentation", default_value=None), ArgValidatorDeprecated( "tx-tcp6-segmentation", deprecated_by="tx_tcp6_segmentation", ), ArgValidatorBool("tx_tcp_ecn_segmentation", default_value=None), ArgValidatorDeprecated( "tx-tcp-ecn-segmentation", deprecated_by="tx_tcp_ecn_segmentation", ), ArgValidatorBool("tx_tcp_mangleid_segmentation", default_value=None), ArgValidatorDeprecated( "tx-tcp-mangleid-segmentation", deprecated_by="tx_tcp_mangleid_segmentation", ), ArgValidatorBool("tx_tcp_segmentation", default_value=None), ArgValidatorDeprecated( "tx-tcp-segmentation", deprecated_by="tx_tcp_segmentation", ), ArgValidatorBool("tx_udp_segmentation", default_value=None), ArgValidatorDeprecated( "tx-udp-segmentation", deprecated_by="tx_udp_segmentation", ), ArgValidatorBool("tx_udp_tnl_csum_segmentation", default_value=None), ArgValidatorDeprecated( "tx-udp_tnl-csum-segmentation", deprecated_by="tx_udp_tnl_csum_segmentation", ), ArgValidatorBool("tx_udp_tnl_segmentation", default_value=None), ArgValidatorDeprecated( "tx-udp_tnl-segmentation", deprecated_by="tx_udp_tnl_segmentation", ), ArgValidatorBool("tx_vlan_stag_hw_insert", default_value=None), ArgValidatorDeprecated( "tx-vlan-stag-hw-insert", deprecated_by="tx_vlan_stag_hw_insert", ), ], ) class ArgValidator_DictEthtoolCoalesce(ArgValidatorDict): def __init__(self): ArgValidatorDict.__init__( self, name="coalesce", nested=[ ArgValidatorBool("adaptive_rx", default_value=None), ArgValidatorBool("adaptive_tx", default_value=None), ArgValidatorNum( "pkt_rate_high", val_min=0, val_max=UINT32_MAX, default_value=None ), ArgValidatorNum( "pkt_rate_low", val_min=0, val_max=UINT32_MAX, default_value=None ), ArgValidatorNum( "rx_frames", val_min=0, val_max=UINT32_MAX, default_value=None ), ArgValidatorNum( "rx_frames_high", val_min=0, val_max=UINT32_MAX, default_value=None ), ArgValidatorNum( "rx_frames_irq", val_min=0, val_max=UINT32_MAX, default_value=None ), ArgValidatorNum( "rx_frames_low", val_min=0, val_max=UINT32_MAX, default_value=None ), ArgValidatorNum( "rx_usecs", val_min=0, val_max=UINT32_MAX, default_value=None ), ArgValidatorNum( "rx_usecs_high", val_min=0, val_max=UINT32_MAX, default_value=None ), ArgValidatorNum( "rx_usecs_irq", val_min=0, val_max=UINT32_MAX, default_value=None ), ArgValidatorNum( "rx_usecs_low", val_min=0, val_max=UINT32_MAX, default_value=None ), ArgValidatorNum( "sample_interval", val_min=0, val_max=UINT32_MAX, default_value=None, ), ArgValidatorNum( "stats_block_usecs", val_min=0, val_max=UINT32_MAX, default_value=None, ), ArgValidatorNum( "tx_frames", val_min=0, val_max=UINT32_MAX, default_value=None ), ArgValidatorNum( "tx_frames_high", val_min=0, val_max=UINT32_MAX, default_value=None ), ArgValidatorNum( "tx_frames_irq", val_min=0, val_max=UINT32_MAX, default_value=None ), ArgValidatorNum( "tx_frames_low", val_min=0, val_max=UINT32_MAX, default_value=None ), ArgValidatorNum( "tx_usecs", val_min=0, val_max=UINT32_MAX, default_value=None ), ArgValidatorNum( "tx_usecs_high", val_min=0, val_max=UINT32_MAX, default_value=None ), ArgValidatorNum( "tx_usecs_irq", val_min=0, val_max=UINT32_MAX, default_value=None ), ArgValidatorNum( "tx_usecs_low", val_min=0, val_max=UINT32_MAX, default_value=None ), ], ) class ArgValidator_DictEthtoolRing(ArgValidatorDict): def __init__(self): ArgValidatorDict.__init__( self, name="ring", nested=[ ArgValidatorNum( "rx", val_min=0, val_max=UINT32_MAX, default_value=None ), ArgValidatorNum( "rx_jumbo", val_min=0, val_max=UINT32_MAX, default_value=None ), ArgValidatorNum( "rx_mini", val_min=0, val_max=UINT32_MAX, default_value=None ), ArgValidatorNum( "tx", val_min=0, val_max=UINT32_MAX, default_value=None ), ], ) class ArgValidator_DictBond(ArgValidatorDict): VALID_MODES = [ "balance-rr", "active-backup", "balance-xor", "broadcast", "802.3ad", "balance-tlb", "balance-alb", ] def __init__(self): ArgValidatorDict.__init__( self, name="bond", nested=[ ArgValidatorStr("mode", enum_values=ArgValidator_DictBond.VALID_MODES), ArgValidatorNum( "ad_actor_sys_prio", val_min=1, val_max=65535, default_value=None ), ArgValidatorMac("ad_actor_system"), ArgValidatorStr( "ad_select", enum_values=["stable", "bandwidth", "count"] ), ArgValidatorNum( "ad_user_port_key", val_min=0, val_max=1023, default_value=None ), ArgValidatorBool("all_ports_active", default_value=None), ArgValidatorStr("arp_all_targets", enum_values=["any", "all"]), ArgValidatorNum( "arp_interval", val_min=0, val_max=1000000, default_value=None ), ArgValidatorStr( "arp_validate", enum_values=[ "none", "active", "backup", "all", "filter", "filter_active", "filter_backup", ], ), ArgValidatorStr("arp_ip_target"), ArgValidatorNum( "downdelay", val_min=0, val_max=1000000, default_value=None ), ArgValidatorStr( "fail_over_mac", enum_values=["none", "active", "follow"] ), ArgValidatorStr("lacp_rate", enum_values=["slow", "fast"]), ArgValidatorNum( "lp_interval", val_min=1, val_max=1000000, default_value=None ), ArgValidatorNum( "miimon", val_min=0, val_max=1000000, default_value=None ), ArgValidatorNum( "min_links", val_min=0, val_max=1000000, default_value=None ), ArgValidatorNum( "num_grat_arp", val_min=0, val_max=255, default_value=None ), ArgValidatorNum( "packets_per_port", val_min=0, val_max=65535, default_value=None ), ArgValidatorNum( "peer_notif_delay", val_min=0, val_max=1000000, default_value=None ), ArgValidatorStr("primary"), ArgValidatorStr( "primary_reselect", enum_values=["always", "better", "failure"] ), ArgValidatorNum( "resend_igmp", val_min=0, val_max=255, default_value=None ), ArgValidatorBool("tlb_dynamic_lb", default_value=None), ArgValidatorNum( "updelay", val_min=0, val_max=1000000, default_value=None ), ArgValidatorBool("use_carrier", default_value=None), ArgValidatorStr( "xmit_hash_policy", enum_values=[ "layer2", "layer3+4", "layer2+3", "encap2+3", "encap3+4", "vlan+srcmac", ], ), ], default_value=ArgValidator.MISSING, ) def _validate_post(self, value, name, result): AD_OPTIONS = [ "ad_actor_sys_prio", "ad_actor_system", "ad_user_port_key", "lacp_rate", ] ARP_OPTIONS = ["arp_interval", "arp_ip_target", "arp_validate"] ARP_ONLY_MODE = ["balance-rr", "active-backup", "balance-xor", "broadcast"] if result["mode"] != "802.3ad": for option in AD_OPTIONS: if result[option] is not None: raise ValidationError( name, "the bond option {0} is only valid with mode 802.3ad".format( option ), ) if result["packets_per_port"] is not None and result["mode"] != "balance-rr": raise ValidationError( name, "the bond option packets_per_port is only valid with mode balance-rr", ) if result["mode"] not in ARP_ONLY_MODE: for option in ARP_OPTIONS: if result[option] is not None: raise ValidationError( name, "the bond option {0} is only valid with mode balance-rr, active-backup, balance-xor or broadcast".format( option ), ) if result["tlb_dynamic_lb"] is not None and result["mode"] not in [ "balance-tlb", "balance-alb", ]: raise ValidationError( name, "the bond option tlb_dynamic_lb is only valid with mode balance-tlb or balance-alb", ) if result["primary"] is not None and result["mode"] not in [ "active-backup", "balance-tlb", "balance-alb", ]: raise ValidationError( name, "the bond option primary is only valid with mode active-backup, balance-tlb, balance-alb", ) if ( result["updelay"] is not None or result["downdelay"] is not None ) and not result["miimon"]: raise ValidationError( name, "the bond option downdelay or updelay is only valid with miimon enabled", ) if result["peer_notif_delay"]: if not result["miimon"] or result["peer_notif_delay"] % result["miimon"]: raise ValidationError( name, "the bond option peer_notif_delay needs miimon enabled and must be miimon multiple", ) if result["arp_interval"]: raise ValidationError( name, "the bond option peer_notif_delay needs arp_interval disabled", ) if result["arp_ip_target"]: if not result["arp_interval"]: raise ValidationError( name, "the bond option arp_ip_target requires arp_interval to be set", ) if result["arp_interval"]: if not result["arp_ip_target"]: raise ValidationError( name, "the bond option arp_interval requires arp_ip_target to be set", ) return result def get_default_bond(self): return { "mode": ArgValidator_DictBond.VALID_MODES[0], "ad_actor_sys_prio": None, "ad_actor_system": None, "ad_select": None, "ad_user_port_key": None, "all_ports_active": None, "arp_all_targets": None, "arp_interval": None, "arp_ip_target": None, "arp_validate": None, "downdelay": None, "fail_over_mac": None, "lacp_rate": None, "lp_interval": None, "miimon": None, "min_links": None, "num_grat_arp": None, "packets_per_port": None, "peer_notif_delay": None, "primary": None, "primary_reselect": None, "resend_igmp": None, "tlb_dynamic_lb": None, "updelay": None, "use_carrier": None, "xmit_hash_policy": None, } class ArgValidator_DictInfiniband(ArgValidatorDict): def __init__(self): ArgValidatorDict.__init__( self, name="infiniband", nested=[ ArgValidatorStr( "transport_mode", enum_values=["datagram", "connected"] ), ArgValidatorNum( "p_key", val_min=-1, val_max=0xFFFF, default_value=None ), ], default_value=ArgValidator.MISSING, ) def get_default_infiniband(self): return {"transport_mode": "datagram", "p_key": None} class ArgValidator_DictVlan(ArgValidatorDict): def __init__(self): ArgValidatorDict.__init__( self, name="vlan", nested=[ArgValidatorNum("id", val_min=0, val_max=4094, required=True)], default_value=ArgValidator.MISSING, ) def get_default_vlan(self): return {"id": None} class ArgValidator_DictMacvlan(ArgValidatorDict): VALID_MODES = ["vepa", "bridge", "private", "passthru", "source"] def __init__(self): ArgValidatorDict.__init__( self, name="macvlan", nested=[ ArgValidatorStr( "mode", enum_values=ArgValidator_DictMacvlan.VALID_MODES, default_value="bridge", ), ArgValidatorBool("promiscuous", default_value=True), ArgValidatorBool("tap", default_value=False), ], default_value=ArgValidator.MISSING, ) def get_default_macvlan(self): return {"mode": "bridge", "promiscuous": True, "tap": False} def _validate_post(self, value, name, result): if result["promiscuous"] is False and result["mode"] != "passthru": raise ValidationError( name, "non promiscuous operation is allowed only in passthru mode" ) return result class ArgValidatorPath(ArgValidatorStr): """ Validates that the value is a valid posix absolute path """ def __init__(self, name, required=False, default_value=None): ArgValidatorStr.__init__(self, name, required, default_value, None) def _validate_impl(self, value, name): ArgValidatorStr._validate_impl(self, value, name) if posixpath.isabs(value) is False: raise ValidationError( name, "value '%s' is not a valid posix absolute path" % (value), ) return value class ArgValidator_Dict802_1X(ArgValidatorDict): VALID_EAP_TYPES = ["tls"] VALID_PRIVATE_KEY_FLAGS = ["none", "agent-owned", "not-saved", "not-required"] def __init__(self): ArgValidatorDict.__init__( self, name="ieee802_1x", nested=[ ArgValidatorStr( "eap", enum_values=ArgValidator_Dict802_1X.VALID_EAP_TYPES, default_value="tls", ), ArgValidatorStr("identity", required=True), ArgValidatorPath("private_key", required=True), ArgValidatorStr("private_key_password"), ArgValidatorList( "private_key_password_flags", nested=ArgValidatorStr( "private_key_password_flags[?]", enum_values=ArgValidator_Dict802_1X.VALID_PRIVATE_KEY_FLAGS, ), default_value=None, ), ArgValidatorPath("client_cert", required=True), ArgValidatorPath("ca_cert"), ArgValidatorPath("ca_path"), ArgValidatorBool("system_ca_certs", default_value=False), ArgValidatorStr("domain_suffix_match", required=False), ], default_value=None, ) def _validate_post(self, value, name, result): if result["system_ca_certs"] is True and result["ca_path"] is not None: raise ValidationError( name, "ca_path will be ignored by NetworkManager if system_ca_certs is used", ) return result class ArgValidator_DictWireless(ArgValidatorDict): VALID_KEY_MGMT = [ "owe", "sae", "wpa-eap", "wpa-psk", ] def __init__(self): ArgValidatorDict.__init__( self, name="wireless", nested=[ ArgValidatorStr("ssid", max_length=32), ArgValidatorStr( "key_mgmt", enum_values=ArgValidator_DictWireless.VALID_KEY_MGMT ), ArgValidatorStr("password", default_value=None, max_length=63), ], default_value=None, ) def _validate_post(self, value, name, result): if result["key_mgmt"] == "wpa-psk" or result["key_mgmt"] == "sae": if result["password"] is None: raise ValidationError( name, "must supply a password if using {0} key management".format( result["key_mgmt"] ), ) else: if result["password"] is not None: raise ValidationError( name, "password only allowed if using 'wpa-psk' or 'sae' key management", ) return result class ArgValidatorListMatchPath(ArgValidatorList): def __init__(self, name, nested, default_value, remove_none_or_empty): ArgValidatorList.__init__( self, name, nested, default_value, remove_none_or_empty, ) def _validate_impl(self, value, name): result = ArgValidatorList._validate_impl(self, value, name) if result == ["|"] or result == ["&"]: raise ValidationError( name, "value '%s' is not a valid 'match.path' setting, after " "normalization, '%s' will only match the devices that have no PCI " "path" % (value, result), ) return result class ArgValidator_DictMatch(ArgValidatorDict): def __init__(self): ArgValidatorDict.__init__( self, name="match", nested=[ ArgValidatorListMatchPath( "path", nested=ArgValidatorStr("path[?]", allow_empty=True), default_value=None, remove_none_or_empty=True, ), ], default_value={}, ) class ArgValidator_DictConnection(ArgValidatorDict): VALID_PERSISTENT_STATES = ["absent", "present"] VALID_STATES = VALID_PERSISTENT_STATES + ["up", "down"] VALID_TYPES = [ "ethernet", "infiniband", "bridge", "team", "bond", "vlan", "macvlan", "wireless", # wokeignore:rule=dummy "dummy", ] VALID_PORT_TYPES = ["bridge", "bond", "team"] def __init__(self): ArgValidatorDict.__init__( self, name="connection", nested=[ ArgValidatorStr("name"), ArgValidatorStr( "state", enum_values=ArgValidator_DictConnection.VALID_STATES ), ArgValidatorStr( "persistent_state", enum_values=ArgValidator_DictConnection.VALID_PERSISTENT_STATES, ), ArgValidatorBool("force_state_change", default_value=None), ArgValidatorNum( "wait", val_min=0, val_max=3600, numeric_type=float, default_value=None, ), ArgValidatorStr( "type", enum_values=ArgValidator_DictConnection.VALID_TYPES ), ArgValidatorBool("autoconnect", default_value=True), ArgValidatorNum( "autoconnect_retries", val_min=0, val_max=UINT32_MAX, default_value=-1, ), ArgValidatorStr( "port_type", enum_values=ArgValidator_DictConnection.VALID_PORT_TYPES, ), ArgValidatorDeprecated( # wokeignore:rule=slave "slave_type", deprecated_by="port_type", ), ArgValidatorStr("controller"), # wokeignore:rule=master ArgValidatorDeprecated("master", deprecated_by="controller"), ArgValidatorStr("interface_name", allow_empty=True), ArgValidatorMac("mac"), ArgValidatorMac( "cloned_mac", enum_values=[ "default", "preserve", "permanent", "random", "stable", ], default_value="default", ), ArgValidatorNum( "mtu", val_min=0, val_max=UINT32_MAX, default_value=None ), ArgValidatorStr("zone"), ArgValidatorBool("check_iface_exists", default_value=True), ArgValidatorStr("parent"), ArgValidatorBool("ignore_errors", default_value=None), ArgValidator_DictIP(), ArgValidator_DictEthernet(), ArgValidator_DictEthtool(), ArgValidator_DictBond(), ArgValidator_DictInfiniband(), ArgValidator_DictVlan(), ArgValidator_DictMacvlan(), ArgValidator_Dict802_1X(), ArgValidator_DictWireless(), ArgValidator_DictMatch(), # deprecated options: ArgValidatorStr( "infiniband_transport_mode", enum_values=["datagram", "connected"], default_value=ArgValidator.MISSING, ), ArgValidatorNum( "infiniband_p_key", val_min=-1, val_max=0xFFFF, default_value=ArgValidator.MISSING, ), ArgValidatorNum( "vlan_id", val_min=0, val_max=4094, default_value=ArgValidator.MISSING, ), ], default_value=dict, all_missing_during_validate=True, ) # valid field based on specified state, used to set defaults and reject # bad values self.VALID_FIELDS = [] def _validate_post_state(self, value, name, result): """ Validate state definitions and create a corresponding list of actions. """ actions = [] state = result.get("state") persistent_state = result.get("persistent_state") if state in self.VALID_PERSISTENT_STATES: if persistent_state: raise ValidationError( name, "State cannot be '{0}' if persistent_state is specified".format( state ), ) persistent_state = state state = None # default persistent_state to present (not done via default_value in the # ArgValidatorStr, the value will only be set at the end of # _validate_post() if not persistent_state: persistent_state = "present" # If the profile should be absent at the end, it needs to be present in # the meantime to allow to (de)activate it. This is only possible if it # is completely defined, for which `type` needs to be specified. # Otherwise, downing is happening on a best-effort basis if persistent_state == "absent" and state and result.get("type"): actions.append("present") actions.append(persistent_state) # Change the runtime state if necessary if state: actions.append(state) result["state"] = state result["persistent_state"] = persistent_state result["actions"] = actions return result def _validate_post_fields(self, value, name, result): """ Validate the allowed fields (settings depending on the requested state). FIXME: Maybe it should check whether "up"/"down" is present in the actions instead of checking the runtime state from "state" to switch from state to actions after the state parsing is done. """ state = result.get("state") persistent_state = result.get("persistent_state") # minimal settings not related to runtime changes valid_fields = ["actions", "ignore_errors", "name", "persistent_state", "state"] # when type is present, a profile is completely specified (using # defaults or other settings) if "type" in result: valid_fields += list(self.nested.keys()) # If there are no runtime changes, "wait" and "force_state_change" do # not make sense # FIXME: Maybe this restriction can be removed. Need to make sure that # defaults for wait or force_state_change do not interfere if not state: while "wait" in valid_fields: valid_fields.remove("wait") while "force_state_change" in valid_fields: valid_fields.remove("force_state_change") else: valid_fields += ["force_state_change", "wait"] # FIXME: Maybe just accept all values, even if they are not # needed/meaningful in the respective context valid_fields = set(valid_fields) for key in result: if key not in valid_fields: raise ValidationError( name + "." + key, "property is not allowed for state '%s' and persistent_state '%s'" % (state, persistent_state), ) if "name" not in result: if persistent_state == "absent": result["name"] = "" # set to empty string to mean *absent all others* else: raise ValidationError(name, "missing 'name'") # FIXME: Seems to be a duplicate check since "wait" will be removed from # valid_keys when state is considered to be not True if "wait" in result and not state: raise ValidationError( name + ".wait", "'wait' is not allowed for state '%s'" % (result["state"]), ) result["state"] = state result["persistent_state"] = persistent_state self.VALID_FIELDS = valid_fields return result def _validate_post_wireless(self, value, name, result): """ Validate wireless settings """ if "type" in result: if result["type"] == "wireless": if "wireless" in result: if ( result["wireless"]["key_mgmt"] == "wpa-eap" and "ieee802_1x" not in result ): raise ValidationError( name + ".wireless", "key management set to wpa-eap but no " "'ieee802_1x' settings defined", ) else: raise ValidationError( name + ".wireless", "must define 'wireless' settings for 'type' 'wireless'", ) else: if "wireless" in result: raise ValidationError( name + ".wireless", "'wireless' settings are not allowed for 'type' '%s'" % (result["type"]), ) return result def _validate_post(self, value, name, result): result = self._validate_post_state(value, name, result) result = self._validate_post_fields(value, name, result) result = self._validate_post_wireless(value, name, result) if "type" in result: if "controller" in result: if "port_type" not in result: result["port_type"] = None if result["controller"] == result["name"]: raise ValidationError( name + ".controller", '"controller" cannot refer to itself' ) else: if "port_type" in result: raise ValidationError( name + ".port_type", "'port_type' requires a 'controller' property", ) if "ip" in result: if "controller" in result: raise ValidationError( name + ".ip", 'a port cannot have an "ip" property' ) else: if "controller" not in result: result["ip"] = self.nested["ip"].get_default_value() if "zone" in result: if "controller" in result: raise ValidationError( name + ".zone", '"zone" cannot be configured for port types' ) else: result["zone"] = None if "mac" in result: if result["type"] not in ["ethernet", "infiniband"]: raise ValidationError( name + ".mac", "a 'mac' address is only allowed for type 'ethernet' " "or 'infiniband'", ) maclen = len(Util.mac_aton(result["mac"])) if result["type"] == "ethernet" and maclen != 6: raise ValidationError( name + ".mac", "a 'mac' address for type ethernet requires 6 octets " "but is '%s'" % result["mac"], ) if result["type"] == "infiniband" and maclen != 20: raise ValidationError( name + ".mac", "a 'mac' address for type ethernet requires 20 octets " "but is '%s'" % result["mac"], ) if result.get("match"): if "path" in result["match"]: if result["type"] not in ["ethernet", "infiniband"]: raise ValidationError( name + ".match.path", "'match.path' settings are only supported for type " "'ethernet' or 'infiniband'", ) if result["type"] == "infiniband": if "infiniband" not in result: result["infiniband"] = self.nested[ "infiniband" ].get_default_infiniband() if "infiniband_transport_mode" in result: result["infiniband"]["transport_mode"] = result[ "infiniband_transport_mode" ] del result["infiniband_transport_mode"] if "infiniband_p_key" in result: result["infiniband"]["p_key"] = result["infiniband_p_key"] del result["infiniband_p_key"] else: if "infiniband_transport_mode" in result: raise ValidationError( name + ".infiniband_transport_mode", "cannot mix deprecated 'infiniband_transport_mode' " "property with 'infiniband' settings", ) if "infiniband_p_key" in result: raise ValidationError( name + ".infiniband_p_key", "cannot mix deprecated 'infiniband_p_key' property " "with 'infiniband' settings", ) if result["infiniband"]["transport_mode"] is None: result["infiniband"]["transport_mode"] = "datagram" # For the compatibility with NetworkManager API and the initial # infiniband support in the role (the user may get used to set the # `p_key` into `-1` to make the connection created on the physical # infiniband interface), normalize the `p_key` setting as follows if result["infiniband"]["p_key"] == -1: result["infiniband"]["p_key"] = None if result["infiniband"]["p_key"] is not None: if ( result["infiniband"]["p_key"] == 0x0000 or result["infiniband"]["p_key"] == 0x8000 ): raise ValidationError( name, "the pkey value {0} is not allowed as such a pkey value is not " "supported by kernel".format(result["infiniband"]["p_key"]), ) if "mac" not in result and "parent" not in result: raise ValidationError( name + ".infiniband.p_key", "a infiniband device with 'infiniband.p_key' " "property also needs 'mac' or 'parent' property", ) if "interface_name" in result: raise ValidationError( name + ".interface_name", "the 'interface_name' must be unset for the ipoib " "connection, instead it is {0}".format( result["interface_name"] ), ) else: if "infiniband" in result: raise ValidationError( name + ".infiniband", "'infiniband' settings are only allowed for type 'infiniband'", ) if "infiniband_transport_mode" in result: raise ValidationError( name + ".infiniband_transport_mode", "a 'infiniband_transport_mode' property is only " "allowed for type 'infiniband'", ) if "infiniband_p_key" in result: raise ValidationError( name + ".infiniband_p_key", "a 'infiniband_p_key' property is only allowed for " "type 'infiniband'", ) if "interface_name" in result: # Ignore empty interface_name if result["interface_name"] == "": del result["interface_name"] elif not Util.ifname_valid(result["interface_name"]): raise ValidationError( name + ".interface_name", "invalid 'interface_name' '%s'" % (result["interface_name"]), ) else: if ( not result.get("mac") and (not result.get("match") or not result["match"].get("path")) and not ( result["type"] == "infiniband" and result["infiniband"]["p_key"] is not None ) ): if not Util.ifname_valid(result["name"]): raise ValidationError( name + ".interface_name", "'interface_name' as 'name' '%s' is not valid" % (result["name"]), ) result["interface_name"] = result["name"] if "interface_name" not in result and result["type"] in [ "bond", "bridge", "macvlan", "team", "vlan", ]: raise ValidationError( name + ".interface_name", "type '%s' requires 'interface_name'" % (result["type"]), ) if result["type"] == "vlan": if "vlan" not in result: if "vlan_id" not in result: raise ValidationError( name + ".vlan", 'missing "vlan" settings for "type" "vlan"' ) result["vlan"] = self.nested["vlan"].get_default_vlan() result["vlan"]["id"] = result["vlan_id"] del result["vlan_id"] else: if "vlan_id" in result: raise ValidationError( name + ".vlan_id", "don't use the deprecated 'vlan_id' together with the " "'vlan' settings'", ) if "parent" not in result: raise ValidationError( name + ".parent", 'missing "parent" for "type" "vlan"' ) else: if "vlan" in result: raise ValidationError( name + ".vlan", '"vlan" is only allowed for "type" "vlan"' ) if "vlan_id" in result: raise ValidationError( name + ".vlan_id", '"vlan_id" is only allowed for "type" "vlan"' ) if "parent" in result: if result["type"] not in ["vlan", "macvlan", "infiniband"]: raise ValidationError( name + ".parent", "'parent' is only allowed for type 'vlan', 'macvlan' or " "'infiniband'", ) if result["parent"] == result["name"]: raise ValidationError( name + ".parent", '"parent" cannot refer to itself' ) if result["type"] == "bond": if "bond" not in result: result["bond"] = self.nested["bond"].get_default_bond() else: if "bond" in result: raise ValidationError( name + ".bond", "'bond' settings are not allowed for 'type' '%s'" % (result["type"]), ) if result["type"] in ["ethernet", "vlan", "bridge", "bond", "team"]: if "ethernet" not in result: result["ethernet"] = self.nested["ethernet"].get_default_ethernet() else: if "ethernet" in result: raise ValidationError( name + ".ethernet", "'ethernet' settings are not allowed for 'type' '%s'" % (result["type"]), ) if result["type"] == "macvlan": if "macvlan" not in result: result["macvlan"] = self.nested["macvlan"].get_default_macvlan() else: if "macvlan" in result: raise ValidationError( name + ".macvlan", "'macvlan' settings are not allowed for 'type' '%s'" % (result["type"]), ) if "ieee802_1x" in result and result["type"] not in [ "ethernet", "wireless", ]: raise ValidationError( name + ".ieee802_1x", "802.1x settings only allowed for ethernet or wireless interfaces.", ) for name in self.VALID_FIELDS: if name in result: continue value = self.nested[name].get_default_value() if value is not ArgValidator.MISSING: result[name] = value return result class ArgValidator_ListConnections(ArgValidatorList): def __init__(self): ArgValidatorList.__init__( self, name="connections", nested=ArgValidator_DictConnection(), default_value=list, ) def _validate_post(self, value, name, result): for idx, connection in enumerate(result): if "type" in connection: if connection["controller"]: c = ArgUtil.connection_find_by_name( connection["controller"], result, idx ) if not c: raise ValidationError( name + "[" + str(idx) + "].controller", "references non-existing 'controller' connection '%s'" % (connection["controller"]), ) if c["type"] not in ArgValidator_DictConnection.VALID_PORT_TYPES: raise ValidationError( name + "[" + str(idx) + "].controller", "references 'controller' connection '%s' which is " "not a controller " "type by '%s'" % (connection["controller"], c["type"]), ) if connection["type"] == "infiniband": if c["type"] == "bond" and c["bond"]["mode"] != "active-backup": raise ValidationError( name + "[" + str(idx) + "].controller", "bond only supports infiniband ports in active-backup mode", ) if connection["port_type"] is None: connection["port_type"] = c["type"] elif connection["port_type"] != c["type"]: raise ValidationError( name + "[" + str(idx) + "].controller", "references 'controller' connection '%s' which is " "of type '%s' instead of port_type '%s'" % ( connection["controller"], c["type"], connection["port_type"], ), ) if connection["parent"]: if not ArgUtil.connection_find_by_name( connection["parent"], result, idx ): raise ValidationError( name + "[" + str(idx) + "].parent", "references non-existing 'parent' connection '%s'" % (connection["parent"]), ) return result VALIDATE_ONE_MODE_NM = "nm" VALIDATE_ONE_MODE_INITSCRIPTS = "initscripts" def validate_route_tables(self, connection, idx): rule_route_combined_list = ( connection["ip"]["route"] + connection["ip"]["routing_rule"] ) for r in rule_route_combined_list: if isinstance(r["table"], Util.STRING_TYPE): mapping = IPRouteUtils.get_route_tables_mapping() if r["table"] in mapping: r["table"] = mapping[r["table"]] else: raise ValidationError.from_connection( idx, "cannot find route table {0} in `/etc/iproute2/rt_tables` or " "`/etc/iproute2/rt_tables.d/`".format(r["table"]), ) def validate_connection_one(self, mode, connections, idx): def _ipv4_enabled(connection): has_addrs4 = any( address["family"] == socket.AF_INET for address in connection["ip"]["address"] ) return connection["ip"]["dhcp4"] or has_addrs4 def _ipv6_is_not_configured(connection): has_addrs6 = any( address["family"] == socket.AF_INET6 for address in connection["ip"]["address"] ) return ( not connection["ip"]["ipv6_disabled"] and not connection["ip"]["auto6"] and not has_addrs6 ) connection = connections[idx] if "type" not in connection: return if (connection["parent"]) and ( ( (mode == self.VALIDATE_ONE_MODE_INITSCRIPTS) and (connection["type"] == "vlan") ) or ( (connection["type"] == "infiniband") and (connection["infiniband"]["p_key"] is not None) ) ): try: ArgUtil.connection_find_controller( connection["parent"], connections, idx ) except MyError: raise ValidationError.from_connection( idx, "profile references a parent '%s' which has 'interface_name' " "missing" % (connection["parent"]), ) if (connection["controller"]) and (mode == self.VALIDATE_ONE_MODE_INITSCRIPTS): try: ArgUtil.connection_find_controller( connection["controller"], connections, idx ) except MyError: raise ValidationError.from_connection( idx, "profile references a controller '%s' which has 'interface_name' " "missing" % (connection["controller"]), ) # check if 802.1x connection is valid if connection["ieee802_1x"]: if mode == self.VALIDATE_ONE_MODE_INITSCRIPTS: raise ValidationError.from_connection( idx, "802.1x authentication is not supported by initscripts. " "Configure 802.1x in /etc/wpa_supplicant.conf " "if you need to use initscripts.", ) # check if wireless connection is valid if connection["type"] == "wireless": if mode == self.VALIDATE_ONE_MODE_INITSCRIPTS: raise ValidationError.from_connection( idx, "Wireless WPA auth is not supported by initscripts. " "Configure wireless connection in /etc/wpa_supplicant.conf " "if you need to use initscripts.", ) # initscripts does not support ip.ipv4_ignore_auto_dns or # ip.ipv6_ignore_auto_dns, so raise errors when network # provider is initscripts if ( connection["ip"]["ipv4_ignore_auto_dns"] is not None or connection["ip"]["ipv6_ignore_auto_dns"] is not None ): if mode == self.VALIDATE_ONE_MODE_INITSCRIPTS: raise ValidationError.from_connection( idx, "ip.ipv4_ignore_auto_dns or ip.ipv6_ignore_auto_dns is not " "supported by initscripts.", ) # initscripts does not support ip.wait_ip, # so raise errors when network provider is initscripts if connection["ip"]["wait_ip"] != "any": if mode == self.VALIDATE_ONE_MODE_INITSCRIPTS: raise ValidationError.from_connection( idx, "ip.wait_ip is not supported by initscripts.", ) # initscripts does not support ip.dns_options, so raise errors when network # provider is initscripts if connection["ip"]["dns_options"]: if mode == self.VALIDATE_ONE_MODE_INITSCRIPTS: raise ValidationError.from_connection( idx, "ip.dns_options is not supported by initscripts.", ) # initscripts does not support ip.ipv6_disabled, so raise errors when network # provider is initscripts if connection["ip"]["ipv6_disabled"]: if mode == self.VALIDATE_ONE_MODE_INITSCRIPTS: raise ValidationError.from_connection( idx, "ip.ipv6_disabled is not supported by initscripts.", ) if not hasattr(Util.NM(), "SETTING_IP6_CONFIG_METHOD_DISABLED"): raise ValidationError.from_connection( idx, "ip.ipv6_disabled is not supported by the running version of " "NetworkManager, it requires at least version 1.20. But you can " "disable IPv6 auto configuration by setting ip.auto6 to False. " "Then NetworkManager will ignore IPv6 for this connection. This " "will still leave the sysctl value 'disable_ipv6' unchanged, but " "setting ip.ipv6_disabled to True in the role will set the sysctl " "value 'disable_ipv6' to True ", ) # Setting ip.dns is not allowed when corresponding IP method for that # nameserver is disabled for nameserver in connection["ip"]["dns"]: if nameserver["family"] == socket.AF_INET and not _ipv4_enabled(connection): raise ValidationError.from_connection( idx, "IPv4 needs to be enabled to support IPv4 nameservers.", ) if nameserver["family"] == socket.AF_INET6 and ( connection["ip"]["ipv6_disabled"] or _ipv6_is_not_configured(connection) ): raise ValidationError.from_connection( idx, "IPv6 needs to be enabled to support IPv6 nameservers.", ) # when IPv4 and IPv6 are disabled, setting ip.dns_options or # ip.dns_search or ip.dns_priority is not allowed if ( connection["ip"]["dns_search"] or connection["ip"]["dns_options"] or connection["ip"]["dns_priority"] ): if not _ipv4_enabled(connection) and connection["ip"]["ipv6_disabled"]: raise ValidationError.from_connection( idx, "Setting 'dns_search', 'dns_options' and 'dns_priority' are not " "allowed when both IPv4 and IPv6 are disabled.", ) elif not _ipv4_enabled(connection) and _ipv6_is_not_configured(connection): raise ValidationError.from_connection( idx, "Setting 'dns_search', 'dns_options' and 'dns_priority' are not " "allowed when IPv4 is disabled and IPv6 is not configured.", ) # DNS options 'inet6', 'ip6-bytestring', 'ip6-dotint', 'no-ip6-dotint' are only # supported for IPv6 configuration, so raise errors when IPv6 is disabled if any( option in connection["ip"]["dns_options"] for option in [ "inet6", "ip6-bytestring", "ip6-dotint", "no-ip6-dotint", ] ): if connection["ip"]["ipv6_disabled"]: raise ValidationError.from_connection( idx, "Setting DNS options 'inet6', 'ip6-bytestring', 'ip6-dotint', " "'no-ip6-dotint' is not allowed when IPv6 is disabled.", ) if connection["match"]: if connection["match"]["path"]: if mode == self.VALIDATE_ONE_MODE_INITSCRIPTS: raise ValidationError.from_connection( idx, "match.path is not supported by initscripts.", ) else: if not hasattr(Util.NM(), "SETTING_MATCH_PATH"): raise ValidationError.from_connection( idx, "match.path is not supported by the running version of " "NetworkManger.", ) if "bond" in connection: if mode == self.VALIDATE_ONE_MODE_INITSCRIPTS: for option in connection["bond"]: if connection["bond"][option] is not None and option not in [ "mode", "miimon", ]: raise ValidationError.from_connection( idx, "initscripts only supports the mode and miimon bond " "options. All the other bond options are not supported by " "initscripts.", ) # the `peer_notif_delay` bond option was supported in NM since NM 1.30 if connection["bond"]["peer_notif_delay"]: if not hasattr(Util.NM(), "SETTING_BOND_OPTION_PEER_NOTIF_DELAY"): raise ValidationError.from_connection( idx, "the bond option peer_notif_delay is not supported in " "NetworkManger until NM 1.30", ) if connection["ip"]["route"]: if mode == self.VALIDATE_ONE_MODE_INITSCRIPTS: for route in connection["ip"]["route"]: if route["type"] is not None: raise ValidationError.from_connection( idx, "type is not supported by initscripts", ) if route["src"] is not None: raise ValidationError.from_connection( idx, "configuring the route source is not supported by initscripts", ) if connection["ip"]["routing_rule"]: if mode == self.VALIDATE_ONE_MODE_INITSCRIPTS: raise ValidationError.from_connection( idx, "ip.routing_rule is not supported by initscripts", ) for routing_rule in connection["ip"]["routing_rule"]: if routing_rule["suppress_prefixlength"] is not None: if not hasattr( Util.NM().IPRoutingRule, "set_suppress_prefixlength" ): raise ValidationError.from_connection( idx, "the routing rule selector 'suppress_prefixlength' is not " "supported in NetworkManger until NM 1.20", ) for routing_rule in connection["ip"]["routing_rule"]: if routing_rule["uid"] is not None: if not hasattr(Util.NM().IPRoutingRule, "set_uid_range"): raise ValidationError.from_connection( idx, "the routing rule selector 'uid' is not supported in " "NetworkManger until NM 1.34", ) if mode == self.VALIDATE_ONE_MODE_INITSCRIPTS and connection["cloned_mac"] in [ "preserve", "permanent", "random", "stable", ]: raise ValidationError.from_connection( idx, "Non-MAC argument is not supported by initscripts.", ) self.validate_route_tables(connection, idx) class IPRouteUtils(object): # iproute2 does not care much about the valid characters of a # table alias (it doesn't even require UTF-8 encoding, the only # forbidden parts are whitespace). # # We don't allow such flexibility. Aliases must only contain a # certain set of ASCII characters. These aliases are what we accept # as input (in the playbook), and there is no need to accept # user input with unusual characters or non-ASCII names. _ROUTE_TABLE_NAME_PATTERN = "[a-zA-Z0-9_.-]+" ROUTE_TABLE_NAME_REGEX = re.compile("^" + _ROUTE_TABLE_NAME_PATTERN + "$") @classmethod def _parse_route_tables_mapping(cls, file_content, mapping): # This parses the /etc/iproute2/rt_tables file and constructs # the mapping from table aliases the table numeric IDs. # # It is thus similar to rtnl_rttable_a2n(), from here: # https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/tree/lib/rt_names.c?id=11e41a635cfab54e8e02fbff2a03715467e77ae9#n447 regex = re.compile( b"^\\s*" # optional leading whitespace b"(0x[0-9a-fA-F]+|[0-9]+)" # table ID in hex or decimal (non negative) b"\\s+" # whitespace b"(" # make a pattern group for the table name + cls._ROUTE_TABLE_NAME_PATTERN.encode("ascii") + b")" # close pattern group b"(\\s*|\\s+#.*)$" # trailing whitespace or comment ) for line in file_content.split(b"\n"): rmatch = regex.match(line) if not rmatch: continue table = rmatch.group(1) name = rmatch.group(2).decode("ascii") if table.startswith(b"0x"): tableid = int(table, 16) else: tableid = int(table) if tableid > UINT32_MAX: continue # In case of duplicates, the latter wins. That is unlike iproute2's # rtnl_rttable_a2n(), which does a linear search over the # hash table (thus, the first found name depends on the content # of the hash table and the result in face of duplicates is # not well defined). mapping[name] = tableid @classmethod def _parse_route_tables_mapping_from_file(cls, filename, mapping): try: with open(filename, "rb") as f: file_content = f.read() except Exception: return cls._parse_route_tables_mapping(file_content, mapping) @classmethod def get_route_tables_mapping(cls): if not hasattr(cls, "_cached_rt_tables"): mapping = {} cls._parse_route_tables_mapping_from_file( "/etc/iproute2/rt_tables", mapping ) # In iproute2, the directory `/etc/iproute2/rt_tables/rt_tables.d` # is also iterated when get the mapping between the route table name # and route table id, # https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/tree/lib/rt_names.c?id=ade99e208c1843ed3b6eb9d138aa15a6a5eb5219#n391 try: fnames = os.listdir("/etc/iproute2/rt_tables.d") except Exception: fnames = [] for f in fnames: if f.endswith(".conf") and f[0] != ".": cls._parse_route_tables_mapping_from_file( "/etc/iproute2/rt_tables.d/" + f, mapping ) cls._cached_rt_tables = mapping return cls._cached_rt_tables
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==library.network_connections:[6:2903] ==library.network_connections:[6:2903] __metaclass__ = type DOCUMENTATION = """ --- module: network_connections author: Thomas Haller (@thom311) short_description: module for network role to manage connection profiles requirements: [pygobject, dbus, NetworkManager] version_added: "2.13.0" description: - "WARNING: Do not use this module directly! It is only for role internal use." - | Manage networking profiles (connections) for NetworkManager and initscripts networking providers. Documentation needs to be written. Note that the network_connections module tightly integrates with the network role and currently it is not expected to use this module outside the role. Thus, consult README.md for examples for the role. The requirements are only for the NetworkManager (nm) provider. options: __debug_flags: description: Flags to use for debugging required: false type: str default: '' force_state_change: description: Force a state change required: false type: bool default: False ignore_errors: description: Ignore errors required: false type: bool default: False __header: description: Header to use in generated files required: true type: str provider: description: Network provider to use - initscripts or nm required: true type: str connections: description: Network configuration options required: false default: [] type: list elements: dict """ EXAMPLES = """ network_connections: connections: - name: eth0 state: up """ import errno import functools import os import re import shlex import socket import subprocess import time import traceback import logging # pylint: disable=import-error, no-name-in-module from ansible.module_utils.basic import AnsibleModule from ansible.module_utils.network_lsr import ethtool # noqa:E501 from ansible.module_utils.network_lsr.myerror import MyError # noqa:E501 from ansible.module_utils.network_lsr.argument_validator import ( # noqa:E501 ArgUtil, ArgValidator_ListConnections, ValidationError, ) from ansible.module_utils.network_lsr.utils import Util # noqa:E501 from ansible.module_utils.network_lsr import nm_provider # noqa:E501 # pylint: enable=import-error, no-name-in-module ############################################################################### PERSISTENT_STATE = "persistent_state" ABSENT_STATE = "absent" DEFAULT_ACTIVATION_TIMEOUT = 90 DEFAULT_TIMEOUT = 10 NULL_MAC = "00:00:00:00:00:00" class CheckMode: PREPARE = "prepare" DRY_RUN = "dry-run" PRE_RUN = "pre-run" REAL_RUN = "real-run" DONE = "done" class LogLevel: ERROR = "error" WARN = "warn" INFO = "info" DEBUG = "debug" _LOGGING_LEVEL_MAP = { logging.DEBUG: DEBUG, logging.INFO: INFO, logging.WARN: WARN, logging.ERROR: ERROR, } @staticmethod def from_logging_level(logging_level): return LogLevel._LOGGING_LEVEL_MAP.get(logging_level, LogLevel.ERROR) @staticmethod def fmt(level): return "<%-6s" % (str(level) + ">") # cmp() is not available in python 3 anymore if "cmp" not in dir(__builtins__): def cmp(x, y): """ Replacement for built-in function cmp that was removed in Python 3 Compare the two objects x and y and return an integer according to the outcome. The return value is negative if x < y, zero if x == y and strictly positive if x > y. """ return (x > y) - (x < y) class SysUtil: @staticmethod def _sysctl_read(filename): try_count = 0 while True: try_count += 1 try: with open(filename, "r") as f: return f.read() except Exception: if try_count < 5: continue raise @staticmethod def _link_read_ifindex(ifname): c = SysUtil._sysctl_read("/sys/class/net/" + ifname + "/ifindex") return int(c.strip()) @staticmethod def _link_read_address(ifname): c = SysUtil._sysctl_read("/sys/class/net/" + ifname + "/address") return Util.mac_norm(c.strip()) @staticmethod def _link_read_bond_port_perm_hwaddr(ifname): filename = os.path.join( "/sys/class/net", ifname, # wokeignore:rule=slave "bonding_slave", "perm_hwaddr", ) if not os.path.exists(filename): return None c = SysUtil._sysctl_read(filename) return Util.mac_norm(c.strip()) @staticmethod def _link_read_permaddress(ifname): return ethtool.get_perm_addr(ifname) @staticmethod def _link_infos_fetch(): links = {} for ifname in os.listdir("/sys/class/net/"): if not os.path.islink("/sys/class/net/" + ifname): # /sys/class/net may contain certain entries # that are not interface names, like # wokeignore:rule=master # 'bonding_master'. # Skip over files that are not links. continue links[ifname] = { "ifindex": SysUtil._link_read_ifindex(ifname), "ifname": ifname, "address": SysUtil._link_read_address(ifname), "perm-address": SysUtil._link_read_permaddress(ifname), # When an interface is added as a port of a bonding device, its MAC # address might change, we need to retrieve and preserve the original # MAC address to ensure the user-provided interface name and MAC match # correctly. "bond-port-perm-hwaddr": SysUtil._link_read_bond_port_perm_hwaddr( ifname ), } return links @classmethod def link_infos(cls, refresh=False): if refresh: linkinfos = None else: linkinfos = getattr(cls, "_link_infos", None) if linkinfos is None: try_count = 0 last_fetch_linkinfos = None while True: try_count += 1 try: # there is a race in that we lookup properties by ifname # and interfaces can be renamed. Try to avoid that by # fetching the info twice and repeat until we get the same # result. if last_fetch_linkinfos is None: last_fetch_linkinfos = SysUtil._link_infos_fetch() linkinfos = SysUtil._link_infos_fetch() if linkinfos != last_fetch_linkinfos: last_fetch_linkinfos = linkinfos raise Exception( "cannot read stable link-infos. They keep changing" ) except Exception: if try_count < 50: raise continue break cls._link_infos = linkinfos return linkinfos @classmethod def link_info_find(cls, ifname): result = None for linkinfo in cls.link_infos().values(): if ifname == linkinfo["ifname"]: result = linkinfo break return result ############################################################################### ############################################################################### class IfcfgUtil: FILE_TYPES = ["ifcfg", "keys", "route", "route6", "rule", "rule6"] @classmethod def _file_types(cls, file_type): if file_type is None: return cls.FILE_TYPES else: return [file_type] @classmethod def ifcfg_paths(cls, name, file_types=None): paths = [] if file_types is None: file_types = cls.FILE_TYPES for f in file_types: paths.append(cls.ifcfg_path(name, f)) return paths @classmethod def ifcfg_path(cls, name, file_type=None): n = str(name) if not name or n == "." or n == ".." or n.find("/") != -1: raise MyError("invalid ifcfg-name %s" % (name)) if file_type is None: file_type = "ifcfg" if file_type not in cls.FILE_TYPES: raise MyError("invalid file-type %s" % (file_type)) return "/etc/sysconfig/network-scripts/" + file_type + "-" + n @classmethod def KeyValid(cls, name): r = getattr(cls, "_CHECKSTR_VALID_KEY", None) if r is None: r = re.compile("^[a-zA-Z][a-zA-Z0-9_]*$") cls._CHECKSTR_VALID_KEY = r return bool(r.match(name)) @classmethod def ValueEscape(cls, value): r = getattr(cls, "_re_ValueEscape", None) if r is None: r = re.compile("^[a-zA-Z_0-9-.]*$") cls._re_ValueEscape = r if r.match(value): return value if any(ord(c) < ord(" ") for c in value): # needs ansic escaping due to ANSI control characters (newline) s = "$'" for c in value: if ord(c) < ord(c): s += "\\" + str(ord(c)) elif c == "\\" or c == "'": s += "\\" + c else: # non-unicode chars are fine too to take literally # as utf8 s += c s += "'" else: # double quoting s = '"' for c in value: if c == '"' or c == "\\" or c == "$" or c == "`": s += "\\" + c else: # non-unicode chars are fine too to take literally # as utf8 s += c s += '"' return s @classmethod def _ifcfg_route_merge(cls, route, append_only, current): if not append_only or current is None: if not route: return None return "\n".join(route) + "\n" if route: # the 'route' file is processed line by line by initscripts' # ifup-route. Hence, the order of the route matters. # _ifcfg_route_merge() is not sophisticated enough to understand # pre-existing lines. It will only append lines that don't exist # yet, which hopefully is correct. It's better to always rewrite # the entire file with route_append_only=False. changed = False c_lines = list(current.split("\n")) for r in route: if r not in c_lines: changed = True c_lines.append(r) if changed: return "\n".join(c_lines) + "\n" return current @classmethod def ifcfg_create( cls, connections, idx, warn_fcn=lambda msg: None, content_current=None ): connection = connections[idx] ip = connection["ip"] ifcfg = {} keys_file = None route4_file = None route6_file = None rule4_file = None rule6_file = None if ip["dhcp4_send_hostname"] is not None: warn_fcn("ip.dhcp4_send_hostname is not supported by initscripts provider") if ip["route_metric6"] is not None and ip["route_metric6"] >= 0: warn_fcn("ip.route_metric6 is not supported by initscripts provider") ifcfg["NM_CONTROLLED"] = "no" if connection["autoconnect"]: ifcfg["ONBOOT"] = "yes" else: ifcfg["ONBOOT"] = "no" ifcfg["DEVICE"] = connection["interface_name"] if connection["cloned_mac"] != "default": ifcfg["MACADDR"] = connection["cloned_mac"] if connection["type"] == "ethernet": ifcfg["TYPE"] = "Ethernet" ifcfg["HWADDR"] = connection["mac"] elif connection["type"] == "infiniband": ifcfg["TYPE"] = "InfiniBand" ifcfg["HWADDR"] = connection["mac"] ifcfg["CONNECTED_MODE"] = ( "yes" if (connection["infiniband"]["transport_mode"] == "connected") else "no" ) if connection["infiniband"]["p_key"] is not None: ifcfg["PKEY"] = "yes" ifcfg["PKEY_ID"] = str(connection["infiniband"]["p_key"]) if connection["parent"]: ifcfg["PHYSDEV"] = ArgUtil.connection_find_controller( connection["parent"], connections, idx ) elif connection["type"] == "bridge": ifcfg["TYPE"] = "Bridge" elif connection["type"] == "bond": ifcfg["TYPE"] = "Bond" # wokeignore:rule=master ifcfg["BONDING_MASTER"] = "yes" opts = ["mode=%s" % (connection["bond"]["mode"])] if connection["bond"]["miimon"] is not None: opts.append(" miimon=%s" % (connection["bond"]["miimon"])) ifcfg["BONDING_OPTS"] = " ".join(opts) elif connection["type"] == "team": ifcfg["DEVICETYPE"] = "Team" elif connection["type"] == "vlan": ifcfg["VLAN"] = "yes" ifcfg["TYPE"] = "Vlan" ifcfg["PHYSDEV"] = ArgUtil.connection_find_controller( connection["parent"], connections, idx ) ifcfg["VID"] = str(connection["vlan"]["id"]) else: raise MyError("unsupported type %s" % (connection["type"])) if connection["mtu"]: ifcfg["MTU"] = str(connection["mtu"]) ethtool_options = "" if "ethernet" in connection: if connection["ethernet"]["autoneg"] is not None: if connection["ethernet"]["autoneg"]: ethtool_options = "autoneg on" else: ethtool_options = "autoneg off speed %s duplex %s" % ( connection["ethernet"]["speed"], connection["ethernet"]["duplex"], ) ethtool_features = connection["ethtool"]["features"] configured_features = [] for feature, setting in ethtool_features.items(): feature = feature.replace("_", "-") value = "" if setting: value = "on" elif setting is not None: value = "off" if value: configured_features.append("%s %s" % (feature, value)) if configured_features: if ethtool_options: ethtool_options += " ; " ethtool_options += "-K %s %s" % ( connection["interface_name"], " ".join(configured_features), ) ethtool_coalesce = connection["ethtool"]["coalesce"] configured_coalesce = [] for coalesce, setting in ethtool_coalesce.items(): if setting is not None: if isinstance(setting, bool): setting = int(setting) configured_coalesce.append( "%s %s" % (coalesce.replace("_", "-"), setting) ) if configured_coalesce: if ethtool_options: ethtool_options += " ; " ethtool_options += "-C %s %s" % ( connection["interface_name"], " ".join(configured_coalesce), ) ethtool_ring = connection["ethtool"]["ring"] configured_ring = [] for ring, setting in ethtool_ring.items(): if setting is not None: configured_ring.append("%s %s" % (ring.replace("_", "-"), setting)) if configured_ring: if ethtool_options: ethtool_options += " ; " ethtool_options += "-G %s %s" % ( connection["interface_name"], " ".join(configured_ring), ) if ethtool_options: ifcfg["ETHTOOL_OPTS"] = ethtool_options if connection["controller"] is not None: controller = ArgUtil.connection_find_controller( connection["controller"], connections, idx ) if connection["port_type"] == "bridge": ifcfg["BRIDGE"] = controller elif connection["port_type"] == "bond": # wokeignore:rule=master ifcfg["MASTER"] = controller # wokeignore:rule=slave ifcfg["SLAVE"] = "yes" elif connection["port_type"] == "team": # wokeignore:rule=master ifcfg["TEAM_MASTER"] = controller if "TYPE" in ifcfg: del ifcfg["TYPE"] if connection["type"] != "team": ifcfg["DEVICETYPE"] = "TeamPort" else: raise MyError("invalid port_type '%s'" % (connection["port_type"])) if ip["route_append_only"] and content_current: route4_file = content_current["route"] route6_file = content_current["route6"] else: if connection["zone"]: ifcfg["ZONE"] = connection["zone"] addrs4 = [ addr for addr in ip["address"] if addr["family"] == socket.AF_INET ] addrs6 = [ addr for addr in ip["address"] if addr["family"] == socket.AF_INET6 ] if ip["dhcp4"]: ifcfg["BOOTPROTO"] = "dhcp" elif addrs4: ifcfg["BOOTPROTO"] = "static" else: ifcfg["BOOTPROTO"] = "none" for i in range(0, len(addrs4)): addr = addrs4[i] ifcfg["IPADDR" + ("" if i == 0 else str(i))] = addr["address"] ifcfg["PREFIX" + ("" if i == 0 else str(i))] = str(addr["prefix"]) if ip["gateway4"] is not None: ifcfg["GATEWAY"] = ip["gateway4"] for idx, dns in enumerate(ip["dns"]): ifcfg["DNS" + str(idx + 1)] = dns["address"] if ip["dns_search"]: ifcfg["DOMAIN"] = " ".join(ip["dns_search"]) if ip["auto6"]: ifcfg["IPV6INIT"] = "yes" ifcfg["IPV6_AUTOCONF"] = "yes" elif addrs6: ifcfg["IPV6INIT"] = "yes" ifcfg["IPV6_AUTOCONF"] = "no" else: ifcfg["IPV6INIT"] = "no" if addrs6: ifcfg["IPV6ADDR"] = ( addrs6[0]["address"] + "/" + str(addrs6[0]["prefix"]) ) if len(addrs6) > 1: ifcfg["IPV6ADDR_SECONDARIES"] = " ".join( [ addr["address"] + "/" + str(addr["prefix"]) for addr in addrs6[1:] ] ) if ip["gateway6"] is not None: ifcfg["IPV6_DEFAULTGW"] = ip["gateway6"] if ip["auto_gateway"] is not None: if ip["auto_gateway"]: ifcfg["DEFROUTE"] = "yes" else: ifcfg["DEFROUTE"] = "no" if ip["route_metric4"] is not None and ip["route_metric4"] >= 0: ifcfg["METRIC"] = str(ip["route_metric4"]) route4 = [] route6 = [] for r in ip["route"]: line = r["network"] + "/" + str(r["prefix"]) if r["gateway"]: line += " via " + r["gateway"] if connection["interface_name"]: line += " dev " + connection["interface_name"] else: warn_fcn( "The connection {0} does not specify an interface name. " "Therefore, the route to {1}/{2} will be configured without " "the output device and the kernel will choose it " "automatically which might result in an unwanted device being " "used. To avoid this, specify `interface_name` in the " "connection appropriately.".format( connection["name"], r["network"], r["prefix"] ), ) if r["metric"] != -1: line += " metric " + str(r["metric"]) if r["family"] == socket.AF_INET: route4.append(line) else: route6.append(line) route4_file = cls._ifcfg_route_merge( route4, ip["route_append_only"] and content_current, content_current["route"] if content_current else None, ) route6_file = cls._ifcfg_route_merge( route6, ip["route_append_only"] and content_current, content_current["route6"] if content_current else None, ) if ip["rule_append_only"] and content_current: rule4_file = content_current["rule"] rule6_file = content_current["rule6"] for key in list(ifcfg.keys()): v = ifcfg[key] if v is None: del ifcfg[key] continue if isinstance(v, bool): ifcfg[key] = "yes" if v else "no" return { "ifcfg": ifcfg, "keys": keys_file, "route": route4_file, "route6": route6_file, "rule": rule4_file, "rule6": rule6_file, } @classmethod def ifcfg_parse_line(cls, line): r1 = getattr(cls, "_re_parse_line1", None) if r1 is None: r1 = re.compile("^[ \t]*([a-zA-Z_][a-zA-Z_0-9]*)=(.*)$") cls._re_parse_line1 = r1 cls._shlex = shlex m = r1.match(line) if not m: return None key = m.group(1) val = m.group(2) val = val.rstrip() # shlex isn't up to the task of parsing shell. Whatever, # we can only parse shell to a certain degree and this is # good enough for now. try: c = list(cls._shlex.split(val, comments=True, posix=True)) except Exception: return None if len(c) != 1: return None return (key, c[0]) @classmethod def ifcfg_parse(cls, content): if content is None: return None ifcfg = {} for line in content.splitlines(): val = cls.ifcfg_parse_line(line) if val: ifcfg[val[0]] = val[1] return ifcfg @classmethod def content_from_dict(cls, ifcfg_all, file_type=None, header=None): content = {} for file_type in cls._file_types(file_type): h = ifcfg_all[file_type] if file_type == "ifcfg": if header is not None: s = header + "\n" else: s = "" for key in sorted(h.keys()): value = h[key] if not cls.KeyValid(key): raise MyError("invalid ifcfg key %s" % (key)) if value is not None: s += key + "=" + cls.ValueEscape(value) + "\n" content[file_type] = s else: content[file_type] = h return content @classmethod def content_to_dict(cls, content, file_type=None): ifcfg_all = {} for file_type in cls._file_types(file_type): ifcfg_all[file_type] = cls.ifcfg_parse(content[file_type]) return ifcfg_all @classmethod def content_from_file(cls, name, file_type=None): """ Return dictionary with all file contents for an initscripts profile """ content = {} for file_type in cls._file_types(file_type): path = cls.ifcfg_path(name, file_type) try: with open(path, "r") as content_file: i_content = content_file.read() except Exception: i_content = None content[file_type] = i_content return content @classmethod def content_to_file(cls, name, content, file_type=None): for file_type in cls._file_types(file_type): path = cls.ifcfg_path(name, file_type) h = content[file_type] if h is None: try: os.unlink(path) except OSError as e: if e.errno != errno.ENOENT: raise else: with open(path, "w") as text_file: text_file.write(h) @classmethod def connection_seems_active(cls, name, run_env): # we don't know whether a ifcfg file is currently active, # and we also don't know which. # # Do a very basic guess based on whether the interface # is in operstate "up". # # But first we need to find the interface name. Do # some naive parsing and check for DEVICE setting. content = cls.content_from_file(name, "ifcfg") if content["ifcfg"] is not None: content = cls.ifcfg_parse(content["ifcfg"]) else: content = {} if "DEVICE" not in content: return None path = "/sys/class/net/" + content["DEVICE"] + "/operstate" try: with open(path, "r") as content_file: i_content = str(content_file.read()) except Exception: return None if i_content.strip() != "up": # For the active bonding/bridge connection, when all the port connection # profiles are brought down firstly, then the operstate of the controller # device will change into "down" automatically, which denotes missing the # carrier for the controller device. However, the connection for the # controller device stays active in such a situation. try: _unused_, out, _ignored_ = run_env.run_command( ["ip", "address", "show", content["DEVICE"]], "utf-8", ) except Exception: return None if "inet" in out: if out.count("inet") == 1 and "inet6 fe80" in out: return False else: return True else: return False return True ############################################################################### class NMUtil: def __init__(self, nmclient=None): if nmclient is None: nmclient = Util.NM().Client.new(None) self.nmclient = nmclient def setting_ip_config_get_routes(self, s_ip): if s_ip is not None: for i in range(0, s_ip.get_num_routes()): yield s_ip.get_route(i) def connection_ensure_setting(self, connection, setting_type): setting = connection.get_setting(setting_type) if not setting: setting = setting_type() connection.add_setting(setting) return setting def device_is_controller_type(self, dev): if dev: NM = Util.NM() GObject = Util.GObject() if ( GObject.type_is_a(dev, NM.DeviceBond) or GObject.type_is_a(dev, NM.DeviceBridge) or GObject.type_is_a(dev, NM.DeviceTeam) ): return True return False def active_connection_list(self, connections=None, black_list=None): active_cons = self.nmclient.get_active_connections() if connections: connections = set(connections) active_cons = [ ac for ac in active_cons if ac.get_connection() in connections ] if black_list: active_cons = [ac for ac in active_cons if ac not in black_list] return list(active_cons) def connection_list( self, name=None, uuid=None, black_list=None, black_list_names=None, black_list_uuids=None, ): cons = self.nmclient.get_connections() if name is not None: cons = [c for c in cons if c.get_id() == name] if uuid is not None: cons = [c for c in cons if c.get_uuid() == uuid] if black_list: cons = [c for c in cons if c not in black_list] if black_list_uuids: cons = [c for c in cons if c.get_uuid() not in black_list_uuids] if black_list_names: cons = [c for c in cons if c.get_id() not in black_list_names] cons = list(cons) def _cmp(a, b): s_a = a.get_setting_connection() s_b = b.get_setting_connection() if not s_a and not s_b: return 0 if not s_a: return 1 if not s_b: return -1 t_a = s_a.get_timestamp() t_b = s_b.get_timestamp() if t_a == t_b: return 0 if t_a <= 0: return 1 if t_b <= 0: return -1 return cmp(t_a, t_b) if Util.PY3: # functools.cmp_to_key does not exist in Python 2.6 cons.sort(key=functools.cmp_to_key(_cmp)) else: cons.sort(cmp=_cmp) return cons def connection_compare( self, con_a, con_b, normalize_a=False, normalize_b=False, compare_flags=None ): NM = Util.NM() if normalize_a: con_a = NM.SimpleConnection.new_clone(con_a) try: con_a.normalize() except Exception: pass if normalize_b: con_b = NM.SimpleConnection.new_clone(con_b) try: con_b.normalize() except Exception: pass if compare_flags is None: compare_flags = NM.SettingCompareFlags.IGNORE_TIMESTAMP return con_a.compare(con_b, compare_flags) def connection_is_active(self, con): NM = Util.NM() for ac in self.active_connection_list(connections=[con]): if ( ac.get_state() >= NM.ActiveConnectionState.ACTIVATING and ac.get_state() <= NM.ActiveConnectionState.ACTIVATED ): return True return False def connection_create(self, connections, idx, connection_current=None): NM = Util.NM() connection = connections[idx] con = NM.SimpleConnection.new() s_con = self.connection_ensure_setting(con, NM.SettingConnection) s_con.set_property(NM.SETTING_CONNECTION_ID, connection["name"]) s_con.set_property(NM.SETTING_CONNECTION_UUID, connection["nm.uuid"]) s_con.set_property(NM.SETTING_CONNECTION_AUTOCONNECT, connection["autoconnect"]) s_con.set_property( NM.SETTING_CONNECTION_AUTOCONNECT_RETRIES, connection["autoconnect_retries"] ) s_con.set_property( NM.SETTING_CONNECTION_INTERFACE_NAME, connection["interface_name"] ) if connection["type"] == "ethernet": s_con.set_property( NM.SETTING_CONNECTION_TYPE, NM.SETTING_WIRED_SETTING_NAME ) s_wired = self.connection_ensure_setting(con, NM.SettingWired) s_wired.set_property(NM.SETTING_WIRED_MAC_ADDRESS, connection["mac"]) elif connection["type"] == "infiniband": s_con.set_property( NM.SETTING_CONNECTION_TYPE, NM.SETTING_INFINIBAND_SETTING_NAME ) s_infiniband = self.connection_ensure_setting(con, NM.SettingInfiniband) s_infiniband.set_property( NM.SETTING_INFINIBAND_MAC_ADDRESS, connection["mac"] ) s_infiniband.set_property( NM.SETTING_INFINIBAND_TRANSPORT_MODE, connection["infiniband"]["transport_mode"], ) if connection["infiniband"]["p_key"] is not None: s_infiniband.set_property( NM.SETTING_INFINIBAND_P_KEY, connection["infiniband"]["p_key"] ) if connection["parent"]: s_infiniband.set_property( NM.SETTING_INFINIBAND_PARENT, ArgUtil.connection_find_controller( connection["parent"], connections, idx ), ) elif connection["type"] == "bridge": s_con.set_property( NM.SETTING_CONNECTION_TYPE, NM.SETTING_BRIDGE_SETTING_NAME ) s_bridge = self.connection_ensure_setting(con, NM.SettingBridge) s_bridge.set_property(NM.SETTING_BRIDGE_STP, False) elif connection["type"] == "bond": s_con.set_property(NM.SETTING_CONNECTION_TYPE, NM.SETTING_BOND_SETTING_NAME) s_bond = self.connection_ensure_setting(con, NM.SettingBond) s_bond.add_option("mode", connection["bond"]["mode"]) for option, value in connection["bond"].items(): if value is None: continue if option in ["all_ports_active", "use_carrier", "tlb_dynamic_lb"]: value = int(value) if option in ["all_ports_active", "packets_per_port"]: # wokeignore:rule=slave option = option.replace("port", "slave") s_bond.add_option(option, str(value)) elif connection["type"] == "team": s_con.set_property(NM.SETTING_CONNECTION_TYPE, NM.SETTING_TEAM_SETTING_NAME) # wokeignore:rule=dummy elif connection["type"] == "dummy": s_con.set_property( # wokeignore:rule=dummy NM.SETTING_CONNECTION_TYPE, NM.SETTING_DUMMY_SETTING_NAME, ) elif connection["type"] == "vlan": s_con.set_property(NM.SETTING_CONNECTION_TYPE, NM.SETTING_VLAN_SETTING_NAME) s_vlan = self.connection_ensure_setting(con, NM.SettingVlan) s_vlan.set_property(NM.SETTING_VLAN_ID, connection["vlan"]["id"]) s_vlan.set_property( NM.SETTING_VLAN_PARENT, ArgUtil.connection_find_controller_uuid( connection["parent"], connections, idx ), ) elif connection["type"] == "macvlan": s_con.set_property( NM.SETTING_CONNECTION_TYPE, NM.SETTING_MACVLAN_SETTING_NAME ) # convert mode name to a number (which is actually expected by nm) mode = connection["macvlan"]["mode"] try: mode_id = int(getattr(NM.SettingMacvlanMode, mode.upper())) except AttributeError: raise MyError("Macvlan mode '%s' is not recognized" % (mode)) s_macvlan = self.connection_ensure_setting(con, NM.SettingMacvlan) s_macvlan.set_property(NM.SETTING_MACVLAN_MODE, mode_id) s_macvlan.set_property( NM.SETTING_MACVLAN_PROMISCUOUS, connection["macvlan"]["promiscuous"] ) s_macvlan.set_property(NM.SETTING_MACVLAN_TAP, connection["macvlan"]["tap"]) s_macvlan.set_property( NM.SETTING_MACVLAN_PARENT, ArgUtil.connection_find_controller( connection["parent"], connections, idx ), ) elif connection["type"] == "wireless": s_con.set_property( NM.SETTING_CONNECTION_TYPE, NM.SETTING_WIRELESS_SETTING_NAME ) s_wireless = self.connection_ensure_setting(con, NM.SettingWireless) s_wireless.set_property( NM.SETTING_WIRELESS_SSID, Util.GLib().Bytes.new(connection["wireless"]["ssid"].encode("utf-8")), ) s_wireless_sec = self.connection_ensure_setting( con, NM.SettingWirelessSecurity ) s_wireless_sec.set_property( NM.SETTING_WIRELESS_SECURITY_KEY_MGMT, connection["wireless"]["key_mgmt"], ) if ( connection["wireless"]["key_mgmt"] == "wpa-psk" or connection["wireless"]["key_mgmt"] == "sae" ): s_wireless_sec.set_property( NM.SETTING_WIRELESS_SECURITY_PSK, connection["wireless"]["password"] ) else: raise MyError("unsupported type %s" % (connection["type"])) if connection["cloned_mac"] != "default": if connection["type"] == "wireless": s_wireless = self.connection_ensure_setting(con, NM.SettingWireless) s_wireless.set_property( NM.SETTING_WIRELESS_CLONED_MAC_ADDRESS, connection["cloned_mac"] ) else: s_wired = self.connection_ensure_setting(con, NM.SettingWired) s_wired.set_property( NM.SETTING_WIRED_CLONED_MAC_ADDRESS, connection["cloned_mac"] ) if "ethernet" in connection: if connection["ethernet"]["autoneg"] is not None: s_wired = self.connection_ensure_setting(con, NM.SettingWired) s_wired.set_property( NM.SETTING_WIRED_AUTO_NEGOTIATE, connection["ethernet"]["autoneg"] ) s_wired.set_property( NM.SETTING_WIRED_DUPLEX, connection["ethernet"]["duplex"] ) s_wired.set_property( NM.SETTING_WIRED_SPEED, connection["ethernet"]["speed"] ) if hasattr(NM, "SettingEthtool"): s_ethtool = self.connection_ensure_setting(con, NM.SettingEthtool) for feature, setting in connection["ethtool"]["features"].items(): nm_feature = nm_provider.get_nm_ethtool_feature(feature) if setting is None: if not nm_feature: continue val = NM.Ternary.DEFAULT elif setting: val = NM.Ternary.TRUE else: val = NM.Ternary.FALSE if not hasattr(s_ethtool, "option_set"): s_ethtool.set_feature(nm_feature, val) elif val == NM.Ternary.DEFAULT: s_ethtool.option_set(nm_feature, None) else: s_ethtool.option_set_boolean(nm_feature, val) for coalesce, setting in connection["ethtool"]["coalesce"].items(): nm_coalesce = nm_provider.get_nm_ethtool_coalesce(coalesce) if nm_coalesce: if setting is None: s_ethtool.option_set(nm_coalesce, None) else: s_ethtool.option_set_uint32(nm_coalesce, int(setting)) for ring, setting in connection["ethtool"]["ring"].items(): nm_ring = nm_provider.get_nm_ethtool_ring(ring) if nm_ring: if setting is None: s_ethtool.option_set(nm_ring, None) else: s_ethtool.option_set_uint32(nm_ring, setting) # * When users did not specify any ethtool configuration, this module # will generate an default `NM.SettingEthtool` object and pass it to # NetworkManager. But NetworkManager cannot serialize this when using the # ifcfg plugin but treats this as no `NM.SettingEthtool` object. # * The following `NM.SimpleConnection.compare()` will therefore identify a # difference in the configuration. # * To workaround this, remove the default NM.SettingEthtool object. if s_ethtool.compare(NM.SettingEthtool.new(), NM.SettingCompareFlags.EXACT): con.remove_setting(NM.SettingEthtool) if connection["mtu"]: if connection["type"] == "infiniband": s_infiniband = self.connection_ensure_setting(con, NM.SettingInfiniband) s_infiniband.set_property(NM.SETTING_INFINIBAND_MTU, connection["mtu"]) else: s_wired = self.connection_ensure_setting(con, NM.SettingWired) s_wired.set_property(NM.SETTING_WIRED_MTU, connection["mtu"]) if connection["controller"] is not None: s_con.set_property( # wokeignore:rule=slave NM.SETTING_CONNECTION_SLAVE_TYPE, connection["port_type"], ) s_con.set_property( # wokeignore:rule=master NM.SETTING_CONNECTION_MASTER, ArgUtil.connection_find_controller_uuid( connection["controller"], connections, idx ), ) else: if connection["zone"]: s_con.set_property(NM.SETTING_CONNECTION_ZONE, connection["zone"]) ip = connection["ip"] s_ip4 = self.connection_ensure_setting(con, NM.SettingIP4Config) s_ip6 = self.connection_ensure_setting(con, NM.SettingIP6Config) s_ip4.set_property(NM.SETTING_IP_CONFIG_METHOD, "auto") s_ip6.set_property(NM.SETTING_IP_CONFIG_METHOD, "auto") addrs4 = [a for a in ip["address"] if a["family"] == socket.AF_INET] addrs6 = [a for a in ip["address"] if a["family"] == socket.AF_INET6] is_ipv4_configured = False if ip["dhcp4"]: s_ip4.set_property(NM.SETTING_IP_CONFIG_METHOD, "auto") s_ip4.set_property( NM.SETTING_IP_CONFIG_DHCP_SEND_HOSTNAME, ip["dhcp4_send_hostname"] is not False, ) is_ipv4_configured = True elif addrs4: s_ip4.set_property(NM.SETTING_IP_CONFIG_METHOD, "manual") is_ipv4_configured = True else: s_ip4.set_property(NM.SETTING_IP_CONFIG_METHOD, "disabled") for a in addrs4: s_ip4.add_address( NM.IPAddress.new(a["family"], a["address"], a["prefix"]) ) if ip["gateway4"] is not None: s_ip4.set_property(NM.SETTING_IP_CONFIG_GATEWAY, ip["gateway4"]) if ip["route_metric4"] is not None and ip["route_metric4"] >= 0: s_ip4.set_property( NM.SETTING_IP_CONFIG_ROUTE_METRIC, ip["route_metric4"] ) for nameserver in ip["dns"]: if nameserver["family"] == socket.AF_INET: s_ip4.add_dns(nameserver["address"]) # NetworkManager only allows to configure `ipv4.dns-search` setting when # IPv4 is enabled if is_ipv4_configured: for search_domain in ip["dns_search"]: s_ip4.add_dns_search(search_domain) # NetworkManager ifcfg plguin will discard empty dns option which # cause follow up NM.Connection.compare() raise false alarm # Use False here to ask NetworkManager remove dns option completely instead # of keeping an empty list s_ip4.clear_dns_options(False) for option in ip["dns_options"]: s_ip4.add_dns_option(option) if ip["dns_priority"] is not None: s_ip4.set_property( NM.SETTING_IP_CONFIG_DNS_PRIORITY, ip["dns_priority"] ) is_ipv6_configured = False if ip["ipv6_disabled"]: s_ip6.set_property(NM.SETTING_IP_CONFIG_METHOD, "disabled") elif ip["auto6"]: s_ip6.set_property(NM.SETTING_IP_CONFIG_METHOD, "auto") is_ipv6_configured = True elif addrs6: s_ip6.set_property(NM.SETTING_IP_CONFIG_METHOD, "manual") is_ipv6_configured = True else: # we should not set "ipv6.method=ignore". "ignore" is a legacy mode # and not really useful. Instead, we should set "link-local" here. # # But that fix is a change in behavior for the role, so it needs special # care. s_ip6.set_property(NM.SETTING_IP_CONFIG_METHOD, "ignore") for a in addrs6: s_ip6.add_address( NM.IPAddress.new(a["family"], a["address"], a["prefix"]) ) if ip["gateway6"] is not None: s_ip6.set_property(NM.SETTING_IP_CONFIG_GATEWAY, ip["gateway6"]) # Mapping of wait_ip values to the may-fail settings for IPv4 and IPv6 may_fail_mapping = { "any": (True, True), "ipv4": (False, True), "ipv6": (True, False), "ipv4+ipv6": (False, False), } may_fail_ipv4, may_fail_ipv6 = may_fail_mapping.get( ip["wait_ip"], (True, True) ) s_ip4.set_property(NM.SETTING_IP_CONFIG_MAY_FAIL, may_fail_ipv4) s_ip6.set_property(NM.SETTING_IP_CONFIG_MAY_FAIL, may_fail_ipv6) if ip["route_metric6"] is not None and ip["route_metric6"] >= 0: s_ip6.set_property( NM.SETTING_IP_CONFIG_ROUTE_METRIC, ip["route_metric6"] ) if ip["auto_gateway"] is not None: if ip["auto_gateway"]: s_ip6.set_property(NM.SETTING_IP_CONFIG_NEVER_DEFAULT, False) s_ip4.set_property(NM.SETTING_IP_CONFIG_NEVER_DEFAULT, False) else: s_ip6.set_property(NM.SETTING_IP_CONFIG_NEVER_DEFAULT, True) s_ip4.set_property(NM.SETTING_IP_CONFIG_NEVER_DEFAULT, True) s_ip4.set_property( NM.SETTING_IP_CONFIG_IGNORE_AUTO_DNS, bool(ip["ipv4_ignore_auto_dns"]) ) s_ip6.set_property( NM.SETTING_IP_CONFIG_IGNORE_AUTO_DNS, bool(ip["ipv6_ignore_auto_dns"]) ) for nameserver in ip["dns"]: if nameserver["family"] == socket.AF_INET6: s_ip6.add_dns(nameserver["address"]) # NetworkManager only allows to configure `ipv6.dns-search` setting when # IPv6 is enabled if is_ipv6_configured: for search_domain in ip["dns_search"]: s_ip6.add_dns_search(search_domain) # NetworkManager ifcfg plguin will discard empty dns option which # cause follow up NM.Connection.compare() raise false alarm # Use False here to ask NetworkManager remove dns option completely instead # of keeping an empty list s_ip6.clear_dns_options(False) for option in ip["dns_options"]: s_ip6.add_dns_option(option) if ip["dns_priority"] is not None: s_ip6.set_property( NM.SETTING_IP_CONFIG_DNS_PRIORITY, ip["dns_priority"] ) if ip["route_append_only"] and connection_current: for r in self.setting_ip_config_get_routes( connection_current.get_setting(NM.SettingIP4Config) ): s_ip4.add_route(r) for r in self.setting_ip_config_get_routes( connection_current.get_setting(NM.SettingIP6Config) ): s_ip6.add_route(r) for r in ip["route"]: new_route = NM.IPRoute.new( r["family"], r["network"], r["prefix"], r["gateway"], r["metric"] ) if r["type"]: NM.IPRoute.set_attribute( new_route, "type", Util.GLib().Variant("s", r["type"]) ) if r["table"]: NM.IPRoute.set_attribute( new_route, "table", Util.GLib().Variant.new_uint32(r["table"]) ) if r["src"]: NM.IPRoute.set_attribute( new_route, "src", Util.GLib().Variant.new_string(r["src"]) ) if r["family"] == socket.AF_INET: s_ip4.add_route(new_route) else: s_ip6.add_route(new_route) for routing_rule in ip["routing_rule"]: nm_routing_rule = NM.IPRoutingRule.new(routing_rule["family"]) NM.IPRoutingRule.set_priority(nm_routing_rule, routing_rule["priority"]) # check the link below for the enum value of supported action # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/uapi/linux/fib_rules.h?id=f443e374ae131c168a065ea1748feac6b2e76613#n88 action_ids = { "to-table": 1, "blackhole": 6, "prohibit": 7, "unreachable": 8, } NM.IPRoutingRule.set_action( nm_routing_rule, action_ids[routing_rule["action"]] ) if routing_rule["dport"]: NM.IPRoutingRule.set_destination_port( nm_routing_rule, routing_rule["dport"][0], routing_rule["dport"][1], ) # In NM, when user specifies `from 0.0.0.0/0`` or `from ::/0` in a # routing rule, NM treats it as if the `from` setting is not specified. if routing_rule["from"] and routing_rule["from"]["prefix"]: NM.IPRoutingRule.set_from( nm_routing_rule, routing_rule["from"]["address"], routing_rule["from"]["prefix"], ) if routing_rule["fwmark"]: NM.IPRoutingRule.set_fwmark( nm_routing_rule, routing_rule["fwmark"], routing_rule["fwmask"] ) if routing_rule["iif"]: NM.IPRoutingRule.set_iifname(nm_routing_rule, routing_rule["iif"]) NM.IPRoutingRule.set_invert(nm_routing_rule, routing_rule["invert"]) if routing_rule["ipproto"]: NM.IPRoutingRule.set_ipproto( nm_routing_rule, routing_rule["ipproto"] ) if routing_rule["oif"]: NM.IPRoutingRule.set_oifname(nm_routing_rule, routing_rule["oif"]) if routing_rule["sport"]: NM.IPRoutingRule.set_source_port( nm_routing_rule, routing_rule["sport"][0], routing_rule["sport"][1], ) if routing_rule["suppress_prefixlength"] is not None: NM.IPRoutingRule.set_suppress_prefixlength( nm_routing_rule, routing_rule["suppress_prefixlength"] ) if routing_rule["table"]: NM.IPRoutingRule.set_table(nm_routing_rule, routing_rule["table"]) # In NM, when user specifies `to 0.0.0.0/0`` or `to ::/0` in a # routing rule, NM treats it as if the `to` setting is not specified. if routing_rule["to"] and routing_rule["to"]["prefix"]: NM.IPRoutingRule.set_to( nm_routing_rule, routing_rule["to"]["address"], routing_rule["to"]["prefix"], ) if routing_rule["tos"]: NM.IPRoutingRule.set_tos(nm_routing_rule, routing_rule["tos"]) if routing_rule["uid"]: NM.IPRoutingRule.set_uid_range( nm_routing_rule, routing_rule["uid"][0], routing_rule["uid"][1], ) if routing_rule["family"] == socket.AF_INET: s_ip4.add_routing_rule(nm_routing_rule) else: s_ip6.add_routing_rule(nm_routing_rule) if connection["ieee802_1x"]: s_8021x = self.connection_ensure_setting(con, NM.Setting8021x) s_8021x.set_property( NM.SETTING_802_1X_EAP, [connection["ieee802_1x"]["eap"]] ) s_8021x.set_property( NM.SETTING_802_1X_IDENTITY, connection["ieee802_1x"]["identity"] ) s_8021x.set_property( NM.SETTING_802_1X_PRIVATE_KEY, Util.path_to_glib_bytes(connection["ieee802_1x"]["private_key"]), ) if connection["ieee802_1x"]["private_key_password"]: s_8021x.set_property( NM.SETTING_802_1X_PRIVATE_KEY_PASSWORD, connection["ieee802_1x"]["private_key_password"], ) if connection["ieee802_1x"]["private_key_password_flags"]: s_8021x.set_secret_flags( NM.SETTING_802_1X_PRIVATE_KEY_PASSWORD, Util.NM().SettingSecretFlags( Util.convert_passwd_flags_nm( connection["ieee802_1x"]["private_key_password_flags"] ), ), ) s_8021x.set_property( NM.SETTING_802_1X_CLIENT_CERT, Util.path_to_glib_bytes(connection["ieee802_1x"]["client_cert"]), ) if connection["ieee802_1x"]["ca_cert"]: s_8021x.set_property( NM.SETTING_802_1X_CA_CERT, Util.path_to_glib_bytes(connection["ieee802_1x"]["ca_cert"]), ) if connection["ieee802_1x"]["ca_path"]: s_8021x.set_property( NM.SETTING_802_1X_CA_PATH, connection["ieee802_1x"]["ca_path"], ) s_8021x.set_property( NM.SETTING_802_1X_SYSTEM_CA_CERTS, connection["ieee802_1x"]["system_ca_certs"], ) if connection["ieee802_1x"]["domain_suffix_match"]: s_8021x.set_property( NM.SETTING_802_1X_DOMAIN_SUFFIX_MATCH, connection["ieee802_1x"]["domain_suffix_match"], ) if connection["match"]: s_match = self.connection_ensure_setting(con, NM.SettingMatch) s_match.set_property(NM.SETTING_MATCH_PATH, connection["match"]["path"]) try: con.normalize() except Exception as e: raise MyError("created connection failed to normalize: %s" % (e)) return con def connection_add(self, con, timeout=10): def add_cb(client, result, cb_args): con = None try: con = client.add_connection_finish(result) except Exception as e: if Util.error_is_cancelled(e): return cb_args["error"] = str(e) cb_args["con"] = con Util.GMainLoop().quit() cancellable = Util.create_cancellable() cb_args = {} self.nmclient.add_connection_async(con, True, cancellable, add_cb, cb_args) if not Util.GMainLoop_run(timeout): cancellable.cancel() raise MyError("failure to add connection: %s" % ("timeout")) if not cb_args.get("con", None): raise MyError( "failure to add connection: %s" % (cb_args.get("error", "unknown error")) ) return cb_args["con"] def connection_update(self, con, con_new, timeout=10): con.replace_settings_from_connection(con_new) def update_cb(connection, result, cb_args): success = False try: success = connection.commit_changes_finish(result) except Exception as e: if Util.error_is_cancelled(e): return cb_args["error"] = str(e) cb_args["success"] = success Util.GMainLoop().quit() cancellable = Util.create_cancellable() cb_args = {} con.commit_changes_async(True, cancellable, update_cb, cb_args) if not Util.GMainLoop_run(timeout): cancellable.cancel() raise MyError("failure to update connection: %s" % ("timeout")) if not cb_args.get("success", False): raise MyError( "failure to update connection: %s" % (cb_args.get("error", "unknown error")) ) return True def create_checkpoint(self, timeout): """Create a new checkpoint""" checkpoint = Util.call_async_method( self.nmclient, "checkpoint_create", [ [], # devices, empty list is all devices timeout, Util.NM().CheckpointCreateFlags.DELETE_NEW_CONNECTIONS | Util.NM().CheckpointCreateFlags.DISCONNECT_NEW_DEVICES, ], ) if checkpoint: return checkpoint.get_path() return None def destroy_checkpoint(self, path): """Destroy the specified checkpoint""" Util.call_async_method(self.nmclient, "checkpoint_destroy", [path]) def rollback_checkpoint(self, path): """Rollback the specified checkpoint""" Util.call_async_method( self.nmclient, "checkpoint_rollback", [path], mainloop_timeout=DEFAULT_ACTIVATION_TIMEOUT, ) def connection_activate(self, connection, timeout=15, wait_time=None): already_retried = False while True: def activate_cb(client, result, cb_args): active_connection = None try: active_connection = client.activate_connection_finish(result) except Exception as e: if Util.error_is_cancelled(e): return cb_args["error"] = str(e) cb_args["active_connection"] = active_connection Util.GMainLoop().quit() cancellable = Util.create_cancellable() cb_args = {} self.nmclient.activate_connection_async( connection, None, None, cancellable, activate_cb, cb_args ) if not Util.GMainLoop_run(timeout): cancellable.cancel() raise MyError("failure to activate connection: %s" % ("timeout")) if cb_args.get("active_connection", None): ac = cb_args["active_connection"] self.connection_activate_wait(ac, wait_time) return ac # there is a bug in NetworkManager, that the connection # might already be in the process of activating. In that # case, NM would reject the activation request with # "Connection '$PROFILE' is not available on the device $DEV # at this time." # # Try to work around it by waiting a bit and retrying. if already_retried: raise MyError( "failure to activate connection: %s" % (cb_args.get("error", "unknown error")) ) already_retried = True time.sleep(1) def connection_activate_wait(self, ac, wait_time): if not wait_time: return NM = Util.NM() state = ac.get_state() if state == NM.ActiveConnectionState.ACTIVATED: return if state != NM.ActiveConnectionState.ACTIVATING: raise MyError("activation is in unexpected state '%s'" % (state)) def check_activated(ac, dev): ac_state = ac.get_state() # the state reason was for active-connection was introduced # in NM 1.8 API. Work around for older library version. try: ac_reason = ac.get_state_reason() except AttributeError: ac_reason = None if dev: dev_state = dev.get_state() if ac_state == NM.ActiveConnectionState.ACTIVATING: if ( self.device_is_controller_type(dev) and dev_state >= NM.DeviceState.IP_CONFIG and dev_state <= NM.DeviceState.ACTIVATED ): # controller connections qualify as activated once they # reach IP-Config state. That is because they may # wait for port devices to attach return True, None # fall through elif ac_state == NM.ActiveConnectionState.ACTIVATED: return True, None elif ac_state == NM.ActiveConnectionState.DEACTIVATED: if ( not dev or ( ac_reason is not None and ac_reason != NM.ActiveConnectionStateReason.DEVICE_DISCONNECTED ) or dev.get_active_connection() is not ac ): return ( True, ( (ac_reason.value_nick if ac_reason else None) or "unknown reason" ), ) # the state of the active connection is not very helpful. # see if the device-state is better. if ( dev_state <= NM.DeviceState.DISCONNECTED or dev_state > NM.DeviceState.DEACTIVATING ): return ( True, ( dev.get_state_reason().value_nick or (ac_reason.value_nick if ac_reason else None) or "unknown reason" ), ) # fall through, wait longer for a better state reason. # wait longer. return False, None dev = Util.first(ac.get_devices()) complete, failure_reason = check_activated(ac, dev) if not complete: cb_out = [] def check_activated_cb(): complete, failure_reason = check_activated(ac, dev) if complete: cb_out.append(failure_reason) Util.GMainLoop().quit() try: # 'state-changed' signal is 1.8 API. Workaround for # older libnm API version ac_id = ac.connect( "state-changed", lambda source, state, reason: check_activated_cb() ) except Exception: ac_id = None if dev: dev_id = dev.connect( "notify::state", lambda source, pspec: check_activated_cb() ) try: if not Util.GMainLoop_run(wait_time): raise MyError("connection not fully activated after timeout") finally: if dev: dev.handler_disconnect(dev_id) if ac_id is not None: ac.handler_disconnect(ac_id) failure_reason = cb_out[0] if failure_reason: raise MyError("connection not activated: %s" % (failure_reason)) def reapply(self, device, connection=None): version_id = 0 flags = 0 return Util.call_async_method( device, "reapply", [connection, version_id, flags] ) ############################################################################### class RunEnvironment(object): def __init__(self): self._check_mode = None @property def ifcfg_header(self): return None def log( self, connections, idx, severity, msg, is_changed=False, ignore_errors=False, warn_traceback=False, force_fail=False, ): raise NotImplementedError() def run_command(self, argv, encoding=None): raise NotImplementedError() def _check_mode_changed(self, old_check_mode, new_check_mode, connections): raise NotImplementedError() def check_mode_set(self, check_mode, connections=None): c = self._check_mode self._check_mode = check_mode if not ( (c is None and check_mode in [CheckMode.PREPARE]) or ( c == CheckMode.PREPARE and check_mode in [CheckMode.PRE_RUN, CheckMode.DRY_RUN] ) or (c == CheckMode.PRE_RUN and check_mode in [CheckMode.REAL_RUN]) or (c == CheckMode.REAL_RUN and check_mode in [CheckMode.DONE]) or (c == CheckMode.DRY_RUN and check_mode in [CheckMode.DONE]) ): raise AssertionError( "updating check_mode value from {0} into {1} is incorrect".format( c, check_mode ) ) self._check_mode_changed(c, check_mode, connections) class RunEnvironmentAnsible(RunEnvironment): ARGS = { "ignore_errors": {"required": False, "default": False, "type": "bool"}, "force_state_change": {"required": False, "default": False, "type": "bool"}, "provider": {"required": True, "type": "str"}, "connections": { "required": False, "default": [], "type": "list", "elements": "dict", }, "__header": {"required": True, "type": "str"}, "__debug_flags": {"required": False, "default": "", "type": "str"}, } def __init__(self): RunEnvironment.__init__(self) self._run_results = [] self._log_idx = 0 self.on_failure = None module = AnsibleModule(argument_spec=self.ARGS, supports_check_mode=True) self.module = module @property def ifcfg_header(self): return self.module.params["__header"] def run_command(self, argv, encoding=None): return self.module.run_command(argv, encoding=encoding) def _run_results_push(self, n_connections): c = [] for cc in range(0, n_connections + 1): c.append({"log": []}) self._run_results.append(c) @property def run_results(self): return self._run_results[-1] def _check_mode_changed(self, old_check_mode, new_check_mode, connections): if old_check_mode is None: self._run_results_push(len(connections)) elif old_check_mode == CheckMode.PREPARE: self._run_results_push(len(self.run_results) - 1) elif old_check_mode == CheckMode.PRE_RUN: # when switching from RRE_RUN to REAL_RUN, we drop the run-results # we just collected and reset to empty. The PRE_RUN succeeded. n_connections = len(self.run_results) - 1 del self._run_results[-1] self._run_results_push(n_connections) def log( self, connections, idx, severity, msg, is_changed=False, ignore_errors=False, warn_traceback=False, force_fail=False, ): if not idx >= -1: raise AssertionError("idx {0} is less than -1".format(idx)) self._log_idx += 1 self.run_results[idx]["log"].append((severity, msg, self._log_idx)) if severity == LogLevel.ERROR: if force_fail or not ignore_errors: self.fail_json( connections, "error: %s" % (msg), changed=is_changed, warn_traceback=warn_traceback, ) def _complete_kwargs_loglines(self, rr, connections, idx): if idx == len(connections): prefix = "#" else: c = connections[idx] prefix = "#%s, state:%s persistent_state:%s" % ( idx, c["state"], c["persistent_state"], ) prefix = prefix + (", '%s'" % (c["name"])) for severity, msg, idx in rr["log"]: yield ( idx, "[%03d] %s %s: %s" % (idx, LogLevel.fmt(severity), prefix, msg), severity, ) def _complete_kwargs(self, connections, kwargs, traceback_msg=None, fail=False): warning_logs = kwargs.get("warnings", []) debug_logs = [] loglines = [] for res in self._run_results: for idx, rr in enumerate(res): loglines.extend(self._complete_kwargs_loglines(rr, connections, idx)) loglines.sort(key=lambda log_line: log_line[0]) for idx, log_line, severity in loglines: debug_logs.append(log_line) if fail: warning_logs.append(log_line) elif severity >= LogLevel.WARN: warning_logs.append(log_line) if traceback_msg is not None: warning_logs.append(traceback_msg) kwargs["warnings"] = warning_logs stderr = "\n".join(debug_logs) + "\n" kwargs["stderr"] = stderr kwargs["_invocation"] = {"module_args": self.module.params} return kwargs def exit_json(self, connections, changed=False, **kwargs): kwargs["changed"] = changed self.module.exit_json(**self._complete_kwargs(connections, kwargs)) def fail_json( self, connections, msg, changed=False, warn_traceback=False, **kwargs ): if self.on_failure: self.on_failure() traceback_msg = None if warn_traceback: traceback_msg = "exception: %s" % (traceback.format_exc()) kwargs["msg"] = msg kwargs["changed"] = changed self.module.fail_json( **self._complete_kwargs(connections, kwargs, traceback_msg, fail=True) ) ############################################################################### class NmLogHandler(logging.Handler): def __init__(self, log_func, idx): self._log = log_func self._idx = idx super(NmLogHandler, self).__init__() def filter(self, record): return True def emit(self, record): self._log( self._idx, LogLevel.from_logging_level(record.levelno), record.getMessage() ) class Cmd(object): def __init__( self, run_env, connections_unvalidated, connection_validator, is_check_mode=False, ignore_errors=False, force_state_change=False, debug_flags="", ): self.run_env = run_env self.validate_one_type = None self._connections_unvalidated = connections_unvalidated self._connection_validator = connection_validator self._is_check_mode = is_check_mode self._ignore_errors = Util.boolean(ignore_errors) self._force_state_change = Util.boolean(force_state_change) self._connections = None self._connections_data = None self._check_mode = CheckMode.PREPARE self._is_changed_modified_system = False self._debug_flags = debug_flags def run_command(self, argv, encoding=None): return self.run_env.run_command(argv, encoding=encoding) @property def is_changed_modified_system(self): return self._is_changed_modified_system @property def connections(self): c = self._connections if c is None: try: c = self._connection_validator.validate(self._connections_unvalidated) except ValidationError as e: raise MyError("configuration error: %s" % (e)) self._connections = c return c @property def connections_data(self): c = self._connections_data if c is None: if self.check_mode not in [ CheckMode.DRY_RUN, CheckMode.PRE_RUN, CheckMode.REAL_RUN, ]: raise AssertionError( "invalid value {0} for self.check_mode".format(self.check_mode) ) c = [{"changed": False}] * len(self.connections) self._connections_data = c return c def connections_data_reset(self): for c in self.connections_data: c["changed"] = False def connections_data_set_changed(self, idx, changed=True): if self._check_mode not in [ CheckMode.PRE_RUN, CheckMode.DRY_RUN, CheckMode.REAL_RUN, ]: raise AssertionError( "invalid value {0} for self._check_mode".format(self._check_mode) ) if not changed: return self.connections_data[idx]["changed"] = changed if changed and self._check_mode in [CheckMode.DRY_RUN, CheckMode.REAL_RUN]: # we only do actual modifications during the REAL_RUN step. # And as a special exception, during the DRY_RUN step, which # is like REAL_RUN, except not not actually changing anything. self._is_changed_modified_system = True def log_debug(self, idx, msg): self.log(idx, LogLevel.DEBUG, msg) def log_info(self, idx, msg): self.log(idx, LogLevel.INFO, msg) def log_warn(self, idx, msg): self.log(idx, LogLevel.WARN, msg) def log_error(self, idx, msg, warn_traceback=False, force_fail=False): self.log( idx, LogLevel.ERROR, msg, warn_traceback=warn_traceback, force_fail=force_fail, ) def log_fatal(self, idx, msg, warn_traceback=False): self.log( idx, LogLevel.ERROR, msg, warn_traceback=warn_traceback, force_fail=True ) def log(self, idx, severity, msg, warn_traceback=False, force_fail=False): self.run_env.log( self.connections, idx, severity, msg, is_changed=self.is_changed_modified_system, ignore_errors=self.connection_ignore_errors(self.connections[idx]), warn_traceback=warn_traceback, force_fail=force_fail, ) @staticmethod def create(provider, **kwargs): if provider == "nm": return Cmd_nm(**kwargs) elif provider == "initscripts": return Cmd_initscripts(**kwargs) raise MyError("unsupported provider %s" % (provider)) def connection_force_state_change(self, connection): v = connection["force_state_change"] if v is not None: return v return self._force_state_change def connection_ignore_errors(self, connection): v = connection["ignore_errors"] if v is not None: return v return self._ignore_errors def connection_modified_earlier(self, idx): # for index @idx, check if any of the previous profiles [0..idx[ # modify the connection. con = self.connections[idx] if con["state"] not in ["up", "down"]: raise AssertionError( "connection state {0} not 'up' or 'down'".format(con["state"]) ) # also check, if the current profile is 'up' with a 'type' (which # possibly modifies the connection as well) if ( con["state"] == "up" and "type" in con and self.connections_data[idx]["changed"] ): return True for i in reversed(range(idx)): c = self.connections[i] if "name" not in c: continue if c["name"] != con["name"]: continue c_state = c["state"] c_pstate = c["persistent_state"] if c_state == "up" and "type" not in c: pass elif c_state == "down": return True elif c_pstate == "absent": return True elif c_state == "up" or c_pstate == "present": if self.connections_data[idx]["changed"]: return True return False @property def check_mode(self): return self._check_mode def check_mode_next(self): if self._check_mode == CheckMode.PREPARE: if self._is_check_mode: c = CheckMode.DRY_RUN else: c = CheckMode.PRE_RUN elif self.check_mode == CheckMode.PRE_RUN: self.connections_data_reset() c = CheckMode.REAL_RUN elif self._check_mode != CheckMode.DONE: c = CheckMode.DONE else: raise AssertionError( "invalid value {0} for self._check_mode".format(self._check_mode) ) self._check_mode = c self.run_env.check_mode_set(c) return c def run(self): self.run_env.check_mode_set(CheckMode.PREPARE, self.connections) for idx, connection in enumerate(self.connections): try: self._connection_validator.validate_connection_one( self.validate_one_type, self.connections, idx ) except ValidationError as e: self.log_fatal(idx, str(e)) self.run_prepare() while self.check_mode_next() != CheckMode.DONE: if self.check_mode == CheckMode.REAL_RUN: self.start_transaction() # Reasoning for this order: # For down/up profiles might need to be present, so do this first # Put profile down before removing it if necessary # To ensure up does not depend on anything that might be removed, # do it last for action in ("present", "down", "absent", "up"): for idx, connection in enumerate(self.connections): try: if action in connection["actions"]: if action == "absent": self.run_action_absent(idx) elif action == "present": self.run_action_present(idx) elif action == "up": self.run_action_up(idx) elif action == "down": self.run_action_down(idx) except Exception as error: if self.check_mode == CheckMode.REAL_RUN: self.rollback_transaction(idx, action, error) raise if self.check_mode == CheckMode.REAL_RUN: self.finish_transaction() def run_prepare(self): for idx, connection in enumerate(self.connections): if "type" in connection and connection["check_iface_exists"]: # when the profile is tied to a certain interface via # 'interface_name' and 'mac', check that such an interface # exists. # # This check has many flaws, as we don't check whether the # existing interface has the right device type. Also, there is # some ambiguity between the current MAC address and the # permanent MAC address. li_ifname = None if connection["interface_name"]: li_ifname = SysUtil.link_info_find(connection["interface_name"]) if not li_ifname: if connection["type"] == "ethernet": self.log_fatal( idx, "profile specifies interface_name '%s' but no such " "interface exists" % (connection["interface_name"]), ) elif connection["type"] == "infiniband": if connection["infiniband"]["p_key"] is None: self.log_fatal( idx, "profile specifies interface_name '%s' but no such " "infiniband interface exists" % (connection["interface_name"]), ) elif connection["mac"]: perm_address = li_ifname.get("perm-address", NULL_MAC) current_address = li_ifname.get("address", NULL_MAC) bond_port_perm_hwaddr = li_ifname.get( "bond-port-perm-hwaddr", NULL_MAC ) if (perm_address not in (NULL_MAC, connection["mac"])) or ( perm_address == NULL_MAC and connection["mac"] not in (current_address, bond_port_perm_hwaddr) ): self.log_fatal( idx, "profile specifies interface_name '%s' and mac '%s' " "but no such interface exists" % (connection["interface_name"], connection["mac"]), ) def start_transaction(self): """Hook before making changes""" def finish_transaction(self): """Hook for after all changes where made successfully""" def rollback_transaction(self, idx, action, error): """Hook if configuring a profile results in an error :param idx: Index of the connection that triggered the error :param action: Action that triggered the error :param error: The error :type idx: int :type action: str :type error: Exception """ self.log_warn( idx, "failure: %s (%s) [[%s]]" % (error, action, traceback.format_exc()) ) def on_failure(self): """Hook to do any cleanup on failure before exiting""" pass def run_action_absent(self, idx): raise NotImplementedError() def run_action_present(self, idx): raise NotImplementedError() def run_action_down(self, idx): raise NotImplementedError() def run_action_up(self, idx): raise NotImplementedError() ############################################################################### def version_to_tuple(version): """ Translates the dot-separated version string to a tuple :param version: The dot-separated version string :return: the version tuple """ version_list = version.split(".") version_tuple = tuple(map(int, version_list)) return version_tuple class Cmd_nm(Cmd): def __init__(self, **kwargs): Cmd.__init__(self, **kwargs) self._nmutil = None self.validate_one_type = ArgValidator_ListConnections.VALIDATE_ONE_MODE_NM self._checkpoint = None # pylint: disable=import-error, no-name-in-module from ansible.module_utils.network_lsr.nm import provider # noqa:E501 # pylint: enable=import-error, no-name-in-module self._nm_provider = provider.NetworkManagerProvider() @property def nmutil(self): if self._nmutil is None: try: nmclient = Util.NM().Client.new(None) except Exception as e: raise MyError("failure loading libnm library: %s" % (e)) self._nmutil = NMUtil(nmclient) return self._nmutil def run_prepare(self): Cmd.run_prepare(self) names = {} for idx, connection in enumerate(self.connections): self._check_ethtool_setting_support(idx, connection) if connection.get("ip", {}): for route in connection["ip"]["route"]: if route["type"]: # The special route type prohibit, blackhole and unreachable # are only supported in NM since version 1.36.0 nm_client_version = self._nm_provider.get_client_version() if version_to_tuple(nm_client_version) < (1, 36, 0): self.log_fatal( idx, "route type {0} is only supported in NM since 1.36.0 " "but the NM client version is {1}".format( route["type"], nm_client_version, ), ) name = connection["name"] if not name: if not connection["persistent_state"] == "absent": raise AssertionError( "persistent_state must be 'absent' not {0} when there is no connection 'name'".format( connection["persistent_state"] ) ) continue if name in names: exists = names[name]["nm.exists"] uuid = names[name]["nm.uuid"] else: c = Util.first(self.nmutil.connection_list(name=name)) exists = c is not None if c is not None: uuid = c.get_uuid() else: uuid = Util.create_uuid() names[name] = {"nm.exists": exists, "nm.uuid": uuid} connection["nm.exists"] = exists connection["nm.uuid"] = uuid def start_transaction(self): Cmd.start_transaction(self) if "disable-checkpoints" in self._debug_flags: pass else: self._checkpoint = self.nmutil.create_checkpoint( len(self.connections) * DEFAULT_ACTIVATION_TIMEOUT ) # On NetworkManger 1.18, If user switch from initscripts provider where # NM_CONTROLLED=no defined in ifcfg-ethX file, NetworkManager daemon will treat # that interface as strictly unmanaged, even the follow up deletion of # ifcfg-ethX file cannot change the NetworManager's unmanaged state of this # interface. This will prevent any follow up "nm" provider action on this # interface. To solve that, we instruct NetworkManager to reload the # configuration. if self._nm_provider.get_client_version().startswith("1.18."): self._nm_provider.reload_configuration() def rollback_transaction(self, idx, action, error): Cmd.rollback_transaction(self, idx, action, error) self.on_failure() def finish_transaction(self): Cmd.finish_transaction(self) if self._checkpoint: try: self.nmutil.destroy_checkpoint(self._checkpoint) finally: self._checkpoint = None def on_failure(self): if self._checkpoint: try: self.nmutil.rollback_checkpoint(self._checkpoint) finally: self._checkpoint = None def _check_ethtool_setting_support(self, idx, connection): """Check if SettingEthtool support is needed and available If any ethtool setting is specified, the SettingEthtool setting needs to be available. Also NM needs to know about each specified setting. Do not check if NM knows about any defaults """ NM = Util.NM() # If the profile is not completely specified, for example if only the # runtime change is specified, the ethtool subtree might be missing. # Then no checks are required. if "ethtool" not in connection: return ethtool_dict = { "features": nm_provider.get_nm_ethtool_feature, "coalesce": nm_provider.get_nm_ethtool_coalesce, "ring": nm_provider.get_nm_ethtool_ring, } for ethtool_key, nm_get_name_fcnt in ethtool_dict.items(): ethtool_settings = connection["ethtool"][ethtool_key] specified = dict( [(k, v) for k, v in ethtool_settings.items() if v is not None] ) if specified and not hasattr(NM, "SettingEthtool"): self.log_fatal( idx, "ethtool.%s specified but not supported by NM", specified ) for option in specified.keys(): nm_name = nm_get_name_fcnt(option) if not nm_name: self.log_fatal( idx, "ethtool %s setting %s specified " "but not supported by NM" % (ethtool_key, option), ) def run_action_absent(self, idx): name = self.connections[idx]["name"] profile_uuids = set() if name: black_list_names = [] else: # Delete all profiles except explicitly included black_list_names = ArgUtil.connection_get_non_absent_names(self.connections) for nm_profile in self._nm_provider.get_connections(): if name and nm_profile.get_id() != name: continue if nm_profile.get_id() not in black_list_names: profile_uuids.add(nm_profile.get_uuid()) if not profile_uuids: self.log_info(idx, "no connection matches '%s' to delete" % (name)) return logger = logging.getLogger() log_handler = NmLogHandler(self.log, idx) logger.addHandler(log_handler) timeout = self.connections[idx].get("wait") changed = False for profile_uuid in profile_uuids: changed |= self._nm_provider.volatilize_connection_by_uuid( profile_uuid, DEFAULT_TIMEOUT if timeout is None else timeout, self.check_mode != CheckMode.REAL_RUN, ) if changed: self.connections_data_set_changed(idx) logger.removeHandler(log_handler) def run_action_present(self, idx): connection = self.connections[idx] con_cur = Util.first( self.nmutil.connection_list( name=connection["name"], uuid=connection["nm.uuid"] ) ) if not connection.get("type"): # if the type is not specified, just check that the connection was # found if not con_cur: self.log_error( idx, "Connection not found on system and 'type' not specified" ) return con_new = self.nmutil.connection_create(self.connections, idx, con_cur) if con_cur is None: self.log_info( idx, "add connection %s, %s" % (connection["name"], connection["nm.uuid"]), ) self.connections_data_set_changed(idx) if self.check_mode == CheckMode.REAL_RUN: try: con_cur = self.nmutil.connection_add(con_new) except MyError as e: self.log_error(idx, "adding connection failed: %s" % (e)) elif not self.nmutil.connection_compare(con_cur, con_new, normalize_a=True): self.log_info( idx, "update connection %s, %s" % (con_cur.get_id(), con_cur.get_uuid()) ) self.connections_data_set_changed(idx) if self.check_mode == CheckMode.REAL_RUN: try: self.nmutil.connection_update(con_cur, con_new) except MyError as e: self.log_error(idx, "updating connection failed: %s" % (e)) else: self.log_info( idx, "connection %s, %s already up to date" % (con_cur.get_id(), con_cur.get_uuid()), ) if ( self.check_mode == CheckMode.REAL_RUN and connection["ieee802_1x"] is not None and connection["ieee802_1x"].get("ca_path") ): # It seems that NM on Fedora 31 # (NetworkManager-1.20.4-1.fc31.x86_64) does need some time so that # the D-Bus information is actually up-to-date. time.sleep(0.1) Util.GMainLoop_iterate_all() updated_connection = Util.first( self.nmutil.connection_list( name=connection["name"], uuid=connection["nm.uuid"] ) ) ca_path = updated_connection.get_setting_802_1x().props.ca_path if not ca_path: self.log_fatal( idx, "ieee802_1x.ca_path specified but not supported by " "NetworkManager. Please update NetworkManager or use " "ieee802_1x.ca_cert.", ) if con_cur is not None: self._remove_duplicate_profile(idx, con_cur, connection.get("timeout")) def _remove_duplicate_profile(self, idx, cur_nm_profile, timeout): logger = logging.getLogger() log_handler = NmLogHandler(self.log, idx) logger.addHandler(log_handler) for nm_profile in self._nm_provider.get_connections(): if ( nm_profile.get_id() == cur_nm_profile.get_id() and nm_profile.get_uuid() != cur_nm_profile.get_uuid() ): if self.check_mode == CheckMode.REAL_RUN: self._nm_provider.volatilize_connection_by_uuid( uuid=nm_profile.get_uuid(), timeout=(DEFAULT_TIMEOUT if timeout is None else timeout), check_mode=True, ) self.connections_data_set_changed(idx) logger.removeHandler(log_handler) def run_action_up(self, idx): connection = self.connections[idx] con = Util.first( self.nmutil.connection_list( name=connection["name"], uuid=connection["nm.uuid"] ) ) if not con: if self.check_mode == CheckMode.REAL_RUN: self.log_error( idx, "up connection %s, %s failed: no connection" % (connection["name"], connection["nm.uuid"]), ) else: self.log_info( idx, "up connection %s, %s" % (connection["name"], connection["nm.uuid"]), ) return is_active = self.nmutil.connection_is_active(con) is_modified = self.connection_modified_earlier(idx) force_state_change = self.connection_force_state_change(connection) if is_active and not force_state_change and not is_modified: self.log_info( idx, "up connection %s, %s skipped because already active" % (con.get_id(), con.get_uuid()), ) return self.log_info( idx, "up connection %s, %s (%s)" % ( con.get_id(), con.get_uuid(), ( "not-active" if not is_active else "is-modified" if is_modified else "force-state-change" ), ), ) self.connections_data_set_changed(idx) if self.check_mode == CheckMode.REAL_RUN: if self._try_reapply(idx, con): return try: ac = self.nmutil.connection_activate(con) except MyError as e: self.log_error(idx, "up connection failed: %s" % (e)) wait_time = connection["wait"] if wait_time is None: wait_time = DEFAULT_ACTIVATION_TIMEOUT try: self.nmutil.connection_activate_wait(ac, wait_time) except MyError as e: self.log_error(idx, "up connection failed while waiting: %s" % (e)) def _try_reapply(self, idx, con): """Try to reapply a connection If there is exactly one active connection with the same UUID activated on exactly one device, ask the device to reapply the connection. :returns: `True`, when the connection was reapplied, `False` otherwise :rtype: bool """ NM = Util.NM() acons = list(self.nmutil.active_connection_list(connections=[con])) if len(acons) != 1: return False active_connection = acons[0] if active_connection.get_state() == NM.ActiveConnectionState.ACTIVATED: devices = active_connection.get_devices() if len(devices) == 1: try: self.nmutil.reapply(devices[0]) self.log_info(idx, "connection reapplied") return True except MyError as error: self.log_info(idx, "connection reapply failed: %s" % (error)) return False def run_action_down(self, idx): connection = self.connections[idx] logger = logging.getLogger() log_handler = NmLogHandler(self.log, idx) logger.addHandler(log_handler) timeout = connection["wait"] if self._nm_provider.deactivate_connection( connection["name"], 10 if timeout is None else timeout, self.check_mode != CheckMode.REAL_RUN, ): self.connections_data_set_changed(idx) logger.removeHandler(log_handler) ############################################################################### class Cmd_initscripts(Cmd): def __init__(self, **kwargs): Cmd.__init__(self, **kwargs) self.validate_one_type = ( ArgValidator_ListConnections.VALIDATE_ONE_MODE_INITSCRIPTS ) def run_prepare(self): Cmd.run_prepare(self) for idx, connection in enumerate(self.connections): if connection.get("type") in ["macvlan"]: self.log_fatal( idx, "unsupported type %s for initscripts provider" % (connection["type"]), ) def check_name(self, idx, name=None): if name is None: name = self.connections[idx]["name"] try: f = IfcfgUtil.ifcfg_path(name) except MyError: self.log_error(idx, "invalid name %s for connection" % (name)) return None return f def forget_nm_connection(self, path): """ Forget a NetworkManager connection by loading the path of the deleted profile. This inverts the effect of loading a profile with `NM_CONTROLLED=no` earlier, which made NetworkManager ignore the device. This does not use the Python libnm bindings because they might not be present on the system, since the module is currently operating for the initscripts provider. If it fails, assume that NetworkManager is not present and did not save any state about the corresponding interface. """ try: subprocess.call( [ "busctl", "--system", "call", "org.freedesktop.NetworkManager", "/org/freedesktop/NetworkManager/Settings", "org.freedesktop.NetworkManager.Settings", "LoadConnections", "as", "1", path, ] ) except Exception: pass def run_action_absent(self, idx): n = self.connections[idx]["name"] name = n if not name: names = [] black_list_names = ArgUtil.connection_get_non_absent_names(self.connections) for f in os.listdir("/etc/sysconfig/network-scripts"): if not f.startswith("ifcfg-"): continue name = f[6:] if name in black_list_names: continue if name == "lo": continue names.append(name) else: if not self.check_name(idx): return names = [name] changed = False for name in names: for path in IfcfgUtil.ifcfg_paths(name): if not os.path.isfile(path): continue changed = True self.log_info(idx, "delete ifcfg-rh file '%s'" % (path)) self.connections_data_set_changed(idx) if self.check_mode == CheckMode.REAL_RUN: try: os.unlink(path) self.forget_nm_connection(path) except Exception as e: self.log_error( idx, "delete ifcfg-rh file '%s' failed: %s" % (path, e) ) if not changed: self.log_info( idx, "delete ifcfg-rh files for %s (no files present)" % ("'" + n + "'" if n else "*"), ) def run_action_present(self, idx): if not self.check_name(idx): return connection = self.connections[idx] name = connection["name"] old_content = IfcfgUtil.content_from_file(name) if not connection.get("type"): # if the type is not specified, just check that the connection was # found if not old_content.get("ifcfg"): self.log_error( idx, "Connection not found on system and 'type' not present" ) return ifcfg_all = IfcfgUtil.ifcfg_create( self.connections, idx, lambda msg: self.log_warn(idx, msg), old_content ) new_content = IfcfgUtil.content_from_dict( ifcfg_all, header=self.run_env.ifcfg_header ) if old_content == new_content: self.log_info(idx, "ifcfg-rh profile '%s' already up to date" % (name)) return op = "add" if (old_content["ifcfg"] is None) else "update" self.log_info(idx, "%s ifcfg-rh profile '%s'" % (op, name)) self.connections_data_set_changed(idx) if self.check_mode == CheckMode.REAL_RUN: try: IfcfgUtil.content_to_file(name, new_content) except MyError as e: self.log_error( idx, "%s ifcfg-rh profile '%s' failed: %s" % (op, name, e) ) def _run_action_updown(self, idx, do_up): if not self.check_name(idx): return connection = self.connections[idx] name = connection["name"] if connection["wait"] is not None: # initscripts don't support wait, they always block until the ifup/ifdown # command completes. Silently ignore the argument. pass path = IfcfgUtil.ifcfg_path(name) if not os.path.isfile(path): if ( self.check_mode == CheckMode.REAL_RUN and connection.get(PERSISTENT_STATE) != ABSENT_STATE ): self.log_error(idx, "ifcfg file '%s' does not exist" % (path)) else: if self.check_mode != CheckMode.REAL_RUN: in_checkmode = " in check mode" else: in_checkmode = "" self.log_info( idx, "ifcfg file '%s' does not exist%s" % (path, in_checkmode) ) return is_active = IfcfgUtil.connection_seems_active(name, self.run_env) is_modified = self.connection_modified_earlier(idx) force_state_change = self.connection_force_state_change(connection) if do_up: if is_active is True and not force_state_change and not is_modified: self.log_info( idx, "up connection %s skipped because already active" % (name) ) return self.log_info( idx, "up connection %s (%s)" % ( name, ( "not-active" if is_active is not True else "is-modified" if is_modified else "force-state-change" ), ), ) cmd = "ifup" else: if is_active is False and not force_state_change: self.log_info( idx, "down connection %s skipped because not active" % (name) ) return self.log_info( idx, "up connection %s (%s)" % (name, "active" if is_active is not False else "force-state-change"), ) cmd = "ifdown" self.connections_data_set_changed(idx) if self.check_mode == CheckMode.REAL_RUN: rc, out, err = self.run_env.run_command([cmd, name]) self.log_info( idx, "call '%s %s': rc=%d, out='%s', err='%s'" % (cmd, name, rc, out, err), ) if rc != 0: self.log_error( idx, "call '%s %s' failed with exit status %d" % (cmd, name, rc) ) def run_action_up(self, idx): self._run_action_updown(idx, True) def run_action_down(self, idx): self._run_action_updown(idx, False) ############################################################################### def main(): connections = None cmd = None run_env_ansible = RunEnvironmentAnsible() try: params = run_env_ansible.module.params cmd = Cmd.create( params["provider"], run_env=run_env_ansible, connections_unvalidated=params["connections"], connection_validator=ArgValidator_ListConnections(), is_check_mode=run_env_ansible.module.check_mode, ignore_errors=params["ignore_errors"], force_state_change=params["force_state_change"], debug_flags=params["__debug_flags"], ) connections = cmd.connections run_env_ansible.on_failure = cmd.on_failure cmd.run() except Exception as e: run_env_ansible.fail_json( connections, "fatal error: %s" % (e), changed=(cmd is not None and cmd.is_changed_modified_system), warn_traceback=not isinstance(e, MyError), ) run_env_ansible.exit_json( connections, changed=(cmd is not None and cmd.is_changed_modified_system) ) if __name__ == "__main__": main()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.generate_enhanced_compatibility_matrix:[17:543] ==scripts.generate_enhanced_compatibility_matrix:[17:543] class EnhancedCompatibilityMatrix: def __init__(self, project_root=None): if project_root is None: self.project_root = self._detect_project_root() else: self.project_root = Path(project_root) self.roles_dir = self.project_root / "roles" self.molecule_dir = self.project_root / "molecule" self.compatibility_data = {} def _detect_project_root(self): """Detect project root by looking for key files in multiple locations""" # Start with current working directory current_dir = Path.cwd() # Check current directory first if self._is_project_root(current_dir): return current_dir # Check if we're in a subdirectory (like scripts/) for parent in current_dir.parents: if self._is_project_root(parent): return parent # Check common GitHub Actions paths github_workspace = os.environ.get('GITHUB_WORKSPACE') if github_workspace: github_path = Path(github_workspace) if self._is_project_root(github_path): return github_path # Check if we're in a nested GitHub Actions structure if 'github' in str(current_dir).lower(): # Look for the actual project directory for part in current_dir.parts: if 'qubinode_kvmhost_setup_collection' in part: # Try to construct the path potential_root = Path('/'.join(current_dir.parts[:current_dir.parts.index(part)+1])) if self._is_project_root(potential_root): return potential_root # Try to find the project based on the script location script_path = Path(__file__).resolve() script_parent = script_path.parent.parent # Go up from scripts/ to project root if self._is_project_root(script_parent): return script_parent # Look for common project locations common_locations = [ Path.home() / "qubinode_kvmhost_setup_collection", Path("/home/vpcuser/qubinode_kvmhost_setup_collection"), Path("/home/runner/work/qubinode_kvmhost_setup_collection/qubinode_kvmhost_setup_collection"), ] for location in common_locations: if self._is_project_root(location): return location # Fallback: return current directory and let the script handle missing roles print(f"Warning: Could not detect project root, using current directory: {current_dir}") return current_dir def _is_project_root(self, path): """Check if a path looks like the project root""" path = Path(path) # Must have roles directory if not (path / "roles").exists(): return False # Should have at least one of these files indicators = ["galaxy.yml", "ansible.cfg", "pyproject.toml", "requirements.txt"] return any((path / indicator).exists() for indicator in indicators) def detect_rhel_versions(self): """Detect supported RHEL versions from role tasks and Molecule scenarios""" rhel_versions = set() # Check if roles directory exists if not self.roles_dir.exists(): print(f"Warning: Roles directory not found at {self.roles_dir}") return ["8", "9"] # Default fallback versions # Check Molecule configurations for tested versions if self.molecule_dir.exists(): for scenario_dir in self.molecule_dir.iterdir(): if scenario_dir.is_dir(): molecule_yml = scenario_dir / "molecule.yml" if molecule_yml.exists(): try: with open(molecule_yml, 'r') as f: molecule_config = yaml.safe_load(f) platforms = molecule_config.get('platforms', []) for platform in platforms: image = platform.get('image', '') if 'rockylinux' in image or 'almalinux' in image or 'ubi' in image: if ':8' in image or 'rhel8' in image: rhel_versions.add("8") elif ':9' in image or 'rhel9' in image: rhel_versions.add("9") elif ':10' in image or 'rhel10' in image: rhel_versions.add("10") except Exception as e: print(f"Warning: Could not read {molecule_yml}: {e}") # Fallback: check task files for version-specific logic version_patterns = ["rhel8", "rhel9", "rhel10", "el8", "el9", "el10"] try: for role_dir in self.roles_dir.iterdir(): if role_dir.is_dir() and role_dir.name.startswith("kvmhost_"): tasks_dir = role_dir / "tasks" if tasks_dir.exists(): for task_file in tasks_dir.glob("*.yml"): try: with open(task_file, 'r') as f: content = f.read() for pattern in version_patterns: if pattern in content.lower(): if "rhel8" in pattern or "el8" in pattern: rhel_versions.add("8") elif "rhel9" in pattern or "el9" in pattern: rhel_versions.add("9") elif "rhel10" in pattern or "el10" in pattern: rhel_versions.add("10") except Exception as e: print(f"Warning: Could not read {task_file}: {e}") except Exception as e: print(f"Warning: Could not scan roles directory: {e}") # Default to supporting 8, 9, 10 if no specific versions found if not rhel_versions: rhel_versions = {"8", "9", "10"} return sorted(list(rhel_versions)) def detect_container_compatibility(self): """Detect container compatibility features from recent enhancements""" container_features = { 'advanced_container_detection': { 'implemented': False, 'criteria': [], 'description': 'Multi-criteria container environment detection' }, 'task_skipping': { 'implemented': False, 'skipped_tasks': [], 'description': 'Container-inappropriate task skipping' }, 'gpg_verification': { 'implemented': False, 'strategy': 'unknown', 'description': 'Dynamic GPG verification for container environments' }, 'molecule_testing': { 'implemented': False, 'scenarios': [], 'platforms': [], 'description': 'Container-based testing with Molecule' } } # Check for advanced container detection in performance_optimization.yml perf_opt_file = self.project_root / "roles" / "kvmhost_setup" / "tasks" / "performance_optimization.yml" if perf_opt_file.exists(): try: with open(perf_opt_file, 'r') as f: content = f.read() if 'is_container_environment' in content: container_features['advanced_container_detection']['implemented'] = True if 'ansible_virtualization_type in' in content: container_features['advanced_container_detection']['criteria'].append('virtualization_type') if 'ansible_env.container' in content: container_features['advanced_container_detection']['criteria'].append('environment_variables') if 'ansible_mounts' in content and 'overlay' in content: container_features['advanced_container_detection']['criteria'].append('filesystem_analysis') if 'ansible_selinux' in content and 'docker_t' in content: container_features['advanced_container_detection']['criteria'].append('selinux_context') # Count tasks with container guards guard_count = content.count('when: not is_container_environment') if guard_count > 0: container_features['task_skipping']['implemented'] = True container_features['task_skipping']['skipped_tasks'] = [f"{guard_count} KVM-specific tasks"] except Exception as e: print(f"Warning: Could not analyze {perf_opt_file}: {e}") # Check for dynamic GPG verification in main.yml main_file = self.project_root / "roles" / "kvmhost_setup" / "tasks" / "main.yml" if main_file.exists(): try: with open(main_file, 'r') as f: content = f.read() if 'disable_gpg_check' in content and 'container' in content: container_features['gpg_verification']['implemented'] = True container_features['gpg_verification']['strategy'] = 'dynamic_container_detection' except Exception as e: print(f"Warning: Could not analyze {main_file}: {e}") # Check Molecule scenarios for container testing if self.molecule_dir.exists(): scenarios = [] platforms = [] for scenario_dir in self.molecule_dir.iterdir(): if scenario_dir.is_dir(): scenarios.append(scenario_dir.name) molecule_yml = scenario_dir / "molecule.yml" if molecule_yml.exists(): try: with open(molecule_yml, 'r') as f: molecule_config = yaml.safe_load(f) for platform in molecule_config.get('platforms', []): image = platform.get('image', '') if image not in platforms: platforms.append(image) except Exception as e: print(f"Warning: Could not read {molecule_yml}: {e}") if scenarios: container_features['molecule_testing']['implemented'] = True container_features['molecule_testing']['scenarios'] = scenarios container_features['molecule_testing']['platforms'] = platforms return container_features def analyze_role_features(self, role_name): """Analyze features and compatibility for a specific role""" role_dir = self.roles_dir / role_name features = {} # Standard feature detection tasks_dir = role_dir / "tasks" if tasks_dir.exists(): for task_file in tasks_dir.glob("*.yml"): try: with open(task_file, 'r') as f: content = f.read() # Extract feature name from file feature_name = task_file.stem features[feature_name] = { 'file': str(task_file.relative_to(self.project_root)), 'rhel_compatibility': {}, 'container_compatibility': 'unknown', 'requires_physical_host': False } # Check for container compatibility if 'when: not is_container_environment' in content: features[feature_name]['container_compatibility'] = 'skipped_in_containers' features[feature_name]['requires_physical_host'] = True elif 'is_container_environment' in content: features[feature_name]['container_compatibility'] = 'container_aware' else: features[feature_name]['container_compatibility'] = 'compatible' # Check RHEL version compatibility rhel_versions = self.detect_rhel_versions() for version in rhel_versions: version_supported = True notes = [] # Look for version-specific conditions if f"rhel{version}" in content.lower(): notes.append(f"RHEL {version} specifically mentioned") if f"ansible_distribution_major_version" in content: if f'== "{version}"' in content or f"== '{version}'" in content: notes.append(f"Version {version} specifically supported") elif f'in [' in content and f'"{version}"' in content: notes.append(f"Version {version} in supported list") features[feature_name]['rhel_compatibility'][f"rhel{version}"] = { 'supported': version_supported, 'notes': notes if notes else [f"No specific restrictions found for RHEL {version}"] } except Exception as e: print(f"Warning: Could not analyze {task_file}: {e}") return features def generate_enhanced_matrix(self): """Generate the enhanced compatibility matrix with container support""" rhel_versions = self.detect_rhel_versions() container_features = self.detect_container_compatibility() matrix = { 'metadata': { 'generated_date': datetime.now().strftime('%Y-%m-%d %H:%M:%S'), 'project': 'Qubinode KVM Host Setup Collection', 'version': '2.1.0', 'rhel_versions_supported': rhel_versions, 'generator_version': '2.0.0', 'container_compatibility': 'enhanced', 'last_updated_commit': self.get_git_commit_hash() }, 'container_compatibility': container_features, 'platform_support': { 'physical_hosts': { 'supported': True, 'features': 'full_kvm_optimization', 'notes': 'All features available including performance optimization' }, 'virtual_machines': { 'supported': True, 'features': 'limited_optimization', 'notes': 'Some performance features may not be applicable' }, 'containers': { 'supported': True, 'features': 'testing_only', 'notes': 'Container-inappropriate tasks automatically skipped', 'testing_platforms': ['Podman', 'Docker'] } }, 'rhel_compatibility_matrix': {} } # Analyze each kvmhost role if not self.roles_dir.exists(): print(f"❌ Error: Roles directory not found at {self.roles_dir}") print(f"🔍 Current project root: {self.project_root}") print("💡 Please run this script from the project root or specify the correct path") raise FileNotFoundError(f"Roles directory not found: {self.roles_dir}") for role_dir in self.roles_dir.iterdir(): if role_dir.is_dir() and role_dir.name.startswith("kvmhost_"): role_name = role_dir.name print(f"Analyzing role: {role_name}") role_features = self.analyze_role_features(role_name) matrix['rhel_compatibility_matrix'][role_name] = { 'description': f"KVM Host setup role for {role_name.replace('kvmhost_', '')}", 'features': role_features, 'overall_compatibility': {}, 'container_readiness': { 'testing_compatible': True, 'production_deployment': 'physical_vm_only' } } # Calculate overall compatibility per RHEL version for version in rhel_versions: supported_features = 0 total_features = len(role_features) container_aware_features = 0 for feature_name, feature_data in role_features.items(): if feature_data['rhel_compatibility'].get(f"rhel{version}", {}).get('supported', False): supported_features += 1 if feature_data['container_compatibility'] in ['container_aware', 'skipped_in_containers']: container_aware_features += 1 compatibility_percentage = (supported_features / total_features * 100) if total_features > 0 else 0 container_awareness = (container_aware_features / total_features * 100) if total_features > 0 else 0 matrix['rhel_compatibility_matrix'][role_name]['overall_compatibility'][f"rhel{version}"] = { 'compatibility_percentage': round(compatibility_percentage, 1), 'supported_features': supported_features, 'total_features': total_features, 'container_awareness_percentage': round(container_awareness, 1), 'status': 'supported' if compatibility_percentage >= 80 else 'partial' } return matrix def get_git_commit_hash(self): """Get the current git commit hash""" try: result = subprocess.run(['git', 'rev-parse', 'HEAD'], capture_output=True, text=True, cwd=self.project_root) return result.stdout.strip()[:8] if result.returncode == 0 else 'unknown' except: return 'unknown' def save_matrix(self, matrix, output_dir="docs"): """Save the compatibility matrix to JSON and generate markdown report""" output_path = self.project_root / output_dir output_path.mkdir(exist_ok=True) # Save JSON matrix json_file = output_path / "compatibility_matrix.json" with open(json_file, 'w') as f: json.dump(matrix, f, indent=2) print(f"✅ Compatibility matrix saved to: {json_file}") # Generate markdown report self.generate_markdown_report(matrix, output_path) def generate_markdown_report(self, matrix, output_path): """Generate a human-readable markdown compatibility report""" md_content = [] md_content.append("# RHEL Compatibility Matrix Report") md_content.append("") md_content.append("## 📊 Overview") md_content.append("") md_content.append(f"**Generated:** {matrix['metadata']['generated_date']}") md_content.append(f"**Project:** {matrix['metadata']['project']}") md_content.append(f"**Version:** {matrix['metadata']['version']}") md_content.append(f"**Commit:** {matrix['metadata']['last_updated_commit']}") md_content.append("") # Container compatibility section md_content.append("## 🐳 Container Compatibility Enhancement") md_content.append("") container_features = matrix['container_compatibility'] for feature_name, feature_data in container_features.items(): status = "✅" if feature_data['implemented'] else "❌" md_content.append(f"- **{feature_name.replace('_', ' ').title()}** {status}") md_content.append(f" - {feature_data['description']}") if feature_name == 'advanced_container_detection' and feature_data['criteria']: md_content.append(f" - Detection criteria: {', '.join(feature_data['criteria'])}") elif feature_name == 'task_skipping' and feature_data['skipped_tasks']: md_content.append(f" - Skipped tasks: {', '.join(feature_data['skipped_tasks'])}") elif feature_name == 'gpg_verification' and feature_data['strategy']: md_content.append(f" - Strategy: {feature_data['strategy']}") elif feature_name == 'molecule_testing': if feature_data['scenarios']: md_content.append(f" - Test scenarios: {', '.join(feature_data['scenarios'])}") if feature_data['platforms']: md_content.append(f" - Container platforms: {len(feature_data['platforms'])} images tested") md_content.append("") # Platform support section md_content.append("## 🖥️ Platform Support Matrix") md_content.append("") md_content.append("| Platform | Supported | Features | Notes |") md_content.append("|----------|-----------|----------|-------|") for platform, support_data in matrix['platform_support'].items(): status = "✅" if support_data['supported'] else "❌" platform_name = platform.replace('_', ' ').title() features = support_data['features'].replace('_', ' ').title() notes = support_data['notes'] md_content.append(f"| {platform_name} | {status} | {features} | {notes} |") md_content.append("") # RHEL compatibility section md_content.append("## 🔴 RHEL Version Compatibility") md_content.append("") rhel_versions = matrix['metadata']['rhel_versions_supported'] for role_name, role_data in matrix['rhel_compatibility_matrix'].items(): md_content.append(f"### {role_name}") md_content.append("") md_content.append(role_data['description']) md_content.append("") # Compatibility table md_content.append("| RHEL Version | Compatibility | Features Supported | Container Awareness | Status |") md_content.append("|--------------|---------------|-------------------|-------------------|--------|") for version in rhel_versions: compat_data = role_data['overall_compatibility'].get(f"rhel{version}", {}) compat_pct = compat_data.get('compatibility_percentage', 0) container_pct = compat_data.get('container_awareness_percentage', 0) supported = compat_data.get('supported_features', 0) total = compat_data.get('total_features', 0) status = compat_data.get('status', 'unknown') status_icon = "✅" if status == 'supported' else "⚠️" if status == 'partial' else "❌" md_content.append(f"| RHEL {version} | {compat_pct}% | {supported}/{total} | {container_pct}% | {status_icon} {status} |") md_content.append("") # Testing validation section md_content.append("## 🧪 Testing Validation") md_content.append("") if matrix['container_compatibility']['molecule_testing']['implemented']: scenarios = matrix['container_compatibility']['molecule_testing']['scenarios'] platforms = matrix['container_compatibility']['molecule_testing']['platforms'] md_content.append(f"**Molecule Test Scenarios:** {len(scenarios)}") for scenario in scenarios: md_content.append(f"- {scenario}") md_content.append("") md_content.append(f"**Container Platforms Tested:** {len(platforms)}") for platform in platforms[:5]: # Limit to first 5 for readability md_content.append(f"- {platform}") if len(platforms) > 5: md_content.append(f"- ... and {len(platforms) - 5} more") md_content.append("") # Save markdown report md_file = output_path / "compatibility_report.md" with open(md_file, 'w') as f: f.write('\n'.join(md_content)) print(f"✅ Compatibility report saved to: {md_file}") def main(): """Main execution function""" if len(sys.argv) > 1: project_root = sys.argv[1] print(f"🔍 Using specified project root: {project_root}") generator = EnhancedCompatibilityMatrix(project_root) else: print("🔍 Auto-detecting project root...") generator = EnhancedCompatibilityMatrix() print(f"🔍 Detected project root: {generator.project_root}") print("🔍 Generating Enhanced Compatibility Matrix...") matrix = generator.generate_enhanced_matrix() generator.save_matrix(matrix) print("\n🎉 Enhanced compatibility matrix generation complete!") print("\n📋 Summary:") print(f"- RHEL versions supported: {', '.join(matrix['metadata']['rhel_versions_supported'])}") print(f"- Container compatibility: {matrix['metadata']['container_compatibility']}") print(f"- Roles analyzed: {len(matrix['rhel_compatibility_matrix'])}") container_features = matrix['container_compatibility'] implemented_features = sum(1 for f in container_features.values() if f['implemented']) print(f"- Container features implemented: {implemented_features}/{len(container_features)}") if __name__ == "__main__": main()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==blivet:[3:372] ==blivet:[3:372] __metaclass__ = type ANSIBLE_METADATA = { 'metadata_version': '1.1', 'status': ['preview'], 'supported_by': 'community' } DOCUMENTATION = ''' --- module: blivet short_description: Module for management of linux block device stacks version_added: "2.13.0" description: - "WARNING: Do not use this module directly! It is only for role internal use." - "Module configures storage pools and volumes to match the state specified in input parameters." options: pools: description: pools type: list elements: dict suboptions: disks: description: disks type: list default: [] elements: str encryption: description: encryption type: bool encryption_cipher: description: encryption_cipher type: str encryption_key: description: encryption_key file, not the actual key type: str encryption_key_size: description: encryption_key_size type: int encryption_luks_version: description: encryption_luks_version type: str encryption_password: description: encryption_password type: str encryption_clevis_pin: description: encryption_clevis_pin type: str encryption_tang_url: description: encryption_tang_url type: str encryption_tang_thumbprint: description: encryption_tang_thumbprint type: str grow_to_fill: description: grow_to_fill type: bool name: description: name type: str raid_level: description: raid_level type: str raid_device_count: description: raid_device_count type: int raid_spare_count: description: raid_spare_count type: int raid_metadata_version: description: raid_metadata_version type: str raid_chunk_size: description: raid_chunk_size type: str shared: description: shared type: bool state: description: state type: str default: present choices: ['present', 'absent'] type: description: type type: str volumes: description: volumes type: list default: [] elements: dict suboptions: encryption: description: encryption type: bool encryption_cipher: description: encryption_cipher type: str encryption_key: description: encryption_key file, not the actual key type: str encryption_key_size: description: encryption_key_size type: int encryption_luks_version: description: encryption_luks_version type: str encryption_password: description: encryption_password type: str fs_create_options: description: fs_create_options type: str fs_label: description: fs_label type: str fs_type: description: fs_type type: str mount_options: description: mount_options type: str mount_point: description: mount_point type: str mount_user: description: mount_user type: str mount_group: description: mount_group type: str mount_mode: description: mount_mode type: str name: description: name type: str raid_level: description: raid_level type: str size: description: size type: str state: description: state type: str default: present choices: ['present', 'absent'] type: description: type type: str cached: description: cached type: bool cache_devices: description: cache_devices type: list default: [] elements: str cache_mode: description: cache_mode type: str cache_size: description: cache_size type: str compression: description: compression type: bool deduplication: description: deduplication type: bool raid_disks: description: raid_disks type: list default: [] elements: str raid_stripe_size: description: raid_stripe_size type: str thin_pool_name: description: thin_pool_name type: str thin_pool_size: description: thin_pool_size type: str thin: description: thin type: bool default: false vdo_pool_size: description: vdo_pool_size type: str volumes: description: volumes type: list elements: dict suboptions: encryption: description: encryption type: bool encryption_cipher: description: encryption_cipher type: str encryption_key: description: encryption_key file, not the actual key type: str encryption_key_size: description: encryption_key_size type: int encryption_luks_version: description: encryption_luks_version type: str encryption_password: description: encryption_password type: str fs_create_options: description: fs_create_options type: str fs_label: description: fs_label type: str fs_type: description: fs_type type: str mount_options: description: mount_options type: str mount_point: description: mount_point type: str mount_user: description: mount_user type: str mount_group: description: mount_group type: str mount_mode: description: mount_mode type: str name: description: name type: str raid_level: description: raid_level type: str size: description: size type: str state: description: state type: str default: present choices: ['present', 'absent'] type: description: type type: str disks: description: disks type: list default: [] elements: str raid_device_count: description: raid_device_count type: int raid_spare_count: description: raid_spare_count type: int raid_metadata_version: description: raid_metadata_version type: str raid_chunk_size: description: raid_chunk_size type: str packages_only: description: packages_only type: bool default: false disklabel_type: description: - | disklabel type string (eg: 'gpt') to use, overriding the built-in logic in blivet type: str safe_mode: description: - boolean indicating that we should fail rather than implicitly/automatically removing devices or formatting type: bool default: true pool_defaults: description: pool_defaults type: dict volume_defaults: description: volume_defaults type: dict use_partitions: description: boolean indicating whether to create partitions on disks for pool backing devices type: bool diskvolume_mkfs_option_map: description: - dict which maps filesystem names to additional mkfs options that should be used when creating a disk volume (that is, a whole disk filesystem) type: dict default: {} uses_kmod_kvdo: description: - bool - set if platform uses_kmod_kvdo type: bool default: false author: - David Lehman (@dwlehman) ''' EXAMPLES = ''' - name: Manage devices blivet: pools: - name: "{{ app_pool }}" disks: ["sdd", "sde"] volumes: - name: shared size: "10 GiB" mount_point: /opt/{{ app_pool }}/shared - name: web size: 8g mount_point: /opt/{{ app_pool }}/web volumes: - name: whole_disk1 disks: ['sdc'] mount_point: /whole_disk1 fs_type: ext4 mount_options: journal_checksum,async,noexec ''' RETURN = ''' actions: description: list of dicts describing actions taken returned: success type: list elements: dict leaves: description: list of paths to leaf devices returned: success type: list elements: dict mounts: description: list of dicts describing mounts to set up returned: success type: list elements: dict crypts: description: list of dicts describing crypttab entries to set up returned: success type: list elements: dict pools: description: list of dicts describing the pools w/ device path for each volume returned: success type: list elements: dict volumes: description: list of dicts describing the volumes w/ device path for each returned: success type: list elements: dict
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_yaml_parsing:[13:370] ==scripts.fix_yaml_parsing:[13:370] class YAMLParsingFixer: def __init__(self, base_path: str = "."): self.base_path = Path(base_path) self.fixes_applied = [] def validate_yaml_syntax(self, file_path: Path) -> Tuple[bool, str]: """Validate YAML syntax and return error if any""" try: with open(file_path, 'r', encoding='utf-8') as f: yaml.safe_load(f) return True, "" except yaml.YAMLError as e: return False, str(e) except Exception as e: return False, f"File read error: {str(e)}" def fix_double_module_names(self) -> int: """Fix doubled module names like ansible.builtin.ansible.builtin.file""" fixed_count = 0 yaml_files = list(self.base_path.glob("roles/**/*.yml")) patterns = [ (r'ansible\.builtin\.ansible\.builtin\.', 'ansible.builtin.'), (r'community\.general\.community\.general\.', 'community.general.'), (r'ansible\.posix\.ansible\.posix\.', 'ansible.posix.'), (r'containers\.podman\.containers\.podman\.', 'containers.podman.'), ] for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: content = f.read() original_content = content for pattern, replacement in patterns: content = re.sub(pattern, replacement, content) if content != original_content: with open(file_path, 'w', encoding='utf-8') as f: f.write(content) fixed_count += 1 self.fixes_applied.append(f"Fixed double module names in {file_path}") except Exception as e: print(f"Error fixing double module names in {file_path}: {e}") return fixed_count def fix_malformed_jinja_escaping(self) -> int: """Fix malformed Jinja template escaping""" fixed_count = 0 yaml_files = list(self.base_path.glob("roles/**/*.yml")) for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: content = f.read() original_content = content # Fix various malformed escaping patterns fixes = [ # Fix \'string\' -> 'string' (r"\\\'([^\\\']*?)\\\'", r"'\1'"), # Fix \"string\" -> "string" (r'\\"([^\\"]*?)\\"', r'"\1"'), # Fix spacing in filters with escaped quotes (r'default\(\\\'([^\\\']*)\\\'\)', r"default('\1')"), (r'default\(\\"([^\\"]*)\\"\\)', r'default("\1")'), # Fix malformed Jinja spacing artifacts (r'\{\{\s*([^}]+?)\s*\|\s*default\s*\(\s*\\\'([^\\\']*)\\\'\s*\)\s*\}\}', r"{{ \1 | default('\2') }}"), (r'\{\{\s*([^}]+?)\s*\|\s*default\s*\(\s*\\"([^\\"]*)\\"\\s*\)\s*\}\}', r'{{ \1 | default("\2") }}'), ] for pattern, replacement in fixes: content = re.sub(pattern, replacement, content) if content != original_content: with open(file_path, 'w', encoding='utf-8') as f: f.write(content) fixed_count += 1 self.fixes_applied.append(f"Fixed malformed Jinja escaping in {file_path}") except Exception as e: print(f"Error fixing Jinja escaping in {file_path}: {e}") return fixed_count def fix_jinja_spacing_artifacts(self) -> int: """Fix spacing artifacts from previous automated fixes""" fixed_count = 0 yaml_files = list(self.base_path.glob("roles/**/*.yml")) for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: content = f.read() original_content = content # Fix various spacing artifacts fixes = [ # Fix excessive spaces around pipes (r'\|\s{2,}default\s*\(', '| default('), (r'\|\s{2,}join\s*\(', '| join('), (r'\|\s{2,}length\s*', '| length'), (r'\|\s{2,}int\s*', '| int'), (r'\|\s{2,}bool\s*', '| bool'), # Fix multiple spaces in Jinja templates (r'\{\{\s{2,}', '{{ '), (r'\s{2,}\}\}', ' }}'), # Fix spacing around operators in Jinja (r'\s+\|\s+default\s+\(\s+', ' | default('), (r'\s+\|\s+join\s+\(\s+', ' | join('), # Fix line continuation artifacts (r'\s+\|\s+\n\s+default', ' | default'), ] for pattern, replacement in fixes: content = re.sub(pattern, replacement, content, flags=re.MULTILINE) if content != original_content: with open(file_path, 'w', encoding='utf-8') as f: f.write(content) fixed_count += 1 self.fixes_applied.append(f"Fixed Jinja spacing artifacts in {file_path}") except Exception as e: print(f"Error fixing Jinja spacing artifacts in {file_path}: {e}") return fixed_count def fix_quote_inconsistencies(self) -> int: """Fix quote inconsistencies that can cause YAML parsing issues""" fixed_count = 0 yaml_files = list(self.base_path.glob("roles/**/*.yml")) for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: content = f.read() original_content = content # Fix mixed quotes in YAML values fixes = [ # Fix mode values to be consistent (r'mode:\s*"([^"]*)"', r"mode: '\1'"), # Fix path values with mixed quotes (r'path:\s*"([^"]*)"', r"path: '\1'"), # Fix name values with mixed quotes in loops (r'name:\s*"([^"]*)"', r"name: '\1'"), ] for pattern, replacement in fixes: content = re.sub(pattern, replacement, content) if content != original_content: with open(file_path, 'w', encoding='utf-8') as f: f.write(content) fixed_count += 1 self.fixes_applied.append(f"Fixed quote inconsistencies in {file_path}") except Exception as e: print(f"Error fixing quote inconsistencies in {file_path}: {e}") return fixed_count def fix_indentation_issues(self) -> int: """Fix common indentation issues that break YAML parsing""" fixed_count = 0 yaml_files = list(self.base_path.glob("roles/**/*.yml")) for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: lines = f.readlines() fixed_lines = [] changed = False for i, line in enumerate(lines): original_line = line # Fix common indentation issues # Remove tabs and replace with spaces if '\t' in line: line = line.expandtabs(2) changed = True # Fix lines that start with spaces but should be at root level if line.strip().startswith('---') and line.startswith(' '): line = line.lstrip() changed = True # Fix mixed indentation in task lists if re.match(r'^\s*-\s+name:', line): # Ensure consistent 2-space indentation indent_level = (len(line) - len(line.lstrip())) // 2 * 2 line = ' ' * indent_level + line.lstrip() if line != original_line: changed = True fixed_lines.append(line) if changed: with open(file_path, 'w', encoding='utf-8') as f: f.writelines(fixed_lines) fixed_count += 1 self.fixes_applied.append(f"Fixed indentation issues in {file_path}") except Exception as e: print(f"Error fixing indentation in {file_path}: {e}") return fixed_count def fix_unicode_and_encoding_issues(self) -> int: """Fix unicode and encoding issues that can break YAML parsing""" fixed_count = 0 yaml_files = list(self.base_path.glob("roles/**/*.yml")) for file_path in yaml_files: try: # Try to read with different encodings content = None for encoding in ['utf-8', 'latin1', 'cp1252']: try: with open(file_path, 'r', encoding=encoding) as f: content = f.read() break except UnicodeDecodeError: continue if content is None: continue original_content = content # Fix common unicode issues fixes = [ # Fix smart quotes ('"', '"'), ('"', '"'), (''', "'"), (''', "'"), # Fix em/en dashes ('—', '-'), ('–', '-'), # Fix ellipsis ('…', '...'), ] for old_char, new_char in fixes: content = content.replace(old_char, new_char) if content != original_content: with open(file_path, 'w', encoding='utf-8') as f: f.write(content) fixed_count += 1 self.fixes_applied.append(f"Fixed unicode/encoding issues in {file_path}") except Exception as e: print(f"Error fixing unicode/encoding in {file_path}: {e}") return fixed_count def validate_all_yaml_files(self) -> Tuple[int, List[str]]: """Validate all YAML files and return count of valid files and list of errors""" yaml_files = list(self.base_path.glob("roles/**/*.yml")) valid_count = 0 errors = [] for file_path in yaml_files: is_valid, error = self.validate_yaml_syntax(file_path) if is_valid: valid_count += 1 else: errors.append(f"{file_path}: {error}") return valid_count, errors def run_all_fixes(self) -> Dict[str, int]: """Run all YAML parsing fixes""" print("🔧 Starting comprehensive YAML parsing fixes...") # Validate before fixes total_files = len(list(self.base_path.glob("roles/**/*.yml"))) valid_before, errors_before = self.validate_all_yaml_files() print(f"� Before fixes: {valid_before}/{total_files} files are valid YAML") if errors_before: print(f"❌ Found {len(errors_before)} YAML parsing errors") for error in errors_before[:5]: # Show first 5 errors print(f" - {error}") if len(errors_before) > 5: print(f" ... and {len(errors_before) - 5} more errors") results = { "double_module_names": self.fix_double_module_names(), "malformed_jinja_escaping": self.fix_malformed_jinja_escaping(), "jinja_spacing_artifacts": self.fix_jinja_spacing_artifacts(), "quote_inconsistencies": self.fix_quote_inconsistencies(), "indentation_issues": self.fix_indentation_issues(), "unicode_encoding_issues": self.fix_unicode_and_encoding_issues(), } # Validate after fixes valid_after, errors_after = self.validate_all_yaml_files() total_fixes = sum(results.values()) print(f"\n✅ YAML parsing fixes completed!") print(f"📊 Summary:") for fix_type, count in results.items(): if count > 0: print(f" - {fix_type.replace('_', ' ').title()}: {count} files") print(f"\n🎯 Total files fixed: {total_fixes}") print(f"📈 YAML validity improved: {valid_before}/{total_files} → {valid_after}/{total_files}") if valid_after > valid_before: print(f"🎉 Fixed {valid_after - valid_before} previously broken YAML files!") if errors_after: print(f"\n⚠️ Remaining YAML errors ({len(errors_after)}):") for error in errors_after[:3]: # Show first 3 remaining errors print(f" - {error}") if len(errors_after) > 3: print(f" ... and {len(errors_after) - 3} more errors") if self.fixes_applied: print(f"\n📝 Applied fixes:") for fix in self.fixes_applied[:10]: # Show first 10 print(f" - {fix}") if len(self.fixes_applied) > 10: print(f" ... and {len(self.fixes_applied) - 10} more") return results def main(): fixer = YAMLParsingFixer() results = fixer.run_all_fixes() total_fixes = sum(results.values()) if total_fixes > 0: print(f"\n🔍 Run 'ansible-lint roles/' again to see if parsing errors are resolved") return 0 else: print(f"\n✅ No YAML parsing fixes were needed") return 1 if __name__ == "__main__": sys.exit(main())
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint_advanced:[14:351] ==scripts.fix_ansible_lint_advanced:[14:351] class AdvancedAnsibleLintFixer: def __init__(self, base_path: str = "."): self.base_path = Path(base_path) self.fixes_applied = [] def fix_advanced_jinja_spacing(self) -> int: """Fix complex Jinja2 spacing issues""" fixed_count = 0 yaml_files = list(self.base_path.glob("roles/**/*.yml")) for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: content = f.read() original_content = content # Fix complex Jinja patterns with multiple pipes and spaces patterns = [ # {{ var|filter|filter }} -> {{ var | filter | filter }} (r'\{\{\s*([^}|]+)\|([^}|]+)\|([^}]+)\s*\}\}', r'{{ \1 | \2 | \3 }}'), # {{ var | filter }} -> {{ var | filter }} (r'\{\{\s*([^}|]+)\s+\|\s+([^}]+)\s*\}\}', r'{{ \1 | \2 }}'), # Fix multi-space issues in joins (r'\|\s*join\(\s*[\'"]([^\'"]*)[\'"]\s*\)\s*\|\s*', r'| join(\'\1\') | '), # Fix spacing around default filter (r'\|\s*default\s*\(\s*[\'"]([^\'"]*)[\'"]\s*\)', r'| default(\'\1\')'), ] for pattern, replacement in patterns: content = re.sub(pattern, replacement, content) if content != original_content: with open(file_path, 'w', encoding='utf-8') as f: f.write(content) fixed_count += 1 self.fixes_applied.append(f"Fixed advanced Jinja spacing in {file_path}") except Exception as e: print(f"Error fixing advanced Jinja spacing in {file_path}: {e}") return fixed_count def add_changed_when_conditions(self) -> int: """Add changed_when: false to shell/command tasks that shouldn't report changes""" fixed_count = 0 yaml_files = list(self.base_path.glob("roles/**/*.yml")) # Common patterns for tasks that are typically idempotent checks read_only_patterns = [ r'check\s+if', r'verify\s+', r'get\s+(current|existing)', r'test\s+', r'validate\s+', r'show\s+', r'list\s+', r'cat\s+', r'grep\s+', r'find\s+', r'stat\s+', ] for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: content = f.read() original_content = content lines = content.split('\n') new_lines = [] i = 0 while i < len(lines): line = lines[i] # Look for shell/command tasks if re.match(r'\s*-\s+(name|shell|command):', line) or \ 'module: shell' in line or 'module: command' in line: # Check if this is a task block task_lines = [line] indent_level = len(line) - len(line.lstrip()) j = i + 1 # Collect the full task while j < len(lines): next_line = lines[j] next_indent = len(next_line) - len(next_line.lstrip()) if next_line.strip() == '': task_lines.append(next_line) j += 1 continue if next_indent <= indent_level and next_line.strip().startswith('-'): break task_lines.append(next_line) j += 1 task_content = '\n'.join(task_lines) # Check if it's a shell/command task without changed_when if ('shell:' in task_content or 'command:' in task_content) and \ 'changed_when:' not in task_content and \ 'register:' not in task_content: # Check if it matches read-only patterns command_text = task_content.lower() is_readonly = any(re.search(pattern, command_text) for pattern in read_only_patterns) if is_readonly: # Add changed_when: false last_task_line = len(task_lines) - 1 while last_task_line >= 0 and task_lines[last_task_line].strip() == '': last_task_line -= 1 if last_task_line >= 0: base_indent = ' ' * (indent_level + 2) task_lines.insert(last_task_line + 1, f"{base_indent}changed_when: false") self.fixes_applied.append(f"Added changed_when: false to read-only task in {file_path}") new_lines.extend(task_lines) i = j continue new_lines.append(line) i += 1 new_content = '\n'.join(new_lines) if new_content != original_content: with open(file_path, 'w', encoding='utf-8') as f: f.write(new_content) fixed_count += 1 except Exception as e: print(f"Error adding changed_when in {file_path}: {e}") return fixed_count def fix_fqcn_actions(self) -> int: """Fix FQCN (Fully Qualified Collection Name) issues""" fixed_count = 0 yaml_files = list(self.base_path.glob("roles/**/*.yml")) # Common FQCN replacements fqcn_mappings = { 'modprobe': 'community.general.modprobe', 'setup': 'ansible.builtin.setup', 'ping': 'ansible.builtin.ping', 'copy': 'ansible.builtin.copy', 'template': 'ansible.builtin.template', 'file': 'ansible.builtin.file', 'lineinfile': 'ansible.builtin.lineinfile', 'replace': 'ansible.builtin.replace', 'package': 'ansible.builtin.package', 'service': 'ansible.builtin.service', 'systemd': 'ansible.builtin.systemd', 'mount': 'ansible.posix.mount', 'firewalld': 'ansible.posix.firewalld', 'sysctl': 'ansible.posix.sysctl', } for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: content = f.read() original_content = content for short_name, fqcn in fqcn_mappings.items(): # Replace module usage patterns patterns = [ (f'{short_name}:', f'{fqcn}:'), (f'module: {short_name}', f'module: {fqcn}'), ] for pattern, replacement in patterns: content = re.sub(pattern, replacement, content) if content != original_content: with open(file_path, 'w', encoding='utf-8') as f: f.write(content) fixed_count += 1 self.fixes_applied.append(f"Fixed FQCN actions in {file_path}") except Exception as e: print(f"Error fixing FQCN in {file_path}: {e}") return fixed_count def fix_partial_become_tasks(self) -> int: """Fix partial become tasks by adding become: true""" fixed_count = 0 yaml_files = list(self.base_path.glob("roles/**/*.yml")) for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: content = f.read() original_content = content lines = content.split('\n') new_lines = [] i = 0 while i < len(lines): line = lines[i] # Look for tasks with become_user but no become if 'become_user:' in line: # Check the context for this task task_start = i indent_level = len(line) - len(line.lstrip()) # Find the start of this task while task_start > 0: prev_line = lines[task_start - 1] prev_indent = len(prev_line) - len(prev_line.lstrip()) if prev_line.strip().startswith('- name:') or prev_indent < indent_level: break task_start -= 1 # Collect the task block task_lines = [] j = task_start while j < len(lines): task_line = lines[j] task_indent = len(task_line) - len(task_line.lstrip()) if j > task_start and task_line.strip().startswith('-') and task_indent <= indent_level: break task_lines.append((j, task_line)) j += 1 # Check if become: is already present task_text = '\n'.join([line for _, line in task_lines]) if 'become_user:' in task_text and 'become:' not in task_text: # Add become: true before become_user base_indent = ' ' * indent_level new_lines.append(f"{base_indent}become: true") self.fixes_applied.append(f"Added become: true to task with become_user in {file_path}") new_lines.append(line) i += 1 new_content = '\n'.join(new_lines) if new_content != original_content: with open(file_path, 'w', encoding='utf-8') as f: f.write(new_content) fixed_count += 1 except Exception as e: print(f"Error fixing partial become in {file_path}: {e}") return fixed_count def fix_literal_compare(self) -> int: """Fix literal True/False comparisons""" fixed_count = 0 yaml_files = list(self.base_path.glob("roles/**/*.yml")) for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: content = f.read() original_content = content # Fix literal comparisons patterns = [ (r'==\s*True\b', ''), (r'==\s*False\b', ' == false'), (r'!=\s*True\b', ' == false'), (r'!=\s*False\b', ''), (r'\bis\s+True\b', ''), (r'\bis\s+False\b', ' == false'), (r'\bis\s+not\s+True\b', ' == false'), (r'\bis\s+not\s+False\b', ''), ] for pattern, replacement in patterns: content = re.sub(pattern, replacement, content) if content != original_content: with open(file_path, 'w', encoding='utf-8') as f: f.write(content) fixed_count += 1 self.fixes_applied.append(f"Fixed literal comparisons in {file_path}") except Exception as e: print(f"Error fixing literal compare in {file_path}: {e}") return fixed_count def run_all_fixes(self) -> Dict[str, int]: """Run all advanced automated fixes""" print("🔧 Starting advanced automated ansible-lint fixes...") results = { "advanced_jinja_spacing": self.fix_advanced_jinja_spacing(), "changed_when_conditions": self.add_changed_when_conditions(), "fqcn_actions": self.fix_fqcn_actions(), "partial_become_tasks": self.fix_partial_become_tasks(), "literal_compare": self.fix_literal_compare(), } total_fixes = sum(results.values()) print(f"\n✅ Advanced automated fixes completed!") print(f"📊 Summary:") for fix_type, count in results.items(): if count > 0: print(f" - {fix_type.replace('_', ' ').title()}: {count} files") print(f"\n🎯 Total files fixed: {total_fixes}") if self.fixes_applied: print(f"\n📝 Applied fixes:") for fix in self.fixes_applied[:10]: # Show first 10 print(f" - {fix}") if len(self.fixes_applied) > 10: print(f" ... and {len(self.fixes_applied) - 10} more") return results def main(): fixer = AdvancedAnsibleLintFixer() results = fixer.run_all_fixes() print(f"\n🔍 Run 'ansible-lint roles/' again to see remaining issues") return 0 if sum(results.values()) > 0 else 1 if __name__ == "__main__": sys.exit(main())
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==storage_lsr.argument_validator:[4:355] ==storage_lsr.argument_validator:[4:355] __metaclass__ = type # pylint: disable=undefined-variable STRING_TYPE = str if sys.version_info.major == 3 else basestring # noqa:F821 BOOLEANS_TRUE = ['y', 'yes', 'on', '1', 'true', 't', 1, 1.0, True] BOOLEANS_FALSE = ['n', 'no', 'off', '0', 'false', 'f', 0, 0.0, False] # Combinations of parameters (and their values) that will raise exception # use [] if value does not matter # example: {'options': {'pools.encryption:[True]', pools.volumes.deduplication:[True]}, 'err_msg:' 'deduplication cannot be used with encryption'} UNSUPPORTED_COMBOS = [{'options': {'pools.volumes.encryption': BOOLEANS_TRUE, 'pools.volumes.deduplication': BOOLEANS_TRUE}, 'err_msg': "Deduplication is not supported on encrypted volumes"}, {'options': {'pools.volumes.encryption': BOOLEANS_TRUE, 'pools.volumes.compression': BOOLEANS_TRUE}, 'err_msg': "Compression is not supported on encrypted volumes"}, {'options': {'pools.volumes.thin': BOOLEANS_TRUE, 'pools.volumes.compression': BOOLEANS_TRUE}, 'err_msg': "Dedupliation is not supported on thin pool volumes"}, {'options': {'pools.volumes.thin': BOOLEANS_TRUE, 'pools.volumes.deduplication': BOOLEANS_TRUE}, 'err_msg': "Compression is not supported on thin pool volumes"}] class ArgValidator(object): @classmethod def _validate_list(cls, value): if isinstance(value, list): return value if isinstance(value, STRING_TYPE): return value.split(",") if isinstance(value, int) or isinstance(value, float): return [value] raise TypeError("'%s' has to be a list" % value) @classmethod def _validate_str(cls, value): return str(value) @classmethod def _validate_bool(cls, value): if value in BOOLEANS_TRUE: return True if value in BOOLEANS_FALSE: return False if value is None: return None raise TypeError("'%s' has to be convertible to a bool" % value) @classmethod def _validate_int(cls, value): try: return int(value) except ValueError: raise TypeError("'%s' has to be an integer" % value) @classmethod def _validate_float(cls, value): try: return float(value) except ValueError: raise TypeError("'%s' has to be a float" % value) @classmethod def validate_item(cls, spec, param, key): # validate and return normalized value of a given parameter based on spec # raises TypeError, ValueError on failure if key not in param or param[key] is None: # if the parameter is not specified, use default if defined return spec[key].get('default', None) choices = spec[key].get('choices') if choices is not None and param[key] not in choices: raise ValueError("'%s' has to be one of: %s" % (param[key], ', '.join(choices))) validate = cls.VALIDATION_TYPE_DISPATCHER[spec[key].get('type', 'str')] normalized_value = validate(param[key]) return normalized_value @classmethod def validate_list(cls, spec_type, values): # raises TypeError, ValueError on failure normalized_list = list() for value in values: validate = cls.VALIDATION_TYPE_DISPATCHER[spec_type] normalized_value = validate(value) normalized_list.append(normalized_value) return normalized_list ArgValidator.VALIDATION_TYPE_DISPATCHER = dict(list=ArgValidator._validate_list, str=ArgValidator._validate_str, bool=ArgValidator._validate_bool, int=ArgValidator._validate_int, float=ArgValidator._validate_float) def _validate_parameters(argument_spec, parameters, error_log=None, updated_params=None): # recursively validate and normalize all parameters based on argument specifications if error_log is None: error_log = list() if updated_params is None: updated_params = dict() for spec, value in argument_spec.items(): if spec not in parameters: # normalize unused parameters try: # value is not defined, try to use default updated_params[spec] = value['default'] # cannot use value.get('default', *); * could be the default except KeyError: # value is not defined and has no default value if value['type'] == 'list': updated_params[spec] = list() elif value['type'] == 'dict': updated_params[spec] = dict() else: updated_params[spec] = None elif value.get('type') == 'dict': if 'options' not in value: # generic dict, no way to check its contents updated_params[spec] = parameters[spec] else: # nested dict errors, up_params = _validate_parameters(value['options'], parameters[spec]) if errors: # recursion will build prefixes of the error messages errors = [spec + '->' + x for x in errors] error_log.extend(errors) updated_params[spec] = up_params elif value.get('type') == 'list': if 'options' in value and value.get('elements', '') == 'dict': # nested list of dicts updated_params[spec] = list() for item in parameters[spec]: errors, up_params = _validate_parameters(value['options'], item) if errors: # recursion will build prefixes of the error messages errors = [spec + '->' + x for x in errors] error_log.extend(errors) updated_params[spec].append(up_params) elif 'elements' not in value: # generic list, no way to check its contents updated_params[spec] = parameters[spec] else: # list of items of defined type try: normalized_list = ArgValidator.validate_list(value['elements'], parameters[spec]) except (TypeError, ValueError) as e: normalized_list = "ERROR" error_log.append(spec + ': ' + str(e)) updated_params[spec] = normalized_list else: # ordinary type try: normalized_value = ArgValidator.validate_item(argument_spec, parameters, spec) except (TypeError, ValueError) as e: normalized_value = "ERROR" error_log.append(spec + ': ' + str(e)) updated_params[spec] = normalized_value return (error_log, updated_params) def generate_combinations(input_list): # Create list of all valid combinations of parameters # (Note: 'valid' means 'worth exploring') # Fill in the stack with the first item to expand stack = [[{'path': input_list[0]['path'], 'indices': x, 'backtrack_indices': input_list[0]['backtrack_indices']}] for x in input_list[0]['indices']] result = [] while stack: sequence = stack.pop() for item in input_list[len(sequence)]['indices']: new_sequence = sequence + [{'path': input_list[len(sequence)]['path'], 'indices': item, 'backtrack_indices': input_list[len(sequence)]['backtrack_indices']}] if len(new_sequence) < len(input_list): stack.append(new_sequence) else: # sequence is complete, now to make sure the combination is valid # 'valid' means that all the same path roots have the same indices indices_pairs = {} for rule in new_sequence: encountered_index = indices_pairs.get(rule['path'][0], -1) if encountered_index == -1: # path not yet encountered indices_pairs[rule['path'][0]] = rule['indices'][0] elif encountered_index != rule['indices'][0]: # invalid combination break else: # for loop ended without break - combination is valid result.append(new_sequence) return result def locate_parameter(params, path, param_value): # path: complete path of searched parameter e.g. "['pools', 'volumes', 'deduplication']" # param_value: list of searched values or [] if value doesn't matter # returns list of "hash" of matching items or [] when not found # Stack. Each item consists of # - "value" - (part of) nested dictionary # - "level" - depth of nest (e.g. for "pool[1].volume[0].size": level=1 ~ "pool[1].volume[0]") # - "indices" - list of indices (e.g. for "pool[1].volume[0].size": indices == [1, 0, None]) stack = [{'value': params, 'level': 0, 'indices': []}] result = {'path': path, 'indices': []} while stack: stack_item = stack.pop() if stack_item['level'] < len(path): path_step = path[stack_item['level']] # Expand stack item item = stack_item['value'].get(path_step) if isinstance(item, list): # Push each list item back into the stack for idx in range(len(item)): stack.append({'value': item[idx], 'level': stack_item['level'] + 1, 'indices': stack_item['indices'] + [idx]}) else: # Push expanded item back into the stack stack.append({'value': item, 'level': stack_item['level'] + 1, 'indices': stack_item['indices'] + [None]}) else: # The end of given path if param_value == list() or stack_item['value'] in param_value: result['indices'].append(stack_item['indices']) if result['indices'] == []: return None return result def format_result(combo): rules_list = list() for rule in combo: path_list = rule['path'][0].split('.') indices = rule['backtrack_indices'] rule_str = "" for i in range(len(path_list)): rule_str += path_list[i] if i < len(indices) and indices[i] is not None: rule_str += '[' + str(indices[i]) + ']' rule_str += '.' rules_list.append(rule_str[:-1]) return rules_list def check_param_combos(params): all_combos = list() for combo in UNSUPPORTED_COMBOS: found_combos = list() recorded_matches = list() for key, value in combo['options'].items(): found = locate_parameter(params, key.split('.'), value) if found is None: # Locate found nothing => the whole combo is clean, no need to continue break else: recorded_matches.append(found) else: # No break happened in loop => need to check result combinations for match in recorded_matches: match['backtrack_indices'] = list() stack = [recorded_matches] while stack: match = stack.pop() combinations = generate_combinations(match) # It is now possible to dive by shifting the root one level for combination in combinations: shifted_combo = list() combo_found = True for rule in combination: if len(rule['path']) > 1: path = rule['path'][1:] path[0] = rule['path'][0] + '.' + path[0] indices = [rule['indices'][1:]] backtrack_indices = rule['backtrack_indices'] + [rule['indices'][0]] combo_found = False else: path = rule['path'] indices = [rule['indices']] backtrack_indices = rule['backtrack_indices'] shifted_combo.append({'path': path, 'indices': indices, 'backtrack_indices': backtrack_indices}) if combo_found: # Forbidden combination of parameters confirmed found_combos.append(format_result(combination)) else: stack.append(shifted_combo) if found_combos != list(): all_combos.append({'matches': found_combos, 'msg': combo['err_msg']}) return all_combos def validate_parameters(argument_spec, parameters, error_log=None, updated_params=None): errors, up_params = _validate_parameters(argument_spec, parameters) found_combos = check_param_combos(up_params) for combo in found_combos: errors.append('%s: %s' % (combo['msg'], combo['matches'])) return errors, up_params
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==module_utils.network_lsr.utils:[5:372] ==module_utils.network_lsr.utils:[5:372] __metaclass__ = type import socket import sys import uuid # pylint: disable=import-error, no-name-in-module from ansible.module_utils.network_lsr.myerror import MyError # noqa:E501 class Util: PY3 = sys.version_info[0] == 3 # pylint: disable=undefined-variable STRING_TYPE = str if PY3 else basestring # noqa:F821 @staticmethod def first(iterable, default=None, pred=None): for v in iterable: if pred is None or pred(v): return v return default @staticmethod def path_to_glib_bytes(path): """ Converts a path to a GLib.Bytes object that can be accepted by NM """ return Util.GLib().Bytes.new(("file://%s\x00" % path).encode("utf-8")) @staticmethod def convert_passwd_flags_nm(secret_flags): """ Converts an array of "secret flags" strings to an integer represantion understood by NetworkManager """ flag_int = 0 if "none" in secret_flags: flag_int += 0 if "agent-owned" in secret_flags: flag_int += 1 if "not-saved" in secret_flags: flag_int += 2 if "not-required" in secret_flags: flag_int += 4 return flag_int @classmethod def create_uuid(cls): return str(uuid.uuid4()) @classmethod def NM(cls): n = getattr(cls, "_NM", None) if n is None: # Installing pygobject in a tox virtualenv does not work out of the # box # pylint: disable=import-error import gi gi.require_version("NM", "1.0") from gi.repository import NM, GLib, Gio, GObject cls._NM = NM cls._GLib = GLib cls._Gio = Gio cls._GObject = GObject n = NM return n @classmethod def GLib(cls): cls.NM() return cls._GLib @classmethod def Gio(cls): cls.NM() return cls._Gio @classmethod def GObject(cls): cls.NM() return cls._GObject @classmethod def Timestamp(cls): return cls.GLib().get_monotonic_time() @classmethod def GMainLoop(cls): gmainloop = getattr(cls, "_GMainLoop", None) if gmainloop is None: gmainloop = cls.GLib().MainLoop() cls._GMainLoop = gmainloop return gmainloop @classmethod def GMainLoop_run(cls, timeout=None): if timeout is None: cls.GMainLoop().run() return True GLib = cls.GLib() timeout_reached = [] loop = cls.GMainLoop() def _timeout_cb(unused): timeout_reached.append(1) loop.quit() return False timeout_id = GLib.timeout_add(int(timeout * 1000), _timeout_cb, None) loop.run() if not timeout_reached: GLib.source_remove(timeout_id) return not timeout_reached @classmethod def GMainLoop_iterate(cls, may_block=False): return cls.GMainLoop().get_context().iteration(may_block) @classmethod def GMainLoop_iterate_all(cls): c = 0 while cls.GMainLoop_iterate(): c += 1 return c @classmethod def call_async_method(cls, object_, action, args, mainloop_timeout=10): """Asynchronously call a NetworkManager method""" cancellable = cls.create_cancellable() async_action = action + "_async" # NM does not use a uniform naming for the async methods, # for checkpoints it is: # NMClient.checkpoint_create() and NMClient.checkpoint_create_finish(), # but for reapply it is: # NMDevice.reapply_async() and NMDevice.reapply_finish() # NMDevice.reapply() is a synchronous version # Therefore check if there is a method if an `async` suffix and use the # one without the suffix otherwise if not hasattr(object_, async_action): async_action = action finish = action + "_finish" user_data = {} fullargs = [] fullargs += args fullargs += (cancellable, cls.create_callback(finish), user_data) getattr(object_, async_action)(*fullargs) if not cls.GMainLoop_run(mainloop_timeout): cancellable.cancel() raise MyError("failure to call %s.%s(): timeout" % (object_, async_action)) success = user_data.get("success", None) if success is not None: return success raise MyError( "failure to %s checkpoint: %s: %r" % (action, user_data.get("error", "unknown error"), user_data) ) @classmethod def create_cancellable(cls): return cls.Gio().Cancellable.new() @classmethod def create_callback(cls, finish_method): """ Create a callback that will return the result of the finish method and quit the GMainLoop :param finish_method str: Name of the finish method to call from the source object in the callback """ def callback(source_object, res, user_data): success = None try: success = getattr(source_object, finish_method)(res) except Exception as e: if cls.error_is_cancelled(e): return user_data["error"] = str(e) user_data["success"] = success cls.GMainLoop().quit() return callback @classmethod def error_is_cancelled(cls, e): GLib = cls.GLib() if isinstance(e, GLib.GError): if ( e.domain == "g-io-error-quark" and e.code == cls.Gio().IOErrorEnum.CANCELLED ): return True return False @staticmethod def ifname_valid(ifname): # see dev_valid_name() in kernel's net/core/dev.c if not ifname: return False if ifname in [".", ".."]: return False if len(ifname) >= 16: return False if any(c == "/" or c == ":" or c.isspace() for c in ifname): return False # FIXME: encoding issues regarding python unicode string return True @staticmethod def mac_aton(mac_str, force_len=None): # we also accept None and '' for convenience. # - None yiels None # - '' yields [] if mac_str is None: return mac_str i = 0 byte_array = [] for c in mac_str: if i == 2: if c != ":": raise MyError("not a valid MAC address: '%s'" % (mac_str)) i = 0 continue try: if i == 0: n = int(c, 16) * 16 i = 1 else: if not i == 1: raise AssertionError("i != 1 - value is {0}".format(i)) n = n + int(c, 16) i = 2 byte_array.append(n) except Exception: raise MyError("not a valid MAC address: '%s'" % (mac_str)) if i == 1: raise MyError("not a valid MAC address: '%s'" % (mac_str)) if force_len is not None: if force_len != len(byte_array): raise MyError( "not a valid MAC address of length %s: '%s'" % (force_len, mac_str) ) return byte_array @staticmethod def mac_ntoa(mac): if mac is None: return None # bytearray() is needed for python2 compatibility return ":".join(["%02x" % c for c in bytearray(mac)]) @staticmethod def mac_norm(mac_str, force_len=None): return Util.mac_ntoa(Util.mac_aton(mac_str, force_len)) @staticmethod def boolean(arg): if arg is None or isinstance(arg, bool): return arg arg0 = arg if isinstance(arg, Util.STRING_TYPE): arg = arg.lower() if arg in ["y", "yes", "on", "1", "true", 1, True]: return True if arg in ["n", "no", "off", "0", "false", 0, False]: return False raise MyError("value '%s' is not a boolean" % (arg0)) @staticmethod def parse_ip(addr, family=None): if addr is None: return (None, None) if family is not None: Util.addr_family_check(family) a = socket.inet_pton(family, addr) else: a = None family = None try: a = socket.inet_pton(socket.AF_INET, addr) family = socket.AF_INET except Exception: a = socket.inet_pton(socket.AF_INET6, addr) family = socket.AF_INET6 return (socket.inet_ntop(family, a), family) @staticmethod def addr_family_check(family): if family != socket.AF_INET and family != socket.AF_INET6: raise MyError("invalid address family %s" % (family)) @staticmethod def addr_family_to_v(family): if family is None: return "" if family == socket.AF_INET: return "v4" if family == socket.AF_INET6: return "v6" raise MyError("invalid address family '%s'" % (family)) @staticmethod def addr_family_default_prefix(family): Util.addr_family_check(family) if family == socket.AF_INET: return 24 else: return 64 @staticmethod def addr_family_norm(addr_family): if addr_family in [socket.AF_INET, socket.AF_INET6]: return addr_family if addr_family is None or addr_family == socket.AF_UNSPEC: return None if addr_family in ["4", "inet", "ip4", "ipv4", "IPv4"]: return socket.AF_INET if addr_family in ["6", "inet6", "ip6", "ipv6", "IPv6"]: return socket.AF_INET6 Util.addr_family_check(addr_family) @staticmethod def addr_family_prefix_length(family): addr_family = Util.addr_family_norm(family) if addr_family == socket.AF_INET: return 32 if addr_family == socket.AF_INET6: return 128 Util.addr_family_check(addr_family) @staticmethod def addr_family_valid_prefix(family, prefix): m = Util.addr_family_prefix_length(family) return prefix >= 0 and prefix <= m @staticmethod def parse_address(address, family=None): try: parts = address.split() addr_parts = parts[0].split("/") if len(addr_parts) != 2: raise MyError("expect two addr-parts: ADDR/PLEN") a, family = Util.parse_ip(addr_parts[0], family) prefix = int(addr_parts[1]) if not Util.addr_family_valid_prefix(family, prefix): raise MyError("invalid prefix %s" % (prefix)) if len(parts) > 1: raise MyError("too many parts") return {"address": a, "family": family, "prefix": prefix} except Exception: raise MyError("invalid address '%s'" % (address))
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint:[14:303] ==scripts.fix_ansible_lint:[14:303] class AnsibleLintFixer: def __init__(self, base_path: str = "."): self.base_path = Path(base_path) self.fixes_applied = [] def fix_trailing_spaces(self) -> int: """Remove trailing spaces from YAML files""" fixed_count = 0 yaml_files = list(self.base_path.glob("roles/**/*.yml")) + \ list(self.base_path.glob("roles/**/*.yaml")) for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: original_content = f.read() # Remove trailing spaces from each line lines = original_content.splitlines() fixed_lines = [line.rstrip() for line in lines] fixed_content = '\n'.join(fixed_lines) # Add final newline if missing if fixed_content and not fixed_content.endswith('\n'): fixed_content += '\n' if fixed_content != original_content: with open(file_path, 'w', encoding='utf-8') as f: f.write(fixed_content) fixed_count += 1 self.fixes_applied.append(f"Fixed trailing spaces in {file_path}") except Exception as e: print(f"Error fixing trailing spaces in {file_path}: {e}") return fixed_count def fix_handler_names(self) -> int: """Fix handler name casing to start with uppercase""" fixed_count = 0 handler_files = list(self.base_path.glob("roles/**/handlers/main.yml")) for file_path in handler_files: try: with open(file_path, 'r', encoding='utf-8') as f: content = f.read() # Fix handler names to start with uppercase # Pattern: - name: lowercase_name def fix_name_case(match): name = match.group(1) if name and name[0].islower(): return f'- name: {name[0].upper()}{name[1:]}' return match.group(0) fixed_content = re.sub(r'- name: ([^A-Z][^\n]*)', fix_name_case, content) if fixed_content != content: with open(file_path, 'w', encoding='utf-8') as f: f.write(fixed_content) fixed_count += 1 self.fixes_applied.append(f"Fixed handler name casing in {file_path}") except Exception as e: print(f"Error fixing handler names in {file_path}: {e}") return fixed_count def fix_meta_galaxy_info(self) -> int: """Fix meta/main.yml galaxy_info issues""" fixed_count = 0 meta_files = list(self.base_path.glob("roles/**/meta/main.yml")) for file_path in meta_files: try: with open(file_path, 'r', encoding='utf-8') as f: content = f.read() original_content = content # Fix min_ansible_version to be string content = re.sub(r'min_ansible_version:\s*(\d+\.\d+)', r'min_ansible_version: "\1"', content) # Fix platform versions for RHEL-like systems rhel_versions = ["7", "8", "9", "10"] for version in rhel_versions: if f"'{version}'" in content: # Replace invalid versions with 'all' content = re.sub(f"'{version}'", "'all'", content) elif f'"{version}"' in content: content = re.sub(f'"{version}"', '"all"', content) if content != original_content: with open(file_path, 'w', encoding='utf-8') as f: f.write(content) fixed_count += 1 self.fixes_applied.append(f"Fixed meta galaxy_info in {file_path}") except Exception as e: print(f"Error fixing meta file {file_path}: {e}") return fixed_count def fix_jinja_spacing(self) -> int: """Fix Jinja2 template spacing issues""" fixed_count = 0 yaml_files = list(self.base_path.glob("roles/**/*.yml")) for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: content = f.read() original_content = content # Fix common Jinja spacing issues # {{ var|filter }} -> {{ var | filter }} content = re.sub(r'\{\{\s*([^}]+)\|([^}]+)\s*\}\}', r'{{ \1 | \2 }}', content) if content != original_content: with open(file_path, 'w', encoding='utf-8') as f: f.write(content) fixed_count += 1 self.fixes_applied.append(f"Fixed Jinja spacing in {file_path}") except Exception as e: print(f"Error fixing Jinja spacing in {file_path}: {e}") return fixed_count def fix_yaml_truthy_values(self) -> int: """Fix YAML truthy values to use true/false""" fixed_count = 0 yaml_files = list(self.base_path.glob("roles/**/*.yml")) truthy_replacements = { r'\byes\b': 'true', r'\bno\b': 'false', r'\bYes\b': 'true', r'\bNo\b': 'false', r'\bYES\b': 'true', r'\bNO\b': 'false', r'\bon\b': 'true', r'\boff\b': 'false', } for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: content = f.read() original_content = content for pattern, replacement in truthy_replacements.items(): # Only replace when it's a YAML value (after colon) content = re.sub(f'(:\\s*){pattern}(\\s*$)', f'\\1{replacement}\\2', content, flags=re.MULTILINE) if content != original_content: with open(file_path, 'w', encoding='utf-8') as f: f.write(content) fixed_count += 1 self.fixes_applied.append(f"Fixed YAML truthy values in {file_path}") except Exception as e: print(f"Error fixing YAML truthy values in {file_path}: {e}") return fixed_count def create_missing_validation_files(self) -> int: """Create missing validation files that cause load-failure errors""" fixed_count = 0 missing_files = [ "roles/kvmhost_base/tasks/validation/validation/schema_validation_base.yml", "roles/kvmhost_networking/tasks/validation/validation/schema_validation_networking.yml", "roles/kvmhost_setup/tasks/validation/validation/schema_validation.yml" ] validation_template = """--- # Schema validation placeholder # This file was auto-generated to resolve ansible-lint load-failure errors # TODO: Implement proper schema validation logic - name: Schema validation placeholder debug: msg: "Schema validation not yet implemented" tags: - validation - schema """ for file_path in missing_files: full_path = self.base_path / file_path if not full_path.exists(): try: full_path.parent.mkdir(parents=True, exist_ok=True) with open(full_path, 'w', encoding='utf-8') as f: f.write(validation_template) fixed_count += 1 self.fixes_applied.append(f"Created missing validation file {file_path}") except Exception as e: print(f"Error creating {file_path}: {e}") return fixed_count def fix_line_length_issues(self) -> int: """Fix basic line length issues by adding line breaks""" fixed_count = 0 yaml_files = list(self.base_path.glob("roles/**/*.yml")) for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: lines = f.readlines() fixed_lines = [] changed = False for line in lines: if len(line.rstrip()) > 160: # Simple fix for long URLs or strings if 'http' in line and '- name:' in line: # Split long task names indent = len(line) - len(line.lstrip()) if ': ' in line: key, value = line.split(': ', 1) if len(value.strip()) > 100: fixed_lines.append(f"{key}: >\n") fixed_lines.append(f"{' ' * (indent + 2)}{value}") changed = True continue fixed_lines.append(line) if changed: with open(file_path, 'w', encoding='utf-8') as f: f.writelines(fixed_lines) fixed_count += 1 self.fixes_applied.append(f"Fixed line length issues in {file_path}") except Exception as e: print(f"Error fixing line length in {file_path}: {e}") return fixed_count def run_all_fixes(self) -> Dict[str, int]: """Run all automated fixes""" print("🔧 Starting automated ansible-lint fixes...") results = { "trailing_spaces": self.fix_trailing_spaces(), "handler_names": self.fix_handler_names(), "meta_galaxy_info": self.fix_meta_galaxy_info(), "jinja_spacing": self.fix_jinja_spacing(), "yaml_truthy": self.fix_yaml_truthy_values(), "missing_files": self.create_missing_validation_files(), "line_length": self.fix_line_length_issues(), } total_fixes = sum(results.values()) print(f"\n✅ Automated fixes completed!") print(f"📊 Summary:") for fix_type, count in results.items(): if count > 0: print(f" - {fix_type.replace('_', ' ').title()}: {count} files") print(f"\n🎯 Total files fixed: {total_fixes}") if self.fixes_applied: print(f"\n📝 Applied fixes:") for fix in self.fixes_applied[:10]: # Show first 10 print(f" - {fix}") if len(self.fixes_applied) > 10: print(f" ... and {len(self.fixes_applied) - 10} more") return results def main(): fixer = AnsibleLintFixer() results = fixer.run_all_fixes() print(f"\n🔍 Run 'ansible-lint roles/' again to see remaining issues") return 0 if sum(results.values()) > 0 else 1 if __name__ == "__main__": sys.exit(main())
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.generate_compatibility_matrix:[15:282] ==scripts.generate_compatibility_matrix:[15:282] class CompatibilityMatrix: def __init__(self, project_root="/home/vpcuser/qubinode_kvmhost_setup_collection"): self.project_root = Path(project_root) self.roles_dir = self.project_root / "roles" self.compatibility_data = {} def detect_rhel_versions(self): """Detect supported RHEL versions from role tasks and vars""" rhel_versions = set() # Common RHEL version patterns version_patterns = ["rhel8", "rhel9", "rhel10", "el8", "el9", "el10"] for role_dir in self.roles_dir.iterdir(): if role_dir.is_dir() and role_dir.name.startswith("kvmhost_"): # Check tasks for version-specific logic tasks_dir = role_dir / "tasks" if tasks_dir.exists(): for task_file in tasks_dir.glob("*.yml"): try: with open(task_file, 'r') as f: content = f.read() for pattern in version_patterns: if pattern in content.lower(): # Extract version number if "rhel8" in pattern or "el8" in pattern: rhel_versions.add("8") elif "rhel9" in pattern or "el9" in pattern: rhel_versions.add("9") elif "rhel10" in pattern or "el10" in pattern: rhel_versions.add("10") except Exception as e: print(f"Warning: Could not read {task_file}: {e}") # Default to supporting 8, 9, 10 if no specific versions found if not rhel_versions: rhel_versions = {"8", "9", "10"} return sorted(list(rhel_versions)) def analyze_role_features(self, role_name): """Analyze features and compatibility for a specific role""" role_path = self.roles_dir / role_name features = {} if not role_path.exists(): return features # Analyze defaults/main.yml for feature flags defaults_file = role_path / "defaults" / "main.yml" if defaults_file.exists(): try: with open(defaults_file, 'r') as f: defaults = yaml.safe_load(f) or {} # Look for feature-related variables for key, value in defaults.items(): if any(keyword in key.lower() for keyword in ['enable', 'install', 'configure', 'feature']): features[key] = { 'default': value, 'description': f"Feature flag for {key}", 'rhel_compatibility': {} } except Exception as e: print(f"Warning: Could not parse {defaults_file}: {e}") # Analyze tasks for version-specific features tasks_dir = role_path / "tasks" if tasks_dir.exists(): for task_file in tasks_dir.glob("*.yml"): try: with open(task_file, 'r') as f: content = f.read() # Extract feature names from task file names feature_name = task_file.stem if feature_name not in features: features[feature_name] = { 'description': f"Task group: {feature_name}", 'rhel_compatibility': {} } # Check for RHEL version conditions rhel_versions = self.detect_rhel_versions() for version in rhel_versions: version_supported = True # Look for version-specific conditions if f"rhel{version}" in content.lower() or f"el{version}" in content.lower(): version_supported = True elif "when:" in content and "ansible_distribution_major_version" in content: # More sophisticated parsing could be added here version_supported = True features[feature_name]['rhel_compatibility'][f"rhel{version}"] = { 'supported': version_supported, 'notes': f"Detected from {task_file.name}" } except Exception as e: print(f"Warning: Could not analyze {task_file}: {e}") return features def generate_matrix(self): """Generate the complete compatibility matrix""" rhel_versions = self.detect_rhel_versions() matrix = { 'metadata': { 'generated_date': str(subprocess.check_output(['date', '+%Y-%m-%d %H:%M:%S']).decode().strip()), 'project': 'Qubinode KVM Host Setup Collection', 'rhel_versions_detected': rhel_versions, 'generator_version': '1.0.0' }, 'compatibility_matrix': {} } # Analyze each kvmhost role for role_dir in self.roles_dir.iterdir(): if role_dir.is_dir() and role_dir.name.startswith("kvmhost_"): role_name = role_dir.name print(f"Analyzing role: {role_name}") role_features = self.analyze_role_features(role_name) matrix['compatibility_matrix'][role_name] = { 'description': f"KVM Host setup role for {role_name.replace('kvmhost_', '')}", 'features': role_features, 'overall_compatibility': {} } # Calculate overall compatibility per RHEL version for version in rhel_versions: supported_features = 0 total_features = len(role_features) for feature_name, feature_data in role_features.items(): rhel_compat = feature_data.get('rhel_compatibility', {}) if rhel_compat.get(f"rhel{version}", {}).get('supported', True): supported_features += 1 compatibility_percentage = (supported_features / total_features * 100) if total_features > 0 else 100 matrix['compatibility_matrix'][role_name]['overall_compatibility'][f"rhel{version}"] = { 'supported_features': supported_features, 'total_features': total_features, 'compatibility_percentage': round(compatibility_percentage, 2), 'status': 'full' if compatibility_percentage == 100 else 'partial' if compatibility_percentage > 50 else 'limited' } return matrix def save_matrix(self, output_file="compatibility_matrix.json"): """Save the compatibility matrix to a file""" matrix = self.generate_matrix() output_path = self.project_root / "docs" / output_file # Ensure docs directory exists output_path.parent.mkdir(exist_ok=True) with open(output_path, 'w') as f: json.dump(matrix, f, indent=2) print(f"Compatibility matrix saved to: {output_path}") return output_path def generate_report(self): """Generate a human-readable compatibility report""" matrix = self.generate_matrix() report_lines = [] report_lines.append("# RHEL Compatibility Matrix Report") report_lines.append(f"**Generated**: {matrix['metadata']['generated_date']}") report_lines.append(f"**Project**: {matrix['metadata']['project']}") report_lines.append("") # Summary table report_lines.append("## Compatibility Summary") report_lines.append("") report_lines.append("| Role | RHEL 8 | RHEL 9 | RHEL 10 | Notes |") report_lines.append("|------|--------|--------|---------|-------|") for role_name, role_data in matrix['compatibility_matrix'].items(): compat = role_data['overall_compatibility'] rhel8_status = compat.get('rhel8', {}).get('status', 'unknown') rhel9_status = compat.get('rhel9', {}).get('status', 'unknown') rhel10_status = compat.get('rhel10', {}).get('status', 'unknown') # Convert status to emoji status_emoji = {'full': '✅', 'partial': '⚠️', 'limited': '❌', 'unknown': '❓'} rhel8_emoji = status_emoji.get(rhel8_status, '❓') rhel9_emoji = status_emoji.get(rhel9_status, '❓') rhel10_emoji = status_emoji.get(rhel10_status, '❓') notes = f"{rhel8_status.title()}/{rhel9_status.title()}/{rhel10_status.title()}" report_lines.append(f"| {role_name} | {rhel8_emoji} | {rhel9_emoji} | {rhel10_emoji} | {notes} |") # Detailed breakdown report_lines.append("") report_lines.append("## Detailed Analysis") for role_name, role_data in matrix['compatibility_matrix'].items(): report_lines.append(f"### {role_name}") report_lines.append(f"*{role_data['description']}*") report_lines.append("") # Feature compatibility table features = role_data['features'] if features: report_lines.append("| Feature | RHEL 8 | RHEL 9 | RHEL 10 |") report_lines.append("|---------|--------|--------|---------|") for feature_name, feature_data in features.items(): rhel_compat = feature_data.get('rhel_compatibility', {}) rhel8_support = rhel_compat.get('rhel8', {}).get('supported', True) rhel9_support = rhel_compat.get('rhel9', {}).get('supported', True) rhel10_support = rhel_compat.get('rhel10', {}).get('supported', True) rhel8_icon = '✅' if rhel8_support else '❌' rhel9_icon = '✅' if rhel9_support else '❌' rhel10_icon = '✅' if rhel10_support else '❌' report_lines.append(f"| {feature_name} | {rhel8_icon} | {rhel9_icon} | {rhel10_icon} |") else: report_lines.append("*No specific features detected*") report_lines.append("") return '\n'.join(report_lines) def save_report(self, output_file="compatibility_report.md"): """Save the human-readable report""" report = self.generate_report() output_path = self.project_root / "docs" / output_file with open(output_path, 'w') as f: f.write(report) print(f"Compatibility report saved to: {output_path}") return output_path def main(): """Main function to generate compatibility matrix""" print("Generating RHEL Compatibility Matrix...") matrix_generator = CompatibilityMatrix() # Generate and save JSON matrix json_path = matrix_generator.save_matrix() # Generate and save human-readable report report_path = matrix_generator.save_report() print("\n" + "="*50) print("COMPATIBILITY MATRIX GENERATION COMPLETE") print("="*50) print(f"JSON Matrix: {json_path}") print(f"Report: {report_path}") print("\nNext steps:") print("1. Review the generated compatibility report") print("2. Add version-specific tests to your Molecule scenarios") print("3. Update role documentation with compatibility info") print("4. Integrate with CI/CD for automated compatibility testing") if __name__ == "__main__": main()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.validate_container_compatibility:[14:255] ==scripts.validate_container_compatibility:[14:255] class ContainerCompatibilityValidator: def __init__(self): self.test_results = { 'timestamp': time.strftime('%Y-%m-%d %H:%M:%S'), 'platform_tests': {}, 'detection_tests': {}, 'task_skipping_tests': {}, 'overall_status': 'unknown' } def run_command(self, cmd, timeout=30): """Run a command with timeout and capture output""" try: result = subprocess.run( cmd, shell=True, capture_output=True, text=True, timeout=timeout ) return { 'success': result.returncode == 0, 'stdout': result.stdout, 'stderr': result.stderr, 'returncode': result.returncode } except subprocess.TimeoutExpired: return { 'success': False, 'stdout': '', 'stderr': 'Command timed out', 'returncode': -1 } def check_container_running(self, container_name): """Check if a container is running""" result = self.run_command(f"podman ps --filter name={container_name} --format json") if result['success'] and result['stdout'].strip(): try: containers = json.loads(result['stdout']) return len(containers) > 0 except json.JSONDecodeError: return False return False def test_container_detection(self, container_name): """Test container detection logic in a specific container""" print(f"🔍 Testing container detection in {container_name}...") # Test the container detection playbook detection_cmd = f""" podman exec {container_name} ansible-playbook -i localhost, -c local \\ /tmp/test_container_detection.yml --extra-vars "target_host=localhost" """ result = self.run_command(detection_cmd, timeout=60) test_result = { 'container': container_name, 'detection_success': result['success'], 'output': result['stdout'], 'errors': result['stderr'] } # Parse the output for specific detection criteria if result['success']: output = result['stdout'] test_result['virtualization_detected'] = 'container' in output.lower() test_result['container_environment_detected'] = 'is_container_environment' in output test_result['task_skipping_active'] = 'skipped' in output.lower() self.test_results['detection_tests'][container_name] = test_result return result['success'] def test_role_execution(self, container_name): """Test that the kvmhost_setup role runs without errors in container""" print(f"🧪 Testing role execution in {container_name}...") # Create a minimal test playbook test_playbook = f""" --- - name: Test KVM Host Setup in Container hosts: localhost connection: local become: true vars: admin_user: test domain: test.local roles: - kvmhost_setup """ # Copy test playbook to container self.run_command(f"echo '{test_playbook}' | podman exec -i {container_name} tee /tmp/test_role.yml") # Run the role test role_cmd = f""" podman exec {container_name} ansible-playbook -i localhost, -c local /tmp/test_role.yml """ result = self.run_command(role_cmd, timeout=300) # 5 minutes timeout for role execution test_result = { 'container': container_name, 'role_execution_success': result['success'], 'output': result['stdout'], 'errors': result['stderr'] } # Count how many tasks were skipped due to container detection if result['stdout']: skipped_count = result['stdout'].count('skipped') test_result['tasks_skipped'] = skipped_count test_result['container_appropriate_execution'] = skipped_count > 0 self.test_results['task_skipping_tests'][container_name] = test_result return result['success'] def validate_container_platform(self, container_name): """Validate a specific container platform""" print(f"\n🐳 Validating container platform: {container_name}") if not self.check_container_running(container_name): print(f"❌ Container {container_name} is not running") self.test_results['platform_tests'][container_name] = { 'available': False, 'detection_test': False, 'role_test': False, 'overall': 'failed' } return False print(f"✅ Container {container_name} is running") # Test container detection detection_success = self.test_container_detection(container_name) # Test role execution role_success = self.test_role_execution(container_name) overall_success = detection_success and role_success self.test_results['platform_tests'][container_name] = { 'available': True, 'detection_test': detection_success, 'role_test': role_success, 'overall': 'passed' if overall_success else 'failed' } status_icon = "✅" if overall_success else "❌" print(f"{status_icon} Platform {container_name}: {'PASSED' if overall_success else 'FAILED'}") return overall_success def run_validation(self): """Run the complete container compatibility validation""" print("🚀 Starting Container Compatibility Validation") print("=" * 60) # Define containers to test (should match our Molecule setup) test_containers = ['rocky-9', 'alma-9', 'rhel-9', 'rhel-10'] validation_results = [] for container in test_containers: success = self.validate_container_platform(container) validation_results.append(success) # Calculate overall results total_tests = len(test_containers) passed_tests = sum(validation_results) self.test_results['overall_status'] = 'passed' if passed_tests == total_tests else 'partial' if passed_tests > 0 else 'failed' print("\n" + "=" * 60) print("🎯 Container Compatibility Validation Summary") print("=" * 60) for container in test_containers: platform_result = self.test_results['platform_tests'].get(container, {}) status = platform_result.get('overall', 'unknown') icon = "✅" if status == 'passed' else "❌" if status == 'failed' else "⚠️" print(f"{icon} {container:<15} - {status.upper()}") print(f"\n📊 Results: {passed_tests}/{total_tests} platforms passed") # Print detailed analysis print("\n🔍 Detailed Analysis:") # Container detection analysis detection_success = sum(1 for t in self.test_results['detection_tests'].values() if t.get('detection_success', False)) print(f"🎯 Container Detection: {detection_success}/{len(self.test_results['detection_tests'])} successful") # Task skipping analysis task_skipping_success = sum(1 for t in self.test_results['task_skipping_tests'].values() if t.get('container_appropriate_execution', False)) print(f"⏭️ Task Skipping: {task_skipping_success}/{len(self.test_results['task_skipping_tests'])} appropriate") # Overall status if self.test_results['overall_status'] == 'passed': print("\n🎉 ✅ ALL CONTAINER PLATFORMS VALIDATED SUCCESSFULLY") return True elif self.test_results['overall_status'] == 'partial': print("\n⚠️ PARTIAL SUCCESS - Some platforms failed validation") return False else: print("\n❌ VALIDATION FAILED - Critical issues detected") return False def save_results(self, output_file="container-compatibility-validation.json"): """Save validation results to file""" with open(output_file, 'w') as f: json.dump(self.test_results, f, indent=2) print(f"\n📄 Detailed results saved to: {output_file}") def main(): """Main execution function""" validator = ContainerCompatibilityValidator() # First, ensure our test container detection playbook exists if not Path('test_container_detection.yml').exists(): print("❌ test_container_detection.yml not found - creating basic version") basic_test = """--- - name: Test Container Detection hosts: "{{ target_host | default('localhost') }}" gather_facts: true tasks: - name: Advanced container environment detection ansible.builtin.set_fact: is_container_environment: >- {{ ansible_virtualization_type in ['container', 'docker', 'podman', 'lxc'] or ansible_env.container is defined or ansible_facts.get('ansible_proc_cmdline', {}).get('init', '') == '/usr/sbin/init' or (ansible_mounts | selectattr('mount', 'equalto', '/') | first).fstype in ['overlay', 'tmpfs'] or ansible_facts.get('ansible_selinux', {}).get('type', '') == 'docker_t' }} - name: Display detection results ansible.builtin.debug: msg: | Container Detection Results: - Virtualization Type: {{ ansible_virtualization_type | default('unknown') }} - Container Environment: {{ is_container_environment }} - Host: {{ inventory_hostname }}
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.print_all_options:[12:180] ==scripts.print_all_options:[12:180] PRIORITIES = ( "name", "type", "interface_name", "mac", "state", "persistent_state", "controller", "port_type", "parent", "ignore_errors", "force_state_change", "check_iface_exists", "autoconnect", "wait", "zone", "mtu", "ip", "ethernet", "ethtool", "bridge", "bond", "team", "vlan", "wireless", "macvlan", "infiniband", ) import yaml parentdir = os.path.normpath(os.path.join(os.path.dirname(__file__), "..")) with mock.patch.object( sys, "path", [parentdir, os.path.join(parentdir, "module_utils/network_lsr")] + sys.path, ): with mock.patch.dict( "sys.modules", {"ansible": mock.Mock(), "ansible.module_utils": __import__("module_utils")}, ): import argument_validator as av COMMENT = "@@" EMPTY = "/EMPTY/" def parse_validator(validator): default = validator.default_value if isinstance(validator, av.ArgValidatorDict): res = {} for k, v in validator.nested.items(): if v.name not in ( "infiniband_transport_mode", "infiniband_p_key", "vlan_id", ) and not isinstance(v, av.ArgValidatorDeprecated): name = k if not validator.required: pass # name += " DICT optional" res[name] = parse_validator(v) elif isinstance(validator, av.ArgValidatorList): res = [parse_validator(validator.nested)] elif isinstance(validator, av.ArgValidatorNum): minval = validator.val_min maxval = validator.val_max comment = f" {COMMENT}" if not validator.required: comment += " optional" if minval is not None: comment += " minimum=" + str(minval) if maxval: if maxval == 0xFFFFFFFF: maxval = hex(maxval) comment += " maximum=" + str(maxval) if default is not None: res = str(default) elif minval is not None: res = str(minval) elif maxval is not None: res = str(maxval) else: res = "" res += comment elif isinstance(validator, av.ArgValidatorIP): res = f"{EMPTY} {COMMENT} IP Address" elif isinstance(validator, av.ArgValidatorStr): if default: res = default elif validator.enum_values: res = "|".join(validator.enum_values) else: res = EMPTY if not validator.required: res += f" {COMMENT} optional" # res += " " + str(validator.__class__) elif isinstance(validator, av.ArgValidatorBool): if default is not None: res = "yes" if default else "no" else: res = "yes|no" if not validator.required: res += f" {COMMENT} optional" else: res = validator.name + f" {COMMENT} FIXME " + str(validator.__class__) return res def represent_dict(dumper, data): """ Represent dictionary with insert order """ value = [] for item_key, item_value in data.items(): node_key = dumper.represent_data(item_key) node_value = dumper.represent_data(item_value) value.append((node_key, node_value)) return yaml.nodes.MappingNode("tag:yaml.org,2002:map", value) def priority_sorted(data): if isinstance(data, Sequence) and not isinstance(data, str): return [priority_sorted(item) for item in data] if isinstance(data, Mapping): sorted_data = {} for key in sorted(data, key=prioritize): sorted_data[key] = priority_sorted(data[key]) return sorted_data return deepcopy(data) def prioritize(key): try: priority = PRIORITIES.index(key) except ValueError: priority = len(PRIORITIES) return (priority, key) yaml.add_representer(dict, represent_dict) sorted_data = priority_sorted([parse_validator(av.ArgValidator_DictConnection())]) yaml_example = ( yaml.dump( sorted_data, explicit_start=True, default_flow_style=False, width=100, ) .replace(COMMENT, "#") .replace(EMPTY, "") ) # yaml_example = re.sub(r"# ([^:]*):", r": # \1", yaml_example) print(yaml_example)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==module_utils.network_lsr.nm.active_connection:[6:123] ==module_utils.network_lsr.nm.active_connection:[6:123] __metaclass__ = type import logging # Relative import is not support by ansible 2.8 yet # pylint: disable=import-error, no-name-in-module from ansible.module_utils.network_lsr.nm import client # noqa:E501 from ansible.module_utils.network_lsr.nm import error # noqa:E501 # pylint: enable=import-error, no-name-in-module NM_AC_STATE_CHANGED_SIGNAL = "state-changed" def deactivate_active_connection(nm_ac, timeout, check_mode): if not nm_ac or nm_ac.props.state == client.NM.ActiveConnectionState.DEACTIVATED: logging.info("Connection is not active, no need to deactivate") return False if not check_mode: main_loop = client.get_mainloop(timeout) logging.debug("Deactivating %s with timeout %s", nm_ac.get_id(), timeout) user_data = main_loop handler_id = nm_ac.connect( NM_AC_STATE_CHANGED_SIGNAL, _nm_ac_state_change_callback, user_data ) logging.debug( "Registered %s on client.NM.ActiveConnection %s", NM_AC_STATE_CHANGED_SIGNAL, nm_ac.get_id(), ) if nm_ac.props.state != client.NM.ActiveConnectionState.DEACTIVATING: nm_client = client.get_client() user_data = (main_loop, nm_ac, nm_ac.get_id(), handler_id) nm_client.deactivate_connection_async( nm_ac, main_loop.cancellable, _nm_ac_deactivate_call_back, user_data, ) logging.debug("Deactivating client.NM.ActiveConnection %s", nm_ac.get_id()) main_loop.run() return True def _nm_ac_state_change_callback(nm_ac, state, reason, user_data): main_loop = user_data if main_loop.is_cancelled: return logging.debug( "Got client.NM.ActiveConnection state change: %s: %s %s", nm_ac.get_id(), state, reason, ) if nm_ac.props.state == client.NM.ActiveConnectionState.DEACTIVATED: logging.debug("client.NM.ActiveConnection %s is deactivated", nm_ac.get_id()) main_loop.quit() def _nm_ac_deactivate_call_back(nm_client, result, user_data): main_loop, nm_ac, nm_ac_id, handler_id = user_data logging.debug("client.NM.ActiveConnection deactivating callback") if main_loop.is_cancelled: if nm_ac: nm_ac.handler_disconnect(handler_id) return try: success = nm_client.deactivate_connection_finish(result) except client.GLib.Error as e: if e.matches( client.NM.ManagerError.quark(), client.NM.ManagerError.CONNECTIONNOTACTIVE ): logging.info( "Connection is not active on %s, no need to deactivate", nm_ac_id ) if nm_ac: nm_ac.handler_disconnect(handler_id) main_loop.quit() return else: _deactivate_fail( main_loop, handler_id, nm_ac, "Failed to deactivate connection {id}, error={error}".format( id=nm_ac_id, error=e ), ) return except Exception as e: _deactivate_fail( main_loop, handler_id, nm_ac, "Failed to deactivate connection {id}, error={error}".format( id=nm_ac_id, error=e ), ) return if not success: _deactivate_fail( main_loop, handler_id, nm_ac, "Failed to deactivate connection {0}, error='None " "returned from deactivate_connection_finish()'".format(nm_ac_id), ) def _deactivate_fail(main_loop, handler_id, nm_ac, msg): if nm_ac: nm_ac.handler_disconnect(handler_id) logging.error(msg) main_loop.fail(error.LsrNetworkNmError(msg))
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==module_utils.network_lsr.nm.connection:[6:119] ==module_utils.network_lsr.nm.connection:[6:119] __metaclass__ = type import logging # Relative import is not support by ansible 2.8 yet # pylint: disable=import-error, no-name-in-module from ansible.module_utils.network_lsr.nm import client # noqa:E501 from ansible.module_utils.network_lsr.nm import error # noqa:E501 # pylint: enable=import-error, no-name-in-module def delete_remote_connection(nm_profile, timeout, check_mode): if not nm_profile: logging.info("NULL NM.RemoteConnection, no need to delete") return False if not check_mode: main_loop = client.get_mainloop(timeout) user_data = main_loop nm_profile.delete_async( main_loop.cancellable, _nm_profile_delete_call_back, user_data, ) logging.debug( "Deleting profile %s/%s with timeout %s", nm_profile.get_id(), nm_profile.get_uuid(), timeout, ) main_loop.run() return True def _nm_profile_delete_call_back(nm_profile, result, user_data): main_loop = user_data if main_loop.is_cancelled: return try: success = nm_profile.delete_finish(result) except Exception as e: main_loop.fail( error.LsrNetworkNmError( "Connection deletion aborted on {id}/{uuid}: error={error}".format( id=nm_profile.get_id(), uuid=nm_profile.get_uuid(), error=e ) ) ) if success: main_loop.quit() else: main_loop.fail( error.LsrNetworkNmError( "Connection deletion aborted on {id}/{uuid}: error=unknown".format( id=nm_profile.get_id(), uuid=nm_profile.get_uuid() ) ) ) def volatilize_remote_connection(nm_profile, timeout, check_mode): if not nm_profile: logging.info("NULL NM.RemoteConnection, no need to volatilize") return False if not check_mode: main_loop = client.get_mainloop(timeout) user_data = main_loop nm_profile.update2( None, # settings client.NM.SettingsUpdate2Flags.IN_MEMORY_ONLY | client.NM.SettingsUpdate2Flags.VOLATILE, None, # args main_loop.cancellable, _nm_profile_volatile_update2_call_back, user_data, ) logging.debug( "Volatilizing profile %s/%s with timeout %s", nm_profile.get_id(), nm_profile.get_uuid(), timeout, ) main_loop.run() return True def _nm_profile_volatile_update2_call_back(nm_profile, result, user_data): main_loop = user_data if main_loop.is_cancelled: return try: success = nm_profile.update2_finish(result) except Exception as e: main_loop.fail( error.LsrNetworkNmError( "Connection volatilize aborted on {id}/{uuid}: error={error}".format( id=nm_profile.get_id(), uuid=nm_profile.get_uuid(), error=e ) ) ) if success: main_loop.quit() else: main_loop.fail( error.LsrNetworkNmError( "Connection volatilize aborted on {id}/{uuid}: error=unknown".format( id=nm_profile.get_id(), uuid=nm_profile.get_uuid() ) ) )
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==storage_lsr.size:[2:167] ==storage_lsr.size:[2:167] __metaclass__ = type import re DECIMAL_FACTOR = 10**3 BINARY_FACTOR = 2**10 # index of the item in the list determines the exponent for size computation # e.g. size_in_bytes = value * (DECIMAL_FACTOR ** (index(mega)+1)) = value * (1000 ** (1+1)) PREFIXES_DECIMAL = [ ["k", "M", "G", "T", "P", "E", "Z", "Y"], ["kilo", "mega", "giga", "tera", "peta", "exa", "zetta", "yotta"], ] PREFIXES_BINARY = [ ["Ki", "Mi", "Gi", "Ti", "Pi", "Ei", "Zi", "Yi"], ["kibi", "mebi", "gibi", "tebi", "pebi", "exbi", "zebi", "yobi"], ] SUFFIXES = ["bytes", "byte", "B"] class Size(object): """Class for basic manipulation of the sizes in *bytes""" def __init__(self, value): raw_number, raw_units = self._parse_input(str(value)) self.factor, self.exponent = self._parse_units(raw_units) self.number = self._parse_number(raw_number) self.units = raw_units def _parse_input(self, value): """splits input string into number and unit parts returns number part, unit part """ m = re.search("^(.*?)([^0-9]*)$", value) raw_number = m.group(1).strip() if raw_number == "": raise ValueError("The string '%s' does not contain size" % value) raw_units = m.group(2).strip() return raw_number, raw_units def _parse_units(self, raw_units): """ gets string containing size units and returns *_FACTOR (BINARY or DECIMAL) and the prefix position (not index!) in the PREFIXES_* list If no unit is specified defaults to BINARY and Bytes """ prefix = raw_units no_suffix_flag = True valid_suffix = False used_factor = BINARY_FACTOR # get rid of possible units suffix ('bytes', 'b' or 'B') for suffix in SUFFIXES: if raw_units.lower().endswith(suffix.lower()): no_suffix_flag = False prefix = raw_units[: -len(suffix)] break if prefix == "": # no unit was specified, use default return BINARY_FACTOR, 0 # check the list for units idx = -1 for lst in PREFIXES_DECIMAL: lower_lst = [x.lower() for x in lst] if prefix.lower() in lower_lst: valid_suffix = True idx = lower_lst.index(prefix.lower()) used_factor = DECIMAL_FACTOR break if idx < 0 or no_suffix_flag: if no_suffix_flag: used_factor = BINARY_FACTOR for lst in PREFIXES_BINARY: lower_lst = [x.lower() for x in lst] if prefix.lower() in lower_lst: valid_suffix = True idx = lower_lst.index(prefix.lower()) used_factor = BINARY_FACTOR break if idx < 0 or not valid_suffix: raise ValueError("Unable to identify unit '%s'" % raw_units) return used_factor, idx + 1 def _parse_number(self, raw_number): """parse input string containing number return float """ return float(raw_number) def _get_unit(self, factor, exponent, unit_type=0): """based on decimal or binary factor and exponent obtain and return correct unit """ if unit_type == 0: suffix = "B" else: suffix = "bytes" if exponent == 0: return suffix if factor == DECIMAL_FACTOR: prefix_lst = PREFIXES_DECIMAL[unit_type] else: prefix_lst = PREFIXES_BINARY[unit_type] return prefix_lst[exponent - 1] + suffix @property def bytes(self): """returns size value in bytes as int""" return int((self.factor**self.exponent) * self.number) def _format(self, format_str, factor, exponent): result = format_str result = result.replace(r"%sb", self._get_unit(factor, exponent, 0)) result = result.replace(r"%lb", self._get_unit(factor, exponent, 1)) return result def get(self, units="autobin", fmt="%0.1f %sb"): """returns size value as a string with given units and format "units" parameter allows to select preferred unit: for example "KiB" or "megabytes" accepted values are also: "autobin" (default) - uses the highest human readable unit (binary) "autodec" - uses the highest human readable unit (decimal) "fmt" parameter allows to specify the output format: %sb - will be replaced with the short byte size unit (e.g. MiB) %lb - will be replaced with the long byte size unit (e.g. kilobytes) value can be formatted using standard string replacements (e.g. %d, %f) """ ftr = BINARY_FACTOR if units == "autodec": ftr = DECIMAL_FACTOR if units in ("autobin", "autodec"): exp = 0 value = float(self.bytes) while value + 0.01 > ftr: # + 0.01 to balance the float comparison value /= ftr exp += 1 else: ftr, exp = self._parse_units(units.strip()) value = ( float(self.factor**self.exponent) / float(ftr**exp) ) * self.number return self._format(fmt, ftr, exp) % value
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==find_unused_disk:[4:79] ==find_unused_disk:[4:79] __metaclass__ = type DOCUMENTATION = ''' --- module: find_unused_disk short_description: Gets unused disks description: - "WARNING: Do not use this module directly! It is only for role internal use." - Disks are considered in ascending alphanumeric sorted order. - Disks that meet all conditions are considered 'empty' and returned (using kernel device name) in a list. - 1. No known signatures exist on the disk, with the exception of partition tables. - 2. If there is a partition table on the disk, it contains no partitions. - 3. The disk has no holders to eliminate the possibility of it being a multipath or dmraid member device. - 4. Device can be opened with exclusive access to make sure no other software is using it. - If no disks meet all criteria, "Unable to find unused disk" will be returned. - Number of returned disks defaults to first 10, but can be specified with 'max_return' argument. author: Eda Zhou (@edamamez) options: max_return: description: Sets the maximum number of unused disks to return. default: 10 type: int min_size: description: Specifies the minimum disk size to return an unused disk. default: '0' type: str max_size: description: Specifies the maximum disk size to return an unused disk. default: '0' type: str with_interface: description: Specifies which disk interface will be accepted (scsi, virtio, nvme). default: null type: str match_sector_size: description: Specifies whether all returned disks must have the same (logical) sector size. default: false type: bool ''' EXAMPLES = ''' - name: Test finding first unused device module hosts: localhost tasks: - name: Run module find_unused_disk: min_size: '10g' register: testout - name: Dump test output debug: msg: '{{ testout }}' ''' RETURN = ''' disk_name: description: Information about unused disks returned: On success type: complex contains: disks: description: Unused disk(s) that have been found returned: On success type: list sample: | ["sda1", "dm-0", "dm-3"] empty: description: No unused disks were found returned: On success type: str sample: "Unable to find unused disk"
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==module_utils.network_lsr.nm.provider:[4:90] ==module_utils.network_lsr.nm.provider:[4:90] __metaclass__ = type import logging # Relative import is not support by ansible 2.8 yet # pylint: disable=import-error, no-name-in-module from ansible.module_utils.network_lsr.nm import active_connection # noqa:E501 from ansible.module_utils.network_lsr.nm import client # noqa:E501 from ansible.module_utils.network_lsr.nm import connection # noqa:E501 # pylint: enable=import-error, no-name-in-module class NetworkManagerProvider: def deactivate_connection(self, connection_name, timeout, check_mode): """ Return True if changed. """ nm_client = client.get_client() changed = False for nm_ac in nm_client.get_active_connections(): nm_profile = nm_ac.get_connection() if nm_profile and nm_profile.get_id() == connection_name: changed |= active_connection.deactivate_active_connection( nm_ac, timeout, check_mode ) if not changed: logging.info("No active connection for %s", connection_name) return changed def volatilize_connection_by_uuid(self, uuid, timeout, check_mode): """ Mark NM.RemoteConnection as volatile(delete on deactivation) via Update2, if not supported, delete the profile. Return True if changed. """ nm_client = client.get_client() changed = False for nm_profile in nm_client.get_connections(): if nm_profile and nm_profile.get_uuid() == uuid: if hasattr(nm_profile, "update2"): changed |= connection.volatilize_remote_connection( nm_profile, timeout, check_mode ) else: changed |= connection.delete_remote_connection( nm_profile, timeout, check_mode ) if not changed: logging.info("No connection with UUID %s to volatilize", uuid) return changed def get_connections(self): nm_client = client.get_client() return nm_client.get_connections() def get_client_version(self): nm_client = client.get_client() return nm_client.get_version() def reload_configuration(self): timeout = 10 nm_client = client.get_client() main_loop = client.get_mainloop(timeout) logging.debug("Reloading configuration with timeout %s", timeout) nm_client.reload_connections_async( main_loop.cancellable, _reload_config_callback, main_loop ) main_loop.run() def _reload_config_callback(nm_client, result, main_loop): try: success = nm_client.reload_connections_finish(result) except client.GLib.Error as e: logging.warn("Failed to reload configuration: %s", e) main_loop.quit() return if success: logging.debug("Reloading configuration finished") else: logging.warn("Failed to reload configuration, no error message") main_loop.quit()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==module_utils.network_lsr.nm.client:[4:106] ==module_utils.network_lsr.nm.client:[4:106] __metaclass__ = type import logging # Relative import is not support by ansible 2.8 yet # pylint: disable=import-error, no-name-in-module from ansible.module_utils.network_lsr.nm import error # noqa:E501 try: import gi except ImportError: NETWORK_HAS_GI = False else: NETWORK_HAS_GI = True if NETWORK_HAS_GI: try: gi.require_version("NM", "1.0") # It is required to state the NM version before importing it # But this break the flake8 rule: https://www.flake8rules.com/rules/E402.html # Use NOQA: E402 to suppress it. from gi.repository import NM # NOQA: E402 from gi.repository import GLib # NOQA: E402 from gi.repository import Gio # NOQA: E402 # pylint: enable=import-error, no-name-in-module NM GLib Gio except ValueError: # This is to workaround a bug in ansible 2.9 which causes # this code to be executed on the control node, where NM # is not guaranteed to exist. On the other hand, it is # ensured on the managed nodes as NM package is installed # in the network role. Therefore, this exception handling # does not affect the network installation and configuration # on the managed nodes. pass def get_client(): return NM.Client.new() class _NmMainLoop(object): def __init__(self, timeout): self._mainloop = GLib.MainLoop() self._cancellable = Gio.Cancellable.new() self._timeout = timeout self._timeout_id = None def run(self): logging.debug("NM mainloop running") user_data = None self._timeout_id = GLib.timeout_add( int(self._timeout * 1000), self._timeout_call_back, user_data, ) logging.debug("Added timeout checker") self._mainloop.run() def _timeout_call_back(self, _user_data): logging.error("Timeout") self.fail(error.LsrNetworkNmError("Timeout")) @property def cancellable(self): return self._cancellable @property def is_cancelled(self): if self._cancellable: return self._cancellable.is_cancelled() return True def _clean_up(self): logging.debug("NM mainloop cleaning up") if self._timeout_id: logging.debug("Removing timeout checker") GLib.source_remove(self._timeout_id) self._timeout_id = None if self._cancellable: logging.debug("Canceling all pending tasks") self._cancellable.cancel() self._cancellable = None self._mainloop = None def quit(self): logging.debug("NM mainloop quitting") self._mainloop.quit() self._clean_up() def fail(self, exception): self.quit() raise exception def get_mainloop(timeout): return _NmMainLoop(timeout)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==bsize:[4:61] ==bsize:[4:61] __metaclass__ = type ANSIBLE_METADATA = { 'metadata_version': '1.1', 'status': ['preview'], 'supported_by': 'community' } DOCUMENTATION = ''' --- module: bsize short_description: Module for basic manipulation with byte sizes version_added: "2.13.0" description: - "WARNING: Do not use this module directly! It is only for role internal use." - "Module accepts byte size strings with the units and produces strings in form of input accepted by different storage tools" options: size: description: - String containing number and byte units required: true type: str author: - Jan Pokorny (@japokorn) ''' EXAMPLES = ''' # Obtain sizes in format for various tools - name: Get 10 KiB size bsize: size: 10 KiB ''' RETURN = ''' size: description: Size in binary format units type: str returned: success bytes: description: Size in bytes type: int returned: success lvm: description: Size in binary format. No space after the number, first letter of unit prefix in lowercase only type: str returned: success parted: description: Size in binary format. No space after the number type: str returned: success
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==lvm_gensym:[5:55] ==lvm_gensym:[5:55] __metaclass__ = type ANSIBLE_METADATA = { 'metadata_version': '1.1', 'status': ['preview'], 'supported_by': 'community' } DOCUMENTATION = ''' --- module: lvm_gensym short_description: Generate default names for lvm variables version_added: "2.13.0" description: - "WARNING: Do not use this module directly! It is only for role internal use." - "Module accepts two input strings consisting of a file system type and a mount point path, and outputs names based on system information" options: fs_type: description: - String describing the desired file system type required: true type: str mount: description: - String describing the mount point path required: true type: str author: - Tim Flannagan (@timflannagan) ''' EXAMPLES = ''' - name: Generate names lvm_gensym: fs_type: "{{ fs_type }}" mount: "{{ mount_point }}" register: lvm_results when: lvm_vg == "" and mount_point != "" and fs_type != "" ''' RETURN = ''' vg_name: description: The default generated name for an unspecified volume group type: str returned: success lv_name: description: The default generated name for an unspecified logical volume type: str returned: success
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_escape_chars:[12:74] ==scripts.fix_escape_chars:[12:74] base_path = Path(".") yaml_files = list(base_path.glob("roles/**/*.yml")) fixes_applied = 0 for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: content = f.read() original_content = content # Fix escaped quotes inside double-quoted strings # Pattern: "...\'...\'" -> "...'...'" content = re.sub(r'"([^"]*?)\\\'([^"]*?)\\\'"', r'"\1\'\2\'"', content) # Fix escaped quotes in Jinja filters within double quotes # Pattern: "{{ var | default(\'value\') }}" -> "{{ var | default('value') }}" content = re.sub(r'"(\{\{[^}]*?\|\s*default\s*\()\\\'([^\\\']*?)\\\'\)([^}]*?\}\})"', r'"\1\'\2\'\)\3"', content) # Alternative pattern for the same issue content = re.sub(r'"([^"]*?default\s*\()\\\'([^\\\']*?)\\\'\)([^"]*?)"', r'"\1\'\2\'\)\3"', content) # More generic fix for any escaped single quotes in double-quoted strings content = re.sub(r'"([^"]*?)\\\'([^"]*?)"', r'"\1\'\2"', content) if content != original_content: with open(file_path, 'w', encoding='utf-8') as f: f.write(content) fixes_applied += 1 print(f"Fixed escape character errors in {file_path}") except Exception as e: print(f"Error fixing escape characters in {file_path}: {e}") return fixes_applied def main(): print("🔧 Fixing escape character errors in YAML files...") fixes = fix_escape_character_errors() print(f"✅ Fixed escape character errors in {fixes} files") if fixes > 0: print("\n🔍 Validating YAML syntax after fixes...") # Quick validation check import yaml yaml_files = list(Path(".").glob("roles/**/*.yml")) valid_count = 0 error_count = 0 for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: yaml.safe_load(f) valid_count += 1 except yaml.YAMLError: error_count += 1 print(f"📊 YAML validation results: {valid_count} valid, {error_count} with errors") if __name__ == "__main__": main()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==resolve_blockdev:[4:50] ==resolve_blockdev:[4:50] __metaclass__ = type ANSIBLE_METADATA = { 'metadata_version': '1.1', 'status': ['preview'], 'supported_by': 'community' } DOCUMENTATION = ''' --- module: resolve_blockdev short_description: Resolve block device specification to device node path. version_added: "2.13.0" description: - "WARNING: Do not use this module directly! It is only for role internal use." - "This module accepts various forms of block device identifiers and resolves them to the correct block device node path." options: spec: description: - String describing a block device required: true type: str author: - David Lehman (@dwlehman) ''' EXAMPLES = ''' - name: Resolve device by label resolve_blockdev: spec: LABEL=MyData - name: Resolve device by name resolve_blockdev: spec: mpathb - name: Resolve device by /dev/disk/by-id symlink name resolve_blockdev: spec: wwn-0x5000c5005bc37f3f ''' RETURN = ''' device: description: Path to block device node type: str returned: success
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==module_utils.network_lsr.ethtool:[4:64] ==module_utils.network_lsr.ethtool:[4:64] __metaclass__ = type import array import struct import fcntl import socket from .utils import Util ETHTOOL_GPERMADDR = 0x00000020 SIOCETHTOOL = 0x8946 MAX_ADDR_LEN = 32 IFNAMESIZ = 16 def get_perm_addr(ifname): """ Return the Permanent address value for the specified interface using the ETHTOOL_GPERMADDR ioctl command. Please for further documentation, see: wokeignore:rule=master https://github.com/torvalds/linux/blob/master/include/uapi/linux/ethtool.h#L734 wokeignore:rule=master https://github.com/torvalds/linux/blob/master/include/uapi/linux/ethtool.h#L1388 https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/tree/ethtool.c#n4172 """ try: sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM) sockfd = sock.fileno() ifname = ifname.encode("utf-8") if len(ifname) > IFNAMESIZ: return None ecmd = array.array( "B", struct.pack( "II%is" % MAX_ADDR_LEN, ETHTOOL_GPERMADDR, MAX_ADDR_LEN, b"\x00" * MAX_ADDR_LEN, ), ) ifreq = struct.pack("%isP" % IFNAMESIZ, ifname, ecmd.buffer_info()[0]) fcntl.ioctl(sockfd, SIOCETHTOOL, ifreq) try: res = ecmd.tobytes() except AttributeError: # tobytes() is not available in python2 # pylint: disable=no-member res = ecmd.tostring() # pylint: enable=no-member unused, size, perm_addr = struct.unpack("II%is" % MAX_ADDR_LEN, res) perm_addr = Util.mac_ntoa(perm_addr[:size]) except IOError: perm_addr = None finally: sock.close() return perm_addr
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==library.network_state:[6:42] ==library.network_state:[6:42] __metaclass__ = type DOCUMENTATION = r""" --- module: network_state version_added: "2.13.0" short_description: module for network role to apply network state configuration description: - This module allows to apply the network state configuration through nmstate, https://github.com/nmstate/nmstate options: desired_state: description: Nmstate state definition required: true type: dict author: "Wen Liang (@liangwen12year)" """ EXAMPLES = r""" network_state: desired_state: dns-resolver: config: search: - example.com - example.org server: - 2001:4860:4860::8888 - 8.8.8.8 """ RETURN = r""" state: description: Network state after running the module type: dict returned: always
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==blockdev_info:[4:36] ==blockdev_info:[4:36] __metaclass__ = type ANSIBLE_METADATA = { 'metadata_version': '1.1', 'status': ['preview'], 'supported_by': 'community' } DOCUMENTATION = ''' --- module: blockdev_info short_description: Collect info about block devices in the system. version_added: "2.13.0" description: - "WARNING: Do not use this module directly! It is only for role internal use." - "This module collects information about block devices" options: {} author: - David Lehman (@dwlehman) ''' EXAMPLES = ''' - name: Get info about block devices blockdev_info: register: blk_info ''' RETURN = ''' info: description: dict w/ device path keys and device info dict values returned: success type: dict
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.generate_compatibility_matrix:[28:50] ==scripts.generate_enhanced_compatibility_matrix:[126:144] for role_dir in self.roles_dir.iterdir(): if role_dir.is_dir() and role_dir.name.startswith("kvmhost_"): tasks_dir = role_dir / "tasks" if tasks_dir.exists(): for task_file in tasks_dir.glob("*.yml"): try: with open(task_file, 'r') as f: content = f.read() for pattern in version_patterns: if pattern in content.lower(): if "rhel8" in pattern or "el8" in pattern: rhel_versions.add("8") elif "rhel9" in pattern or "el9" in pattern: rhel_versions.add("9") elif "rhel10" in pattern or "el10" in pattern: rhel_versions.add("10") except Exception as e: print(f"Warning: Could not read {task_file}: {e}")
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.generate_compatibility_matrix:[28:50] ==scripts.generate_enhanced_compatibility_matrix:[126:144] for role_dir in self.roles_dir.iterdir(): if role_dir.is_dir() and role_dir.name.startswith("kvmhost_"): tasks_dir = role_dir / "tasks" if tasks_dir.exists(): for task_file in tasks_dir.glob("*.yml"): try: with open(task_file, 'r') as f: content = f.read() for pattern in version_patterns: if pattern in content.lower(): if "rhel8" in pattern or "el8" in pattern: rhel_versions.add("8") elif "rhel9" in pattern or "el9" in pattern: rhel_versions.add("9") elif "rhel10" in pattern or "el10" in pattern: rhel_versions.add("10") except Exception as e: print(f"Warning: Could not read {task_file}: {e}")
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==blivet:[100:118] ==blivet:[35:53] encryption: description: encryption type: bool encryption_cipher: description: encryption_cipher type: str encryption_key: description: encryption_key file, not the actual key type: str encryption_key_size: description: encryption_key_size type: int encryption_luks_version: description: encryption_luks_version type: str encryption_password: description: encryption_password type: str
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==blivet:[100:118] ==blivet:[35:53] encryption: description: encryption type: bool encryption_cipher: description: encryption_cipher type: str encryption_key: description: encryption_key file, not the actual key type: str encryption_key_size: description: encryption_key_size type: int encryption_luks_version: description: encryption_luks_version type: str encryption_password: description: encryption_password type: str
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==module_utils.network_lsr.nm_provider:[5:60] ==module_utils.network_lsr.nm_provider:[5:60] __metaclass__ = type # pylint: disable=import-error, no-name-in-module from ansible.module_utils.network_lsr.utils import Util # noqa:E501 ETHTOOL_FEATURE_PREFIX = "ETHTOOL_OPTNAME_FEATURE_" ETHTOOL_COALESCE_PREFIX = "ETHTOOL_OPTNAME_COALESCE_" ETHTOOL_RING_PREFIX = "ETHTOOL_OPTNAME_RING_" def get_nm_ethtool_feature(name): """ Translate ethtool feature into Network Manager name :param name: Name of the feature :type name: str :returns: Name of the feature to be used by `NM.SettingEthtool.set_feature()` :rtype: str """ name = ETHTOOL_FEATURE_PREFIX + name.upper() feature = getattr(Util.NM(), name, None) return feature def get_nm_ethtool_coalesce(name): """ Translate ethtool coalesce into Network Manager name :param name: Name of the coalesce :type name: str :returns: Name of the setting to be used by `NM.SettingEthtool.set_coalesce()` :rtype: str """ name = ETHTOOL_COALESCE_PREFIX + name.upper() coalesce = getattr(Util.NM(), name, None) return coalesce def get_nm_ethtool_ring(name): """ Translate ethtool ring option into NetworkManager attribute name :param name: Name of the ring :type name: str :returns: Name of the setting to be used by `NM.SettingEthtool.set_ring()` :rtype: str """ name = ETHTOOL_RING_PREFIX + name.upper() ring = getattr(Util.NM(), name, None) return ring
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint:[278:295] ==scripts.fix_ansible_lint_advanced:[326:343] print(f"📊 Summary:") for fix_type, count in results.items(): if count > 0: print(f" - {fix_type.replace('_', ' ').title()}: {count} files") print(f"\n🎯 Total files fixed: {total_fixes}") if self.fixes_applied: print(f"\n📝 Applied fixes:") for fix in self.fixes_applied[:10]: # Show first 10 print(f" - {fix}") if len(self.fixes_applied) > 10: print(f" ... and {len(self.fixes_applied) - 10} more") return results def main():
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint:[278:295] ==scripts.fix_ansible_lint_advanced:[326:343] print(f"📊 Summary:") for fix_type, count in results.items(): if count > 0: print(f" - {fix_type.replace('_', ' ').title()}: {count} files") print(f"\n🎯 Total files fixed: {total_fixes}") if self.fixes_applied: print(f"\n📝 Applied fixes:") for fix in self.fixes_applied[:10]: # Show first 10 print(f" - {fix}") if len(self.fixes_applied) > 10: print(f" ... and {len(self.fixes_applied) - 10} more") return results def main():
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==_version:[3:21] ==_version:[3:21] __all__ = ["__version__", "__version_tuple__", "version", "version_tuple"] TYPE_CHECKING = False if TYPE_CHECKING: from typing import Tuple from typing import Union VERSION_TUPLE = Tuple[Union[int, str], ...] else: VERSION_TUPLE = object version: str __version__: str __version_tuple__: VERSION_TUPLE version_tuple: VERSION_TUPLE __version__ = version = '0.9.1.dev162+g425a978.d20250807' __version_tuple__ = version_tuple = (0, 9, 1, 'dev162', 'g425a978.d20250807')
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==blivet:[269:281] ==blivet:[71:83] raid_device_count: description: raid_device_count type: int raid_spare_count: description: raid_spare_count type: int raid_metadata_version: description: raid_metadata_version type: str raid_chunk_size: description: raid_chunk_size type: str
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==blivet:[269:281] ==blivet:[71:83] raid_device_count: description: raid_device_count type: int raid_spare_count: description: raid_spare_count type: int raid_metadata_version: description: raid_metadata_version type: str raid_chunk_size: description: raid_chunk_size type: str
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint_advanced:[211:225] ==scripts.fix_ansible_lint_advanced:[77:91] for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: content = f.read() original_content = content lines = content.split('\n') new_lines = [] i = 0 while i < len(lines): line = lines[i] # Look for tasks with become_user but no become
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint_advanced:[211:225] ==scripts.fix_ansible_lint_advanced:[77:91] for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: content = f.read() original_content = content lines = content.split('\n') new_lines = [] i = 0 while i < len(lines): line = lines[i] # Look for tasks with become_user but no become
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==module_utils.network_lsr.nm.connection:[33:47] ==module_utils.network_lsr.nm.connection:[86:100] nm_profile.get_id(), nm_profile.get_uuid(), timeout, ) main_loop.run() return True def _nm_profile_volatile_update2_call_back(nm_profile, result, user_data): main_loop = user_data if main_loop.is_cancelled: return try:
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==module_utils.network_lsr.nm.connection:[33:47] ==module_utils.network_lsr.nm.connection:[86:100] nm_profile.get_id(), nm_profile.get_uuid(), timeout, ) main_loop.run() return True def _nm_profile_delete_call_back(nm_profile, result, user_data): main_loop = user_data if main_loop.is_cancelled: return try:
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==module_utils.network_lsr.nm.connection:[105:114] ==module_utils.network_lsr.nm.connection:[52:61] id=nm_profile.get_id(), uuid=nm_profile.get_uuid(), error=e ) ) ) if success: main_loop.quit() else: main_loop.fail( error.LsrNetworkNmError(
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==module_utils.network_lsr.nm.connection:[105:114] ==module_utils.network_lsr.nm.connection:[52:61] id=nm_profile.get_id(), uuid=nm_profile.get_uuid(), error=e ) ) ) if success: main_loop.quit() else: main_loop.fail( error.LsrNetworkNmError(
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==module_utils.network_lsr.nm.active_connection:[88:97] ==module_utils.network_lsr.nm.active_connection:[98:108] _deactivate_fail( main_loop, handler_id, nm_ac, "Failed to deactivate connection {id}, error={error}".format( id=nm_ac_id, error=e ), ) return
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==module_utils.network_lsr.nm.active_connection:[88:97] ==module_utils.network_lsr.nm.active_connection:[98:108] _deactivate_fail( main_loop, handler_id, nm_ac, "Failed to deactivate connection {id}, error={error}".format( id=nm_ac_id, error=e ), ) return
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint:[223:234] ==scripts.fix_yaml_parsing:[187:198] fixed_count = 0 yaml_files = list(self.base_path.glob("roles/**/*.yml")) for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: lines = f.readlines() fixed_lines = [] changed = False
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==lvm_gensym:[5:15] ==resolve_blockdev:[4:14] __metaclass__ = type ANSIBLE_METADATA = { 'metadata_version': '1.1', 'status': ['preview'], 'supported_by': 'community' } DOCUMENTATION = ''' ---
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==blockdev_info:[4:14] ==bsize:[4:14] __metaclass__ = type ANSIBLE_METADATA = { 'metadata_version': '1.1', 'status': ['preview'], 'supported_by': 'community' } DOCUMENTATION = ''' ---
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint_advanced:[141:151] ==scripts.fix_ansible_lint_advanced:[259:269] new_lines.append(line) i += 1 new_content = '\n'.join(new_lines) if new_content != original_content: with open(file_path, 'w', encoding='utf-8') as f: f.write(new_content) fixed_count += 1 except Exception as e:
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint_advanced:[141:151] ==scripts.fix_ansible_lint_advanced:[259:269] new_lines.append(line) i += 1 new_content = '\n'.join(new_lines) if new_content != original_content: with open(file_path, 'w', encoding='utf-8') as f: f.write(new_content) fixed_count += 1 except Exception as e:
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint_advanced:[21:34] ==scripts.fix_ansible_lint_advanced:[275:287] fixed_count = 0 yaml_files = list(self.base_path.glob("roles/**/*.yml")) for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: content = f.read() original_content = content # Fix literal comparisons patterns = [
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint_advanced:[21:34] ==scripts.fix_ansible_lint_advanced:[275:287] fixed_count = 0 yaml_files = list(self.base_path.glob("roles/**/*.yml")) for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: content = f.read() original_content = content # Fix literal comparisons patterns = [
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint:[115:131] ==scripts.fix_ansible_lint_advanced:[271:286] return fixed_count def fix_jinja_spacing(self) -> int: """Fix Jinja2 template spacing issues""" fixed_count = 0 yaml_files = list(self.base_path.glob("roles/**/*.yml")) for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: content = f.read() original_content = content # Fix common Jinja spacing issues # {{ var|filter }} -> {{ var | filter }}
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint:[223:234] ==scripts.fix_yaml_parsing:[187:198] fixed_count = 0 yaml_files = list(self.base_path.glob("roles/**/*.yml")) for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: lines = f.readlines() fixed_lines = [] changed = False
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint:[115:131] ==scripts.fix_ansible_lint_advanced:[204:217] return fixed_count def fix_jinja_spacing(self) -> int: """Fix Jinja2 template spacing issues""" fixed_count = 0 yaml_files = list(self.base_path.glob("roles/**/*.yml")) for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: content = f.read() original_content = content # Fix common Jinja spacing issues # {{ var|filter }} -> {{ var | filter }}
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==blivet:[3:13] ==resolve_blockdev:[4:14] __metaclass__ = type ANSIBLE_METADATA = { 'metadata_version': '1.1', 'status': ['preview'], 'supported_by': 'community' } DOCUMENTATION = ''' ---
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==bsize:[4:14] ==lvm_gensym:[5:15] __metaclass__ = type ANSIBLE_METADATA = { 'metadata_version': '1.1', 'status': ['preview'], 'supported_by': 'community' } DOCUMENTATION = ''' ---
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==blivet:[151:159] ==blivet:[86:94] state: description: state type: str default: present choices: ['present', 'absent'] type: description: type type: str
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==blivet:[151:159] ==blivet:[86:94] state: description: state type: str default: present choices: ['present', 'absent'] type: description: type type: str
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==blivet:[3:13] ==blockdev_info:[4:14] __metaclass__ = type ANSIBLE_METADATA = { 'metadata_version': '1.1', 'status': ['preview'], 'supported_by': 'community' } DOCUMENTATION = ''' ---
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_yaml_parsing:[100:117] ==scripts.fix_yaml_parsing:[60:77] return fixed_count def fix_jinja_spacing_artifacts(self) -> int: """Fix spacing artifacts from previous automated fixes""" fixed_count = 0 yaml_files = list(self.base_path.glob("roles/**/*.yml")) for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: content = f.read() original_content = content # Fix various spacing artifacts fixes = [ # Fix excessive spaces around pipes
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_yaml_parsing:[100:117] ==scripts.fix_yaml_parsing:[60:77] return fixed_count def fix_malformed_jinja_escaping(self) -> int: """Fix malformed Jinja template escaping""" fixed_count = 0 yaml_files = list(self.base_path.glob("roles/**/*.yml")) for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: content = f.read() original_content = content # Fix various malformed escaping patterns fixes = [ # Fix \'string\' -> 'string'
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint_advanced:[333:343] ==scripts.fix_yaml_parsing:[347:357] if self.fixes_applied: print(f"\n📝 Applied fixes:") for fix in self.fixes_applied[:10]: # Show first 10 print(f" - {fix}") if len(self.fixes_applied) > 10: print(f" ... and {len(self.fixes_applied) - 10} more") return results def main():
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint_advanced:[190:199] ==scripts.fix_ansible_lint_advanced:[41:50] ] for pattern, replacement in patterns: content = re.sub(pattern, replacement, content) if content != original_content: with open(file_path, 'w', encoding='utf-8') as f: f.write(content) fixed_count += 1
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint_advanced:[190:199] ==scripts.fix_ansible_lint_advanced:[41:50] ] for pattern, replacement in patterns: content = re.sub(pattern, replacement, content) if content != original_content: with open(file_path, 'w', encoding='utf-8') as f: f.write(content) fixed_count += 1
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint_advanced:[208:217] ==scripts.fix_ansible_lint_advanced:[21:32] fixed_count = 0 yaml_files = list(self.base_path.glob("roles/**/*.yml")) for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: content = f.read() original_content = content
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint:[285:295] ==scripts.fix_yaml_parsing:[347:357] if self.fixes_applied: print(f"\n📝 Applied fixes:") for fix in self.fixes_applied[:10]: # Show first 10 print(f" - {fix}") if len(self.fixes_applied) > 10: print(f" ... and {len(self.fixes_applied) - 10} more") return results def main():
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint:[119:131] ==scripts.fix_ansible_lint_advanced:[21:32] fixed_count = 0 yaml_files = list(self.base_path.glob("roles/**/*.yml")) for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: content = f.read() original_content = content # Fix complex Jinja patterns with multiple pipes and spaces
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.generate_compatibility_matrix:[84:92] ==scripts.generate_enhanced_compatibility_matrix:[249:258] if tasks_dir.exists(): for task_file in tasks_dir.glob("*.yml"): try: with open(task_file, 'r') as f: content = f.read() # Extract feature name from file feature_name = task_file.stem
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.generate_enhanced_compatibility_matrix:[128:134] ==scripts.generate_enhanced_compatibility_matrix:[248:256] tasks_dir = role_dir / "tasks" if tasks_dir.exists(): for task_file in tasks_dir.glob("*.yml"): try: with open(task_file, 'r') as f: content = f.read()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.generate_compatibility_matrix:[84:92] ==scripts.generate_enhanced_compatibility_matrix:[249:258] if tasks_dir.exists(): for task_file in tasks_dir.glob("*.yml"): try: with open(task_file, 'r') as f: content = f.read() # Extract feature names from task file names feature_name = task_file.stem
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.generate_compatibility_matrix:[31:37] ==scripts.generate_enhanced_compatibility_matrix:[248:256] tasks_dir = role_dir / "tasks" if tasks_dir.exists(): for task_file in tasks_dir.glob("*.yml"): try: with open(task_file, 'r') as f: content = f.read()
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_yaml_parsing:[169:178] ==scripts.fix_yaml_parsing:[86:95] ] for pattern, replacement in fixes: content = re.sub(pattern, replacement, content) if content != original_content: with open(file_path, 'w', encoding='utf-8') as f: f.write(content) fixed_count += 1
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_yaml_parsing:[169:178] ==scripts.fix_yaml_parsing:[86:95] ] for pattern, replacement in fixes: content = re.sub(pattern, replacement, content) if content != original_content: with open(file_path, 'w', encoding='utf-8') as f: f.write(content) fixed_count += 1
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_yaml_parsing:[183:193] ==scripts.fix_yaml_parsing:[60:70] return fixed_count def fix_indentation_issues(self) -> int: """Fix common indentation issues that break YAML parsing""" fixed_count = 0 yaml_files = list(self.base_path.glob("roles/**/*.yml")) for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f:
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint_advanced:[192:199] ==scripts.fix_yaml_parsing:[48:55] for pattern, replacement in patterns: content = re.sub(pattern, replacement, content) if content != original_content: with open(file_path, 'w', encoding='utf-8') as f: f.write(content) fixed_count += 1
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint_advanced:[43:50] ==scripts.fix_yaml_parsing:[48:55] for pattern, replacement in patterns: content = re.sub(pattern, replacement, content) if content != original_content: with open(file_path, 'w', encoding='utf-8') as f: f.write(content) fixed_count += 1
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint:[115:125] ==scripts.fix_yaml_parsing:[183:193] return fixed_count def fix_indentation_issues(self) -> int: """Fix common indentation issues that break YAML parsing""" fixed_count = 0 yaml_files = list(self.base_path.glob("roles/**/*.yml")) for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f:
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==blivet:[203:264] ==blivet:[98:159] elements: dict suboptions: encryption: description: encryption type: bool encryption_cipher: description: encryption_cipher type: str encryption_key: description: encryption_key file, not the actual key type: str encryption_key_size: description: encryption_key_size type: int encryption_luks_version: description: encryption_luks_version type: str encryption_password: description: encryption_password type: str fs_create_options: description: fs_create_options type: str fs_label: description: fs_label type: str fs_type: description: fs_type type: str mount_options: description: mount_options type: str mount_point: description: mount_point type: str mount_user: description: mount_user type: str mount_group: description: mount_group type: str mount_mode: description: mount_mode type: str name: description: name type: str raid_level: description: raid_level type: str size: description: size type: str state: description: state type: str default: present choices: ['present', 'absent'] type: description: type type: str
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==blivet:[203:264] ==blivet:[98:159] elements: dict suboptions: encryption: description: encryption type: bool encryption_cipher: description: encryption_cipher type: str encryption_key: description: encryption_key file, not the actual key type: str encryption_key_size: description: encryption_key_size type: int encryption_luks_version: description: encryption_luks_version type: str encryption_password: description: encryption_password type: str fs_create_options: description: fs_create_options type: str fs_label: description: fs_label type: str fs_type: description: fs_type type: str mount_options: description: mount_options type: str mount_point: description: mount_point type: str mount_user: description: mount_user type: str mount_group: description: mount_group type: str mount_mode: description: mount_mode type: str name: description: name type: str raid_level: description: raid_level type: str size: description: size type: str state: description: state type: str default: present choices: ['present', 'absent'] type: description: type type: str
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==blivet:[142:148] ==blivet:[65:71] name: description: name type: str raid_level: description: raid_level type: str
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==blivet:[142:148] ==blivet:[65:71] name: description: name type: str raid_level: description: raid_level type: str
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==module_utils.network_lsr.argument_validator:[650:656] ==module_utils.network_lsr.argument_validator:[714:721] prefix = result["prefix"] if prefix is None: prefix = Util.addr_family_default_prefix(family) result["prefix"] = prefix elif not Util.addr_family_valid_prefix(family, prefix): raise ValidationError(name, "invalid prefix %s in '%s'" % (prefix, value))
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==module_utils.network_lsr.argument_validator:[650:656] ==module_utils.network_lsr.argument_validator:[714:721] prefix = result["prefix"] if prefix is None: prefix = Util.addr_family_default_prefix(family) result["prefix"] = prefix elif not Util.addr_family_valid_prefix(family, prefix): raise ValidationError(name, "invalid prefix %s in '%s'" % (prefix, value))
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==module_utils.network_lsr.argument_validator:[614:620] ==module_utils.network_lsr.argument_validator:[661:667] ArgValidatorDict.__init__( self, name, required, nested=[ ArgValidatorIP(
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==module_utils.network_lsr.argument_validator:[614:620] ==module_utils.network_lsr.argument_validator:[661:667] ArgValidatorDict.__init__( self, name, required, nested=[ ArgValidatorIP(
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==module_utils.network_lsr.argument_validator:[596:602] ==module_utils.network_lsr.argument_validator:[603:609] enum_ex = "" if self.enum_values_mac is not None: enum_ex = " nor one of %s" % (self.enum_values_mac) raise ValidationError( name, "value '%s' is not a valid MAC address%s" % (value, enum_ex) )
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==module_utils.network_lsr.argument_validator:[596:602] ==module_utils.network_lsr.argument_validator:[603:609] enum_ex = "" if self.enum_values_mac is not None: enum_ex = " nor one of %s" % (self.enum_values_mac) raise ValidationError( name, "value '%s' is not a valid MAC address%s" % (value, enum_ex) )
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.generate_compatibility_matrix:[134:140] ==scripts.generate_enhanced_compatibility_matrix:[343:349] for role_dir in self.roles_dir.iterdir(): if role_dir.is_dir() and role_dir.name.startswith("kvmhost_"): role_name = role_dir.name print(f"Analyzing role: {role_name}") role_features = self.analyze_role_features(role_name)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint_advanced:[271:286] ==scripts.fix_yaml_parsing:[60:75] return fixed_count def fix_malformed_jinja_escaping(self) -> int: """Fix malformed Jinja template escaping""" fixed_count = 0 yaml_files = list(self.base_path.glob("roles/**/*.yml")) for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: content = f.read() original_content = content # Fix various malformed escaping patterns
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint:[248:254] ==scripts.fix_yaml_parsing:[220:226] fixed_lines.append(line) if changed: with open(file_path, 'w', encoding='utf-8') as f: f.writelines(fixed_lines) fixed_count += 1
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint:[122:131] ==scripts.fix_yaml_parsing:[41:48] for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: content = f.read() original_content = content # Fix common Jinja spacing issues # {{ var|filter }} -> {{ var | filter }}
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint:[296:303] ==scripts.fix_ansible_lint_advanced:[344:351] results = fixer.run_all_fixes() print(f"\n🔍 Run 'ansible-lint roles/' again to see remaining issues") return 0 if sum(results.values()) > 0 else 1 if __name__ == "__main__": sys.exit(main())
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.generate_enhanced_compatibility_matrix:[105:110] ==scripts.generate_enhanced_compatibility_matrix:[223:228] molecule_yml = scenario_dir / "molecule.yml" if molecule_yml.exists(): try: with open(molecule_yml, 'r') as f: molecule_config = yaml.safe_load(f)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.generate_enhanced_compatibility_matrix:[105:110] ==scripts.generate_enhanced_compatibility_matrix:[223:228] molecule_yml = scenario_dir / "molecule.yml" if molecule_yml.exists(): try: with open(molecule_yml, 'r') as f: molecule_config = yaml.safe_load(f)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.generate_compatibility_matrix:[32:37] ==scripts.generate_compatibility_matrix:[84:91] if tasks_dir.exists(): for task_file in tasks_dir.glob("*.yml"): try: with open(task_file, 'r') as f: content = f.read() # Extract feature names from task file names
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.generate_compatibility_matrix:[134:140] ==scripts.generate_enhanced_compatibility_matrix:[343:349] for role_dir in self.roles_dir.iterdir(): if role_dir.is_dir() and role_dir.name.startswith("kvmhost_"): role_name = role_dir.name print(f"Analyzing role: {role_name}") role_features = self.analyze_role_features(role_name)
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.generate_compatibility_matrix:[84:91] ==scripts.generate_enhanced_compatibility_matrix:[129:134] if tasks_dir.exists(): for task_file in tasks_dir.glob("*.yml"): try: with open(task_file, 'r') as f: content = f.read() # Extract feature names from task file names
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_yaml_parsing:[172:178] ==scripts.fix_yaml_parsing:[49:55] content = re.sub(pattern, replacement, content) if content != original_content: with open(file_path, 'w', encoding='utf-8') as f: f.write(content) fixed_count += 1
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_escape_chars:[17:26] ==scripts.fix_yaml_parsing:[154:162] for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: content = f.read() original_content = content # Fix mixed quotes in YAML values
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint_advanced:[204:217] ==scripts.fix_yaml_parsing:[147:162] return fixed_count def fix_quote_inconsistencies(self) -> int: """Fix quote inconsistencies that can cause YAML parsing issues""" fixed_count = 0 yaml_files = list(self.base_path.glob("roles/**/*.yml")) for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: content = f.read() original_content = content # Fix mixed quotes in YAML values
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint_advanced:[178:185] ==scripts.fix_yaml_parsing:[107:115] for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: content = f.read() original_content = content # Fix various spacing artifacts
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint_advanced:[77:83] ==scripts.fix_yaml_parsing:[67:75] for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: content = f.read() original_content = content # Fix various malformed escaping patterns
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint_advanced:[21:27] ==scripts.fix_yaml_parsing:[187:193] fixed_count = 0 yaml_files = list(self.base_path.glob("roles/**/*.yml")) for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f:
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint_advanced:[326:333] ==scripts.fix_yaml_parsing:[329:335] print(f"📊 Summary:") for fix_type, count in results.items(): if count > 0: print(f" - {fix_type.replace('_', ' ').title()}: {count} files") print(f"\n🎯 Total files fixed: {total_fixes}")
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint_advanced:[271:281] ==scripts.fix_yaml_parsing:[183:193] return fixed_count def fix_indentation_issues(self) -> int: """Fix common indentation issues that break YAML parsing""" fixed_count = 0 yaml_files = list(self.base_path.glob("roles/**/*.yml")) for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f:
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint_advanced:[204:213] ==scripts.fix_yaml_parsing:[231:241] return fixed_count def fix_unicode_and_encoding_issues(self) -> int: """Fix unicode and encoding issues that can break YAML parsing""" fixed_count = 0 yaml_files = list(self.base_path.glob("roles/**/*.yml")) for file_path in yaml_files: try: # Try to read with different encodings
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint_advanced:[298:304] ==scripts.fix_yaml_parsing:[89:95] content = re.sub(pattern, replacement, content) if content != original_content: with open(file_path, 'w', encoding='utf-8') as f: f.write(content) fixed_count += 1
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint:[161:168] ==scripts.fix_ansible_lint_advanced:[278:286] for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: content = f.read() original_content = content # Fix literal comparisons
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint_advanced:[271:286] ==scripts.fix_yaml_parsing:[100:115] return fixed_count def fix_jinja_spacing_artifacts(self) -> int: """Fix spacing artifacts from previous automated fixes""" fixed_count = 0 yaml_files = list(self.base_path.glob("roles/**/*.yml")) for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: content = f.read() original_content = content # Fix various spacing artifacts
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint_advanced:[204:214] ==scripts.fix_yaml_parsing:[183:193] return fixed_count def fix_indentation_issues(self) -> int: """Fix common indentation issues that break YAML parsing""" fixed_count = 0 yaml_files = list(self.base_path.glob("roles/**/*.yml")) for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f:
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint_advanced:[204:217] ==scripts.fix_yaml_parsing:[60:75] return fixed_count def fix_malformed_jinja_escaping(self) -> int: """Fix malformed Jinja template escaping""" fixed_count = 0 yaml_files = list(self.base_path.glob("roles/**/*.yml")) for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: content = f.read() original_content = content # Fix various malformed escaping patterns
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint_advanced:[193:199] ==scripts.fix_yaml_parsing:[172:178] content = re.sub(pattern, replacement, content) if content != original_content: with open(file_path, 'w', encoding='utf-8') as f: f.write(content) fixed_count += 1
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint_advanced:[44:50] ==scripts.fix_yaml_parsing:[89:95] content = re.sub(pattern, replacement, content) if content != original_content: with open(file_path, 'w', encoding='utf-8') as f: f.write(content) fixed_count += 1
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint_advanced:[211:217] ==scripts.fix_yaml_parsing:[41:48] for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: content = f.read() original_content = content
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint_advanced:[178:185] ==scripts.fix_escape_chars:[17:26] for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: content = f.read() original_content = content
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint:[119:125] ==scripts.fix_ansible_lint:[223:229] fixed_count = 0 yaml_files = list(self.base_path.glob("roles/**/*.yml")) for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f:
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint:[278:285] ==scripts.fix_yaml_parsing:[329:335] print(f"📊 Summary:") for fix_type, count in results.items(): if count > 0: print(f" - {fix_type.replace('_', ' ').title()}: {count} files") print(f"\n🎯 Total files fixed: {total_fixes}")
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint:[248:254] ==scripts.fix_yaml_parsing:[220:226] fixed_lines.append(line) if changed: with open(file_path, 'w', encoding='utf-8') as f: f.writelines(fixed_lines) fixed_count += 1
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint:[115:124] ==scripts.fix_yaml_parsing:[231:241] return fixed_count def fix_jinja_spacing(self) -> int: """Fix Jinja2 template spacing issues""" fixed_count = 0 yaml_files = list(self.base_path.glob("roles/**/*.yml")) for file_path in yaml_files: try:
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint:[296:303] ==scripts.fix_ansible_lint_advanced:[344:351] results = fixer.run_all_fixes() print(f"\n🔍 Run 'ansible-lint roles/' again to see remaining issues") return 0 if sum(results.values()) > 0 else 1 if __name__ == "__main__": sys.exit(main())
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint:[161:168] ==scripts.fix_ansible_lint_advanced:[24:32] for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: content = f.read() original_content = content # Fix complex Jinja patterns with multiple pipes and spaces
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint:[122:131] ==scripts.fix_ansible_lint_advanced:[77:83] for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f: content = f.read() original_content = content # Fix common Jinja spacing issues # {{ var|filter }} -> {{ var | filter }}
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==scripts.fix_ansible_lint:[223:229] ==scripts.fix_ansible_lint_advanced:[21:27] fixed_count = 0 yaml_files = list(self.base_path.glob("roles/**/*.yml")) for file_path in yaml_files: try: with open(file_path, 'r', encoding='utf-8') as f:
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==blivet:[264:269] ==blivet:[30:35] disks: description: disks type: list default: [] elements: str
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==blivet:[264:269] ==blivet:[30:35] disks: description: disks type: list default: [] elements: str
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==module_utils.network_lsr.nm.active_connection:[47:55] ==module_utils.network_lsr.nm.connection:[90:99] main_loop.run() return True def _nm_profile_volatile_update2_call_back(nm_profile, result, user_data): main_loop = user_data if main_loop.is_cancelled: return
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==module_utils.network_lsr.nm.active_connection:[47:55] ==module_utils.network_lsr.nm.connection:[37:46] main_loop.run() return True def _nm_profile_delete_call_back(nm_profile, result, user_data): main_loop = user_data if main_loop.is_cancelled: return
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==module_utils.network_lsr.argument_validator:[614:619] ==module_utils.network_lsr.argument_validator:[736:741] ArgValidatorDict.__init__( self, name, required, nested=[
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
duplicate-code: Similar lines in 2 files ==module_utils.network_lsr.argument_validator:[614:619] ==module_utils.network_lsr.argument_validator:[736:741] ArgValidatorDict.__init__( self, name, required, nested=[
Estimated Effort: Low (1-2 hours)
Priority: P3 | Severity: Medium
Estimated Effort: Low (1-2 hours)
Take these actions right now
Address within current release cycle
Process improvements for future
Detailed mypy analysis results and raw data
File: mypy_results_0.9.1_20250807_034942.json
Detailed pylint analysis results and raw data
File: pylint_results_0.9.1_20250807_034942.json